http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13156 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- URL| |/cgi-bin/koha/suggestion/su | |ggestion.pl CC| |frederic@tamil.fr -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13156 --- Comment #1 from Frédéric Demians <frederic@tamil.fr> --- Created attachment 33133 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33133&action=edit Bug 13156 Display borrower's cardnumber who did a suggestion in suggestion.pl To avoid homonyms, it would be nice if the card number is displayed in the user suggestion.pl. Currently, consult the record of the user to know exactly who made the suggestion. TEST PLAN: Apply the patch. Go on suggestion.pl. Check that nothing has changed, except that cardnumbers are displayed in 'Suggested by' column. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13156 Paola Rossi <paola.rossi@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |paola.rossi@cineca.it --- Comment #2 from Paola Rossi <paola.rossi@cineca.it> --- I've tried to apply the patch against master 3.17.00.052 HEAD 13113 Applying: Bug 13156 Display borrower's cardnumber who did a suggestion in suggestion.pl Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt Auto-merging C4/Suggestions.pm Failed to merge in the changes. Patch failed at 0001 Bug 13156 Display borrower's cardnumber who did a suggestion in suggestion.pl So I pass the patch to "Patch doesn't apply" status. NB. On master, in the template, from patron's "Surname, firstname" there is a "mailto" link in the template. The test plan requires "consulting the record of the user, to know exactly who made the suggestion". Please, does the test plan require the barcode to be a link or not? In case, which link? Thanks. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13156 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch Attachment #33133|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13156 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13156 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Status|Passed QA |Pushed to Master --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Frederic! -- You are receiving this mail because: You are watching all bug changes.