http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7618 --- Comment #1 from David Cook <dcook@prosentient.com.au> 2012-03-02 00:13:13 UTC --- Created attachment 7976 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7976 Bug 7618 HTML Escaped SQL It's just a simple change to the intranet template for the Guided Reports in Koha 3.2. If you look at the template, the SQL is also displayed in a hidden field which is already HTML special character escaped. I just copied that format, and voila it worked. The fix for Koha 3.6+ could be achieved similarly. Rationale: I had noticed that any SQL report with angle brackets (< >) wouldn't display properly when running a report, since the browser would interpret it as HTML. Besides being an incorrect representation of the SQL used in the report, it also had the tendency of breaking the result table, which often meant that all the results were a single string flowing out of the SQL. It's quite an uncommon problem overall, but it's a re-occurring issue with reports using the older method of retrieving values from marcxml fields. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7618 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7618 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |In Discussion --- Comment #3 from David Cook <dcook@prosentient.com.au> --- I'm not sure that I understand why/how Koha 3.2 wouldn't be supported by the community (am I not a member of the community?), since the branch is still available via the git. Also, it appears that you are incorrect about the patch breaking the links in the report. If you look at guided_reports_start.tmpl, you'll see that I'm just escaping the HTML characters in the SQL that is displayed above the results. The HTML in the actual results still works perfectly fine. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7618 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz --- Comment #5 from Chris Cormack <chris@bigballofwax.co.nz> --- (In reply to comment #3)

I'm not sure that I understand why/how Koha 3.2 wouldn't be supported by the community (am I not a member of the community?), since the branch is still available via the git.

Not supported, maintained. It's still available on git, but has been end of lifed. There will be no more 3.2.x releases ever. The 2 stable branches are 3.4.x and 3.6.x .. the current stable releases are 3.4.7 and 3.6.4. The last release for 3.2.x was 3.2.11 3 months ago. When 3.8.0 is released in april, the 3.4.x branch will be end of lifed also. We keep 2 stable branches and 1 development branch running.

Also, it appears that you are incorrect about the patch breaking the links in the report. If you look at guided_reports_start.tmpl, you'll see that I'm just escaping the HTML characters in the SQL that is displayed above the results. The HTML in the actual results still works perfectly fine.

There are no longer any .tmpl files in Koha, since 3.4.0 we switched to template toolkit. This is a major reason this patch will not apply for master. Patches should be written to be applied to master, then cherry-picked by the release maintainer to the appropriate stable branch. If this patch was rewritten to apply to the master (development branch) then it could be backported to 3.4.x and 3.6.x and be in the next releases of those. As well as being in the next feature release 3.8.0. Hope this clears it up. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7618 --- Comment #7 from Chris Cormack <chris@bigballofwax.co.nz> --- (In reply to comment #6)

I've taken a look at the master code, and the fix looks conceptually the same, despite the change in template management. Should I upload a new patch for the master branch on this same bug (after changing the version details)?

That would be perfect in TT to filter you would do | html eg [% sql | html %] -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7618 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff Version|rel_3_2 |master -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7618 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #10 from Chris Cormack <chris@bigballofwax.co.nz> --- Small change, works well, signed off -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7618 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain@biblibre.com Version|master |rel_3_6 --- Comment #12 from Paul Poulain <paul.poulain@biblibre.com> --- Patch pushed, and welcomed David, you're the 178th dev to have a patch pushed ! (added you on about page) -- You are receiving this mail because: You are watching all bug changes.