http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7670 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7670 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |wizzyrea@gmail.com -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7670 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.poulain@biblibre.com Summary|make required fields red |make required fields red in | |additem.pl --- Comment #4 from Paul Poulain <paul.poulain@biblibre.com> --- QA comment: If you try to save without entering a mandatory field, the highlighting is made "light red on dark red", that's quite hard to read. If I compare the result with the addbiblio.pl file, it's not consistent (in addbiblio.pl, an empty mandatory field become yellow, the description is not updated) Could you do improve your patch a little bit more ? (not marking failed QA, if you say "no", i'll push it as it is, and yell that you're the one to blame if someone complain :D :D ) -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7670 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #8093|0 |1 is obsolete| | --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 8190 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8190&action=edit Bug 7670 - make required fields red Adding "required" style and "Required" note to additem fields, consistent with the way required fields are displayed on the add patron form. This patch also corrects an error in the client-side validation script which misidentified which fields were required. Leaving a required field empty should result in an alert and the missing field being highlighted in yellow. To test, open the add item form on a record which uses a framework in which one or more item fields are required. Required fields should be labeled in red and appended with a "Required" note. Submit the form while some required fields are empty. You should see a javascript alert. The empty mandatory fields should have a yellow background. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7670 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #8190|0 |1 is obsolete| | --- Comment #6 from Liz Rea <wizzyrea@gmail.com> --- Created attachment 8191 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8191&action=edit Bug 7670 - make required fields red Adding "required" style and "Required" note to additem fields, consistent with the way required fields are displayed on the add patron form. This patch also corrects an error in the client-side validation script which misidentified which fields were required. Leaving a required field empty should result in an alert and the missing field being highlighted in yellow. To test, open the add item form on a record which uses a framework in which one or more item fields are required. Required fields should be labeled in red and appended with a "Required" note. Submit the form while some required fields are empty. You should see a javascript alert. The empty mandatory fields should have a yellow background. Signed-off-by: Liz Rea <wizzyrea@gmail.com> Works - passes tests. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7670 Ian Walls <koha.sekjal@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #7 from Ian Walls <koha.sekjal@gmail.com> --- Still just a template/CSS change, but now with better highlighting. Moving back to Passed QA. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7670 --- Comment #9 from Robin Sheat <robin@catalyst.net.nz> --- Created attachment 8247 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8247&action=edit Bug 7670 - make required fields red Adding "required" style and "Required" note to additem fields, consistent with the way required fields are displayed on the add patron form. This patch also corrects an error in the client-side validation script which misidentified which fields were required. Leaving a required field empty should result in an alert and the missing field being highlighted in yellow. To test, open the add item form on a record which uses a framework in which one or more item fields are required. Required fields should be labeled in red and appended with a "Required" note. Submit the form while some required fields are empty. You should see a javascript alert. The empty mandatory fields should have a yellow background. Signed-off-by: Liz Rea <wizzyrea@gmail.com> Works - passes tests. Signed-off-by: Paul Poulain <paul.poulain@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7670 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #11 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch will be included in 3.6.5. -- You are receiving this mail because: You are watching all bug changes.