https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30177 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|When changing patron |When changing patron |categories of existing |categories of existing |accounts should not reset |accounts it should not |message prefs without first |reset message prefs without |warning staff |first warning staff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30177 --- Comment #1 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 131067 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131067&action=edit Bug 30177: When editing an existing patron set message_prefs_dirty to true 1 - Define default messaging preferences for a patron category 2 - Go into an existing account and change the patron category to the one set in step 1. 3 - Confirm that the messaging prefs have been reset to that of the default patron category 4 - Apply patch 5 - Repeat Step 2, this time you should see a warning asking if you want to set messaging prefs to the category default 6 - Press OK and save. Confirm that the messaging prefs are now set to the default for that category 7 - Try it again with an existing account and press Cancel this time. Notice that there should be no change to the patron messaging prefs. 8 - Try making a new patron and switching the category, you should see no warning and the message prefs should be proberly set to the defaults of any category you choose. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30177 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30177 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I am sorry, patch applied, restart_all and did a couple of reloads... but I can't get the warning to trigger. :( Not sure if this is also a separate bug: When the defaults are changed, the digest option although added for the patron category is not checked. The age warning might also upset things a bit, but I tried without that and still no luck. Testing in Firefox on Ubuntu. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30177 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Ok, this is the thing: * Updated setting for patron category staff, checking Item due with digest. * Apply patch, reload and restart all the things. * Edit 'Nicole Schneider' * Set patron category to 'staff' * Accept changes to default with OK * Verify: The digest option appears checked, but greyed out. * Save * Edit patron again - the digest option is not set I'll file this as a new bug, as it happens without the patch set too :( Passing QA here meanwhile. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30177 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131342|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 131417 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131417&action=edit Bug 30177: When editing an existing patron set message_prefs_dirty to true 1 - Define default messaging preferences for a patron category 2 - Go into an existing account and change the patron category to the one set in step 1. 3 - Confirm that the messaging prefs have been reset to that of the default patron category 4 - Apply patch 5 - Repeat Step 2, this time you should see a warning asking if you want to set messaging prefs to the category default 6 - Press OK and save. Confirm that the messaging prefs are now set to the default for that category 7 - Try it again with an existing account and press Cancel this time. Notice that there should be no change to the patron messaging prefs. 8 - Try making a new patron and switching the category, you should see no warning and the message prefs should be proberly set to the defaults of any category you choose. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30177 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Manual, | |release-notes-needed Summary|When changing patron |When changing patron |categories of existing |categories of existing |accounts it should not |accounts it should not |reset message prefs without |reset message prefs without |first warning staff |warning -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30177 --- Comment #7 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30177 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.