https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27497 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |fridolin.somers@biblibre.co |ity.org |m Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27497 --- Comment #1 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 115443 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115443&action=edit Bug 27497: Display Koha version in header under logo in staff interface Can be very useful to know on any page of staff interface Koha version. I made a plugin : https://github.com/biblibre/koha-plugin-intranet-version-in-header But seems better to provide a patch. This patch created a new include logo.inc that contains the logo and version, called in all header includes. It adds a div with id "header_logo" to be able to set float on the parent of logo and version. So h1#logo must be replaced in all CSS files. It removes in staff-global.scss rules about h1#logo since they all are in #logo. Test plan: 1) Go to staff interface 2) Check you see Koha version YY.MM.XX under logo 3) Check it is responsive 4) Check it is not displayed when printing home page 4) Check it is not displayed when printing receipt invoice 5) Check all modules home page 6) Check right-to-left display -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27497 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard@myacpl.org -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27497 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115445|Screenshot without patch |Screenshot description| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27497 Barbara Johnson <barbara.johnson@bedfordtx.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |barbara.johnson@bedfordtx.g | |ov See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=27097 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27497 Lisette Scheer <lisetteslatah@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah@gmail.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27497 --- Comment #7 from Fridolin Somers <fridolin.somers@biblibre.com> --- (In reply to Barbara Johnson from comment #5)

I think the lower right-hand side of the page would be a better place to display the version number. I think if my staff sees just 20.05.06 floating under the logo I will get lots of questions regarding what it is.

I also think it needs to have the word 'version' included in order to make it very explicit as to what the numbers mean, such as 'version 20.05.06'. Ok good idea

Being in the lower right-hand side of the page mirrors the standard placement of the "Powered by Koha" that displays on the OPAC.

Ok. But actually in staff interface, if there is no language select possibility there is no lower bar in the page. Is it OK to always show a lower floating bar to the page ? Your librarians are very happy to see the exact version of Koha so they can see what bug fix or feature is inside :D -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27497 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Display Koha version in |Display Koha version in |header under logo in staff |staff interface |interface | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27497 --- Comment #9 from Lisette Scheer <lisetteslatah@gmail.com> --- (In reply to Fridolin Somers from comment #8)

And what do you think displaying the version below "About Koha" in main page ? Since version is displayed is this page about.pl

+1 I really like this idea. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27497 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115444|0 |1 is obsolete| | --- Comment #10 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 115834 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115834&action=edit Bug 27497: (follow-up) Suggested new placement This patch modifies include files and SCSS to move the version information into the "About Koha" menu item in the header menu. To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...). In the staff client, click the "More" menu in the header. You should see version information next to the "About Koha" menu item. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27497 wainuiwitikapark@catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27497 wainuiwitikapark@catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115834|0 |1 is obsolete| | --- Comment #13 from wainuiwitikapark@catalyst.net.nz --- Created attachment 115999 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115999&action=edit Bug 27497: (follow-up) Suggested new placement This patch modifies include files and SCSS to move the version information into the "About Koha" menu item in the header menu. To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...). In the staff client, click the "More" menu in the header. You should see version information next to the "About Koha" menu item. Signed-off-by: Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27497 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115999|0 |1 is obsolete| | --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 116103 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116103&action=edit Bug 27497: (follow-up) Suggested new placement This patch modifies include files and SCSS to move the version information into the "About Koha" menu item in the header menu. To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...). In the staff client, click the "More" menu in the header. You should see version information next to the "About Koha" menu item. Signed-off-by: Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27497 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115445|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27497 --- Comment #17 from Barbara Johnson <barbara.johnson@bedfordtx.gov> --- I agree with Fridolin. My hope was that the version would display more prominently without having to click on 'About Koha' or 'More.' I attached a screenshot that shows the version in the lower right hand corner of the main/hone page. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27497 --- Comment #19 from David Cook <dcook@prosentient.com.au> --- (In reply to Barbara Johnson from comment #17)

I agree with Fridolin. My hope was that the version would display more prominently without having to click on 'About Koha' or 'More.' I attached a screenshot that shows the version in the lower right hand corner of the main/hone page.

I like the sound of this too -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27497 --- Comment #20 from Fridolin Somers <fridolin.somers@biblibre.com> --- (In reply to Barbara Johnson from comment #18)

Created attachment 116172 [details] Display version in lower right corner of home page in staff client

Showing at the bottom may not be visible on a small screen. Or make it float ? add in into language bar ? I propose in the header : https://github.com/biblibre/koha-plugin-intranet-version-in-header/blob/trun... Or maybe above the news in the main page ? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27497 --- Comment #22 from David Cook <dcook@prosentient.com.au> --- (In reply to Fridolin Somers from comment #20)

Showing at the bottom may not be visible on a small screen.

I doubt we'd need to worry about a small screen for the staff interface though?

I propose in the header : https://github.com/biblibre/koha-plugin-intranet-version-in-header/blob/ trunk/Screenshot.png

I think it looks strange there. Like it's a navigation option when it's not. -- I've tried to look for examples elsewhere, but I have 0 examples where the version number is shown on the main screen of the application. So maybe we are going about this the wrong way. It's tempting to add a News item mentioning upgrades to the staff interface, although that might interfere with how people use the News system in practice. -- Or... we just keep it as a plugin. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27497 --- Comment #24 from David Cook <dcook@prosentient.com.au> --- (In reply to Fridolin Somers from comment #23)

I propose we vote in mailling list.

Sounds good to me. I don't feel passionately enough about this one to advocate any particular position. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27497 --- Comment #26 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I like Barbara's suggestion at the bottom of the page, like "credits". It also doesn't work for in the top navigation, as this is misleading and we already have a lot of stuff going on there. I'd also be happy with the initial patch here showing it in the pull down. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27497 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115998|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27497 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27497 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Display Koha version in |Display Koha version in |staff interface |staff interface home page -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27497 --- Comment #29 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 116703 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116703&action=edit Bug 27497: Display Koha version in staff interface home page Koha current version is very useful in staff interface. You can find it in 'About' page but home page is the first page you see. Display it in the lower right-hand side of the page, after 'IntranetmainUserblock' content. Note that it is not a vertical floating text, it whould conflict with languages floating bar. Test plan : 1) Apply patch and update staff client CSS : https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff... 2) Look at staff interface home page and look at lower right-hand side of the page -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27497 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27497 Michael Adamyk <madamyk@ckls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |madamyk@ckls.org --- Comment #32 from Michael Adamyk <madamyk@ckls.org> --- Created attachment 116781 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116781&action=edit Version displaying in center of page The version is not appearing where expected for me. Instead of appearing in the lower-right corner, it's beneath the middle column (directly beneath "Authorities") -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27497 Michael Adamyk <madamyk@ckls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #34 from Michael Adamyk <madamyk@ckls.org> --- The version did not appear where expected in my sandbox. I'm marking it as "Failed QA" so you can take another look at it. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27497 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #36 from Fridolin Somers <fridolin.somers@biblibre.com> --- @Michael Adamyk Can you run manually 'yarn build' please ? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27497 --- Comment #38 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Michael Adamyk from comment #37)

I'm afraid I don't know enough about Koha to know how to do the SCSS or yard rebuild. Can someone else test and see if it's working for you?

Hi Michael, if you are using the sandboxes, there is a new option to do this from there quite easily: If you look here http://sandboxes.ptfs-europe.co.uk/# you can pick "Build CSS" from the Actions pull down. That will do the trick. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27497 --- Comment #40 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I realize I like the screenshot 1 best still. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27497 koha-US bug tracker <bugzilla@koha-us.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bugzilla@koha-us.org --- Comment #41 from koha-US bug tracker <bugzilla@koha-us.org> --- I agree with Katrin about this looking detached. It’s just floating in thin air and looks really odd in that placement. Screenshot 1 would be my preference too. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27497 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27497 --- Comment #44 from Fridolin Somers <fridolin.somers@biblibre.com> --- Ahhh my mistake, my patch adds to SCSS float: left We want it at right, fixed : float: right I've uploaded fixed patch, so we need signoff again. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27497 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #118956|0 |1 is obsolete| | --- Comment #45 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 119005 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119005&action=edit Bug 27497: Display Koha version in staff interface home page Koha current version is very useful in staff interface. You can find it in 'About' page but home page is the first page you see. Display it in the lower right-hand side of the page, after 'IntranetmainUserblock' content. Note that it is not a vertical floating text, it whould conflict with languages floating bar. Test plan : 1) Apply patch and update staff client CSS : https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff... 2) Look at staff interface home page and look at lower right-hand side of the page Signed-off-by: Michael Adamyk <madamyk@ckls.org> Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27497 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #119006|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27497 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #119005|0 |1 is obsolete| | --- Comment #47 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 119821 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119821&action=edit Bug 27497: Display Koha version in staff interface home page Koha current version is very useful in staff interface. You can find it in 'About' page but home page is the first page you see. Display it in the lower right-hand side of the page, after 'IntranetmainUserblock' content. Note that it is not a vertical floating text, it whould conflict with languages floating bar. Test plan : 1) Apply patch and update staff client CSS : https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff... 2) Look at staff interface home page and look at lower right-hand side of the page Signed-off-by: Michael Adamyk <madamyk@ckls.org> Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27497 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #119821|0 |1 is obsolete| | --- Comment #49 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 119823 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119823&action=edit Bug 27497: Display Koha version in staff interface home page Koha current version is very useful in staff interface. You can find it in 'About' page but home page is the first page you see. Display it in the lower right-hand side of the page, after 'IntranetmainUserblock' content. Note that it is not a vertical floating text, it whould conflict with languages floating bar. Test plan : 1) Apply patch and update staff client CSS : https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff... 2) Look at staff interface home page and look at lower right-hand side of the page Signed-off-by: Michael Adamyk <madamyk@ckls.org> Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27497 --- Comment #51 from David Cook <dcook@prosentient.com.au> --- (In reply to Katrin Fischer from comment #50)

Sorry to say, I still feel like this is not quite where it should be :( (see screenshot)

Agreed

I think my problem is, that I think it should "float" more at the bottom, right above or included in the language chooser if that's visible.

Agreed, although I'd say "fixed" to the bottom. -- Based on the last screenshot, it does not look very good, so I'll probably just hide it on all my installs. I'd say just always have a bottom bar on the staff interface, and incorporate the language choose into that bottom bar. Shouldn't be that hard at a glance. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27497 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |In Discussion --- Comment #52 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Why is it PQA if there is still discussion and the solution does not make everybody happy? :) It is displaying: "Version 20.12.00", when it is actually "20.12.00.034". Why don't we display the exact version? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27497 --- Comment #54 from David Cook <dcook@prosentient.com.au> --- Frido, I like what you said about adding the version as a tooltip over the Koha logo at https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27667#c13 That would be very usable but it wouldn't be ugly or disruptive to staff users. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27497 --- Comment #56 from Owen Leonard <oleonard@myacpl.org> --- I think the patch we have should be accepted. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27497 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27497 --- Comment #59 from Fridolin Somers <fridolin.somers@biblibre.com> --- Cool, thank you all :D -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27497 Michael Adamyk <madamyk@ckls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|madamyk@ckls.org | -- You are receiving this mail because: You are watching all bug changes.