[Bug 28263] New: AUTO_RENEWAL message for 'too_many' is wrong
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28263 Bug ID: 28263 Summary: AUTO_RENEWAL message for 'too_many' is wrong Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Notices Assignee: koha-bugs@lists.koha-community.org Reporter: lucas@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org When the AUTO_RENEWAL message generates the error 'too_many' the standard template displays the message 'You have reached the maximum number of checkouts possible.' This is not correct. It should read: 'You have reached the maximum number of renewals possible.' -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28263 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28263 --- Comment #1 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 120315 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120315&action=edit Bug 28263: Fix too_many auto renewal message To test: 1. Make an item eligible for auto_renewal. 2. Set circ rule so only 1 auto_renewal is allowd. 3. Run auto_renew once, get a successful message. 4. Run it again and get the too_many error "You have reached the maximum number of checkouts possible." 5. This has nothing to do with the number of checkouts 6. Apply patch and updatedatabase. 7. Do 1-4 again. 8. Message is now "You have reached the maximum number of renewals possible." -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28263 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28263 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |lucas@bywatersolutions.com |ity.org | Severity|normal |minor -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28263 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Lucas, with the new additions in 21.05 we also need to fix AUTO_RENEWALS_DGST now. And for new installations we need sample_notices.yml fixed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28263 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28263 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120315|0 |1 is obsolete| | --- Comment #3 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 122495 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122495&action=edit Bug 28263: Fix too_many auto renewal message To test: 1. Make an item eligible for auto_renewal. 2. Set circ rule so only 1 auto_renewal is allowd. 3. Run auto_renew once, get a successful message. 4. Run it again and get the too_many error "You have reached the maximum number of checkouts possible." 5. This has nothing to do with the number of checkouts 6. Apply patch and updatedatabase. 7. Do 1-4 again. 8. Message is now "You have reached the maximum number of renewals possible." -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28263 Hayley Pelham <hayleypelham@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hayleypelham@catalyst.net.n | |z --- Comment #4 from Hayley Pelham <hayleypelham@catalyst.net.nz> --- Hi Lucas, Can you please elaborate on how you can 'run auto_renew'? Cheers, Hayley -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28263 --- Comment #5 from Lucas Gass <lucas@bywatersolutions.com> --- (In reply to Hayley Pelham from comment #4)
Hi Lucas,
Can you please elaborate on how you can 'run auto_renew'?
Cheers, Hayley
Hi Hayley, I'm sorry, that wasn't very clear. What I mean by 'run auto_renew' is to run the automatic renewal script ( /misc/cronjobs/automatic_renewals.pl ). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28263 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28263 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122495|0 |1 is obsolete| | --- Comment #6 from David Nind <david@davidnind.com> --- Created attachment 126787 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=126787&action=edit Bug 28263: Fix too_many auto renewal message To test: 1. Make an item eligible for auto_renewal. 2. Set circ rule so only 1 auto_renewal is allowd. 3. Run auto_renew once, get a successful message. 4. Run it again and get the too_many error "You have reached the maximum number of checkouts possible." 5. This has nothing to do with the number of checkouts 6. Apply patch and updatedatabase. 7. Do 1-4 again. 8. Message is now "You have reached the maximum number of renewals possible." Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28263 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #7 from David Nind <david@davidnind.com> --- My testing notes (koha-testing-docker): 1. Setup so notice generated: . Change AutoRenewalNotices to 'according to patron messaging preferences' . Add an email address for a patron . Tick email for auto renewal under messaging references for the patron 2. Check out an item for the patron - when checking out expand the checkout settings and tick the automatic renewal box, and change the renewal date to before today 3. Run the auto renewal script: misc/cronjobs/automatic_renewals.pl -c -s -v => result (numbers will be different depending on item and patron): getting auto renewals found 1 auto renewals examining item '578' to auto renew Issue id: 3 for borrower: 49 and item: 578 will be renewed. 4. Check patron's notices - automatic renewal notice should say the renewal was successful 5. Run auto renewal script again (step 3) - result will be: getting auto renewals found 1 auto renewals examining item '578' to auto renew Issue id: 3 for borrower: 49 and item: 578 will be renewed.6. 6. Check patron's notices - automatic renewal notice should say not renewed 7. Checked diff and reviewed changes 8. After patch applied, renewal notice (under Tools > Notices & slips) and patron's notices should reflect updated wording -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28263 Joonas Kylmälä <joonas.kylmala@iki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28263 Joonas Kylmälä <joonas.kylmala@iki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #126787|0 |1 is obsolete| | --- Comment #8 from Joonas Kylmälä <joonas.kylmala@iki.fi> --- Created attachment 127108 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127108&action=edit Bug 28263: Fix too_many auto renewal message To test: 1. Make an item eligible for auto_renewal. 2. Set circ rule so only 1 auto_renewal is allowd. 3. Run auto_renew once, get a successful message. 4. Run it again and get the too_many error "You have reached the maximum number of checkouts possible." 5. This has nothing to do with the number of checkouts 6. Apply patch and updatedatabase. 7. Do 1-4 again. 8. Message is now "You have reached the maximum number of renewals possible." Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Joonas Kylmälä <joonas.kylmala@iki.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28263 Joonas Kylmälä <joonas.kylmala@iki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |joonas.kylmala@iki.fi |y.org | CC| |joonas.kylmala@iki.fi -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28263 --- Comment #9 from Joonas Kylmälä <joonas.kylmala@iki.fi> --- Created attachment 127110 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127110&action=edit Bug 28263: (QA follow-up) Use new atomicupdate code style Signed-off-by: Joonas Kylmälä <joonas.kylmala@iki.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28263 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This corrects the text in release notes| |the AUTO_RENEWALS and | |AUTO_RENEWALS_DGST notices. | |These are sent when an item | |is setup for automatic | |renewal and can no longer | |be automatically renewed as | |the maximum number of | |renewals reached: | |- Current | |wording: "You have reached | |the maximum number of | |checkouts possible." | |- | |Updated wording: "You have | |reached the maximum number | |of renewals possible." | | | |For | |new installations the | |sample notices are updated. | |For existing installations | |the notices will be updated | |if they exist and haven't | |been changed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28263 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|AUTO_RENEWAL message for |AUTO_RENEWALS message for |'too_many' is wrong |'too_many' is wrong -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28263 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28263 --- Comment #10 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28263 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org