[Bug 29356] New: Search for pickup library when placing a hold should be truncated in both directions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29356 Bug ID: 29356 Summary: Search for pickup library when placing a hold should be truncated in both directions Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Hold requests Assignee: tomascohen@gmail.com Reporter: andrew@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com When placing a hold, the dropdowns for selecting a pickup library automatically right-truncate, so one can type "cen" and find Centerville. On the Libraries page in Admin, however, the search box both left- and right-truncates, so one can type "en" and find Centerville. The search when placing a hold should truncate as the Libraries search does. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29356 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED --- Comment #1 from Tomás Cohen Arazi <tomascohen@gmail.com> --- The datatables wrapper (which branches.pl uses) is configured to default to the 'contains' behavior. We can do something similar with thise dropdowns. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29356 --- Comment #2 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 127076 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127076&action=edit Bug 29356: Pickup location dropdowns should perform 'contains' searches When placing a hold, the dropdowns for selecting a pickup library automatically right-truncate, so one can type "cen" and find Centerville. On the Libraries page in Admin, however, the search box both left- and right-truncates, so one can type "en" and find Centerville. This patch makes the search perform 'contains' searches. To test: 1. Try placing a hold. Make sure your rules allow Centerville to be a valid pickup location. 2. Search 'cen' => SUCCESS: Centerville shows 3. Search 'en => FAIL: Centerville doesn't show 4. Apply this patch and reload 5. Repeat 2 => SUCCESS: Works! 6. Repeat 3 => SUCCSS: Centerville shows! 7. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29356 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff CC| |tomascohen@gmail.com Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29356 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29355 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29355 [Bug 29355] Pickup location list limited by RESTdefaultPageSize syspref -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29356 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29356 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127076|0 |1 is obsolete| | --- Comment #3 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 127077 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127077&action=edit Bug 29356: Pickup location dropdowns should perform 'contains' searches When placing a hold, the dropdowns for selecting a pickup library automatically right-truncate, so one can type "cen" and find Centerville. On the Libraries page in Admin, however, the search box both left- and right-truncates, so one can type "en" and find Centerville. This patch makes the search perform 'contains' searches. To test: 1. Try placing a hold. Make sure your rules allow Centerville to be a valid pickup location. 2. Search 'cen' => SUCCESS: Centerville shows 3. Search 'en => FAIL: Centerville doesn't show 4. Apply this patch and reload 5. Repeat 2 => SUCCESS: Works! 6. Repeat 3 => SUCCSS: Centerville shows! 7. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29356 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #127077|0 |1 is obsolete| | --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 127188 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=127188&action=edit Bug 29356: Pickup location dropdowns should perform 'contains' searches When placing a hold, the dropdowns for selecting a pickup library automatically right-truncate, so one can type "cen" and find Centerville. On the Libraries page in Admin, however, the search box both left- and right-truncates, so one can type "en" and find Centerville. This patch makes the search perform 'contains' searches. To test: 1. Try placing a hold. Make sure your rules allow Centerville to be a valid pickup location. 2. Search 'cen' => SUCCESS: Centerville shows 3. Search 'en => FAIL: Centerville doesn't show 4. Apply this patch and reload 5. Repeat 2 => SUCCESS: Works! 6. Repeat 3 => SUCCSS: Centerville shows! 7. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29356 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |martin.renvoize@ptfs-europe | |.com --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Must admit, I find this a little weird and prefer 'starts-with'.. but, consistency is good. Works as described, Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29356 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29356 --- Comment #6 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29356 Bug 29356 depends on bug 29355, which changed state. Bug 29355 Summary: Pickup location list limited by RESTdefaultPageSize syspref https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29355 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29356 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Resolution|--- |FIXED Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org