[Bug 16060] New: Add Font Awesome icon to Z39.50 search button when no results are found
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16060 Bug ID: 16060 Summary: Add Font Awesome icon to Z39.50 search button when no results are found Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/catalogue/search.pl OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org If a catalog search in the staff client returns no results a Z39.50/SRU search button is shown. This button could use a Font Awesome icon. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16060 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16060 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 49095 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49095&action=edit Bug 16060 - Add Font Awesome icon to Z39.50 search button when no results are found When a staff client catalog search returns no results, a Z39.50/SRU search button is shown. This patch adds a Font Awesome icon to that button. Also changed: A stray extra double quote has been removed. The onclick attribute has been removed from the search button in favor of an event already defined. To test, apply the patch and perform a search in the staff client catalog which will return no results. - Confirm that the Z39.50/SRU button looks correct and works correctly. - Validate the HTML of the page and confirm that no unexpected errors are returned. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16060 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset@hotmail.com --- Comment #2 from M. Tompsett <mtompset@hotmail.com> --- This is the only validation error I got. This patch didn't cause it. So I'm going to sign off. Warning: Empty heading.
From line 420, column 1; to line 420, column 14 radient">↩<h1 id="logo"><a hre
-- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16060 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16060 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49095|0 |1 is obsolete| | --- Comment #3 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 49366 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49366&action=edit Bug 16060 - Add Font Awesome icon to Z39.50 search button when no results are found When a staff client catalog search returns no results, a Z39.50/SRU search button is shown. This patch adds a Font Awesome icon to that button. Also changed: A stray extra double quote has been removed. The onclick attribute has been removed from the search button in favor of an event already defined. To test, apply the patch and perform a search in the staff client catalog which will return no results. - Confirm that the Z39.50/SRU button looks correct and works correctly. - Validate the HTML of the page and confirm that no unexpected errors are returned. NOTE: Pretty! Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16060 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16060 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49366|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 49381 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49381&action=edit [PASSED QA] Bug 16060 - Add Font Awesome icon to Z39.50 search button when no results are found When a staff client catalog search returns no results, a Z39.50/SRU search button is shown. This patch adds a Font Awesome icon to that button. Also changed: A stray extra double quote has been removed. The onclick attribute has been removed from the search button in favor of an event already defined. To test, apply the patch and perform a search in the staff client catalog which will return no results. - Confirm that the Z39.50/SRU button looks correct and works correctly. - Validate the HTML of the page and confirm that no unexpected errors are returned. NOTE: Pretty! Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16060 --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- (In reply to M. Tompsett from comment #2)
This is the only validation error I got.
Warning: Empty heading.
The heading is empty if you don't have the "LibraryName" system preference populated. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16060 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |brendan@bywatersolutions.co | |m --- Comment #6 from Brendan Gallagher <brendan@bywatersolutions.com> --- Pushed to Master - Should be in the May 2016 release. Thanks! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org