[Bug 16061] New: Use Font Awesome icons in reports when filter returns no results
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16061 Bug ID: 16061 Summary: Use Font Awesome icons in reports when filter returns no results Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/reports/guided_reports.pl OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org In Reports -> Saved reports, if you use the sidebar filter to submit terms for which there are no results a dialog is shown. This dialog should use Font Awesome icons. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16061 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16061 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 49096 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49096&action=edit Bug 16061 - Use Font Awesome icons in reports when filter returns no results In Reports -> Saved reports, when the filter form returns no results a dialog is shown. This patch updates the dialog to use Font Awesome icons. Also changed: The dialog now includes a button for creating a new SQL report, not just one to create a new guided report. The "clear" link in the sidebar has been modified to pass HTML validation. To test, apply the patch and go to Reports -> Saved reports. - In the left-hand sidebar filter, submit terms which will return no results. - Verify that the resulting dialog is correctly styled. - Confirm that all three buttons in the dialog work correctly: New guided report, new SQL report, and Cancel. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16061 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |16062 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16062 [Bug 16062] Remove CSS and images related to old "approve" and "deny" button styles -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16061 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49096|0 |1 is obsolete| | --- Comment #2 from Marc Véron <veron@veron.ch> --- Created attachment 49123 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49123&action=edit Bug 16061 - Use Font Awesome icons in reports when filter returns no results In Reports -> Saved reports, when the filter form returns no results a dialog is shown. This patch updates the dialog to use Font Awesome icons. Also changed: The dialog now includes a button for creating a new SQL report, not just one to create a new guided report. The "clear" link in the sidebar has been modified to pass HTML validation. To test, apply the patch and go to Reports -> Saved reports. - In the left-hand sidebar filter, submit terms which will return no results. - Verify that the resulting dialog is correctly styled. - Confirm that all three buttons in the dialog work correctly: New guided report, new SQL report, and Cancel. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16061 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |veron@veron.ch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16061 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16061 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49123|0 |1 is obsolete| | --- Comment #3 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 49146 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49146&action=edit Bug 16061: Use Font Awesome icons in reports when filter returns no results In Reports -> Saved reports, when the filter form returns no results a dialog is shown. This patch updates the dialog to use Font Awesome icons. Also changed: The dialog now includes a button for creating a new SQL report, not just one to create a new guided report. The "clear" link in the sidebar has been modified to pass HTML validation. To test, apply the patch and go to Reports -> Saved reports. - In the left-hand sidebar filter, submit terms which will return no results. - Verify that the resulting dialog is correctly styled. - Confirm that all three buttons in the dialog work correctly: New guided report, new SQL report, and Cancel. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Tomas Cohen Arazi <tomascohen@unc.edu.ar> I'm passing this one, while I don't like it is hardcoding a URL path, because it will make is easier to spot it when time comes and we make Koha delpoyable in any endpoint. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16061 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan@bywatersolutions.co | |m Status|Passed QA |Pushed to Master --- Comment #4 from Brendan Gallagher <brendan@bywatersolutions.com> --- Pushed to Master - Should be in the May 2016 release. Thanks! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org