[Bug 13957] New: Patron autocomplete shows NULL in list of results
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13957 Bug ID: 13957 Summary: Patron autocomplete shows NULL in list of results Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com When doing a search for a patron from the checkout tab, using the autocomplete feature, the result list shows a 'null' at the end of each result line. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13957 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |13892 Assignee|koha-bugs@lists.koha-commun |jonathan.druart@biblibre.co |ity.org |m CC| |jonathan.druart@biblibre.co | |m Status|NEW |ASSIGNED --- Comment #1 from Jonathan Druart <jonathan.druart@biblibre.com> --- Introduced by bug 13892. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13957 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13957 --- Comment #2 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 37548 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37548&action=edit Bug 13957: If not value, display an empty string instead of "null" Using the autocomplete feature in the patron search, if one value is missing (i.e. country), it will be replaced with 'null'. The default value should be an empty string. Test plan: 0/ Enable the patron autocomplete feature 1/ Create a patron without value for country 2/ Go on the circ home page 3/ Search for this patron. The country should not have been replaced by "null". -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13957 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37548|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 37549 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37549&action=edit Bug 13957: If no value, display an empty string instead of "null" Using the autocomplete feature in the patron search, if one value is missing (i.e. country), it will be replaced with 'null'. The default value should be an empty string. Test plan: 0/ Enable the patron autocomplete feature 1/ Create a patron without value for country 2/ Go on the circ home page 3/ Search for this patron. The country should not have been replaced by "null". -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13957 Nicolas Legrand <nicolas.legrand@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37549|0 |1 is obsolete| | --- Comment #4 from Nicolas Legrand <nicolas.legrand@bulac.fr> --- Created attachment 37566 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37566&action=edit Bug 13957: If no value, display an empty string instead of "null" Using the autocomplete feature in the patron search, if one value is missing (i.e. country), it will be replaced with 'null'. The default value should be an empty string. Test plan: 0/ Enable the patron autocomplete feature 1/ Create a patron without value for country, address, zipcode, city 2/ Go on the circ home page 3/ Search for this patron. The country should not have been replaced by "null". Signed-off-by: Nicolas Legrand <nicolas.legrand@bulac.fr> Current status: Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13957 Nicolas Legrand <nicolas.legrand@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13957 Nicolas Legrand <nicolas.legrand@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37566|0 |1 is obsolete| | --- Comment #5 from Nicolas Legrand <nicolas.legrand@bulac.fr> --- Created attachment 37567 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37567&action=edit Bug 13957: If no value, display an empty string instead of "null" Using the autocomplete feature in the patron search, if one value is missing (i.e. country), it will be replaced with 'null'. The default value should be an empty string. Test plan: 0/ Enable the patron autocomplete feature 1/ Create a patron without value for country, address, zipcode, city 2/ Go on the circ home page 3/ Search for this patron. The country should not have been replaced by "null". Signed-off-by: Nicolas Legrand <nicolas.legrand@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13957 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13957 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37567|0 |1 is obsolete| | --- Comment #6 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 37666 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37666&action=edit [PASSED QA] Bug 13957: If no value, display an empty string instead of "null" Using the autocomplete feature in the patron search, if one value is missing (i.e. country), it will be replaced with 'null'. The default value should be an empty string. Test plan: 0/ Enable the patron autocomplete feature 1/ Create a patron without value for country, address, zipcode, city 2/ Go on the circ home page 3/ Search for this patron. The country should not have been replaced by "null". Signed-off-by: Nicolas Legrand <nicolas.legrand@bulac.fr> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13957 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Status|Passed QA |Pushed to Master --- Comment #7 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13957 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz --- Comment #8 from Chris Cormack <chris@bigballofwax.co.nz> --- Doesn't apply to 3.18.x please rebase if needed -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13957 --- Comment #9 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Chris Cormack from comment #8)
Doesn't apply to 3.18.x please rebase if needed
Not needed, its introduced by bug 13892, which is not in 3.18.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org