[Bug 13069] New: Enable sort by title to ignore articles on circulation and patron detail pages
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13069 Bug ID: 13069 Summary: Enable sort by title to ignore articles on circulation and patron detail pages Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Circulation Assignee: martin.renvoize@ptfs-europe.com Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com With the conversion of the circulation and patron detail checkout summary tables to AJAX recently we lost the ability to sort by title while ignoring articles. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13069 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13069 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13069 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 32183 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32183&action=edit Bug 13069 - Enable sort by title to ignore articles on circulation and patron detail pages With the conversion of the circulation and patron detail checkout summary tables to AJAX recently we lost the ability to sort by title while ignoring articles. This patch corrects the problem by adding the "anti-the" configuration to the relevant column in the DataTables initializtion script. To test, apply the patch and clear your cache if necessary. Check out to a patron who has multiple checkouts, some of which have titles beginning with "a," "an," and "the." Sorting those checkouts by title should ignore articles. Test the patron detail page for that patron as well. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13069 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13069 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32183|0 |1 is obsolete| | --- Comment #2 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 32237 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32237&action=edit Bug 13069 - Enable sort by title to ignore articles on circulation and patron detail pages With the conversion of the circulation and patron detail checkout summary tables to AJAX recently we lost the ability to sort by title while ignoring articles. This patch corrects the problem by adding the "anti-the" configuration to the relevant column in the DataTables initializtion script. To test, apply the patch and clear your cache if necessary. Check out to a patron who has multiple checkouts, some of which have titles beginning with "a," "an," and "the." Sorting those checkouts by title should ignore articles. Test the patron detail page for that patron as well. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13069 --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 32238 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32238&action=edit Bug 13069 - (follow-up) Enable sort by title to ignore articles This should affect the relatives' checkouts table too. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13069 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_3_18_candidate Status|Passed QA |Failed QA CC| |tomascohen@gmail.com --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Guys, can you ammend both patches so they apply? They seem trivial but I need to focus on other patches right now for string freeze. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13069 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Patch doesn't apply --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Wrong option chosen :-P -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13069 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32237|0 |1 is obsolete| | --- Comment #6 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 37395 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37395&action=edit Bug 13069 - Enable sort by title to ignore articles on circulation and patron detail pages With the conversion of the circulation and patron detail checkout summary tables to AJAX recently we lost the ability to sort by title while ignoring articles. This patch corrects the problem by adding the "anti-the" configuration to the relevant column in the DataTables initializtion script. To test, apply the patch and clear your cache if necessary. Check out to a patron who has multiple checkouts, some of which have titles beginning with "a," "an," and "the." Sorting those checkouts by title should ignore articles. Test the patron detail page for that patron as well. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> NOTE: This is the one early in the javascript file. This is the one visible by having multiple checkouts where the title excluding the articles is a different order than titles including the articles. Patrons -> Details (scroll down to check out area, view checkouts and toggle the title sort) Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13069 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32238|0 |1 is obsolete| | --- Comment #7 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 37396 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37396&action=edit Bug 13069 - (follow-up) Enable sort by title to ignore articles This should affect the relatives' checkouts table too. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> NOTE: This is the one later in the javascript file. Checkout tab on the patron details page. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13069 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset@hotmail.com Status|Patch doesn't apply |Signed Off --- Comment #8 from M. Tompsett <mtompset@hotmail.com> --- I'm not sure if this should be back to Passed QA or what, but since I fixed it and signed it off. I'll let someone else figure out what's next. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13069 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13069 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37395|0 |1 is obsolete| | Attachment #37396|0 |1 is obsolete| | --- Comment #9 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 37479 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37479&action=edit [PASSED QA] Bug 13069 - Enable sort by title to ignore articles on circulation and patron detail pages With the conversion of the circulation and patron detail checkout summary tables to AJAX recently we lost the ability to sort by title while ignoring articles. This patch corrects the problem by adding the "anti-the" configuration to the relevant column in the DataTables initializtion script. To test, apply the patch and clear your cache if necessary. Check out to a patron who has multiple checkouts, some of which have titles beginning with "a," "an," and "the." Sorting those checkouts by title should ignore articles. Test the patron detail page for that patron as well. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> NOTE: This is the one early in the javascript file. This is the one visible by having multiple checkouts where the title excluding the articles is a different order than titles including the articles. Patrons -> Details (scroll down to check out area, view checkouts and toggle the title sort) Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13069 --- Comment #10 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 37480 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37480&action=edit [PASSED QA] Bug 13069 - (follow-up) Enable sort by title to ignore articles This should affect the relatives' checkouts table too. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> NOTE: This is the one later in the javascript file. Checkout tab on the patron details page. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13069 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #11 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patches pushed to master. Thanks Martin! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13069 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz Status|Pushed to Master |Pushed to Stable --- Comment #12 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.18.x will be in 3.18.6 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org