[Bug 33284] New: checkout_renewals table retains checkout history in violation of patron privacy
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33284 Bug ID: 33284 Summary: checkout_renewals table retains checkout history in violation of patron privacy Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: andrewfh@dubcolib.org QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Depends on: 30275 The checkout_renewals table introduced in bug 30275 can retain a link between a patron and an issue_id when the patron's privacy is set to Never. That data should be anonymized. To recreate: - have a patron with their privacy set to Never retain reading history - check an item out to the patron, renew it via the OPAC - confirm your patron's borrowernumber can be found in checkout_renewals.renewer_id and the issue_id for your checkout can be found in checkout_renewals.checkout_id - check your item in - confirm your patron's borrowernumber has been removed from old_issues.borrowernumber - confirm your patron's borrowernumber and the issue_id for your checkout can still be found in checkout_renewals.checkout_id (along with a note that the renewal happened via the OPAC, thereby making it perfectly clear that this was a patron renewing the item they had checked out themselves). Should we not replace checkout_renewals.renewer_id with the anonymous patron's borrowernumber when the item is returned, if the patron is set to not retain reading history? Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30275 [Bug 30275] Checkout renewals should be stored in their own table -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33284 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com --- Comment #1 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Oh, darn. Thanks Andrew.. my apologies for missing that when developing this feature. I'm running your proposal past Aude here, whose a lot more up to speed on borrower privacy.. but in short, I think you're right.. just using the anonymous user id should tick the right box. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33284 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |martin.renvoize@ptfs-europe |ity.org |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33284 hebah@bywatersolutions.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hebah@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33284 --- Comment #2 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 148469 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148469&action=edit Bug 33284: Set renewer_id appropriately for anonymize settings This patch adds a trigger into the anonymize function of Koha::Old::Checkout such that we pass along the anonymize action to the renewals record. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33284 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33284 --- Comment #3 from Andrew Fuerste-Henry <andrewfh@dubcolib.org> --- Test plan: 1 - Apply patch 2 - Have 3 patrons covering the 3 privacy options: Default, Forever, Never 3 - Check an item out to each patron 4 - renew each patron's item via the staff interface 5 - renew each patron's item via the OPAC 6 - SELECT * FROM checkout_renewals, confirm all staff interface renewals show your borrowernumber, all OPAC renewals show the patron's borrowernumber 7 - return all items 8 - repeat #6, confirm that the Never patron's OPAC renewal now shows the anonymous borrowernumber but other values have not changed 9 - anonymize all circ data using Batch patron deletion and anonymization 10 - repeat #6, confirm the Default patron's OPAC renewal now shows the anonymous borrowernumber but other values have not changed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33284 --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 148486 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148486&action=edit Bug 33284: Unit test -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33284 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148469|0 |1 is obsolete| | --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 148487 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148487&action=edit Bug 33284: Set renewer_id appropriately for anonymize settings This patch adds a trigger into the anonymize function of Koha::Old::Checkout such that we pass along the anonymize action to the renewals record. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33284 --- Comment #6 from Andrew Fuerste-Henry <andrewfh@dubcolib.org> --- (In reply to Martin Renvoize from comment #1)
Oh, darn. Thanks Andrew.. my apologies for missing that when developing this feature.
I'm running your proposal past Aude here, whose a lot more up to speed on borrower privacy.. but in short, I think you're right.. just using the anonymous user id should tick the right box.
Thanks for the quick fix! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33284 Andrew Fuerste-Henry <andrewfh@dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #7 from Andrew Fuerste-Henry <andrewfh@dubcolib.org> --- (In reply to Andrew Fuerste-Henry from comment #3)
Test plan: 1 - Apply patch 2 - Have 3 patrons covering the 3 privacy options: Default, Forever, Never 3 - Check an item out to each patron 4 - renew each patron's item via the staff interface 5 - renew each patron's item via the OPAC 6 - SELECT * FROM checkout_renewals, confirm all staff interface renewals show your borrowernumber, all OPAC renewals show the patron's borrowernumber 7 - return all items 8 - repeat #6, confirm that the Never patron's OPAC renewal now shows the anonymous borrowernumber but other values have not changed 9 - anonymize all circ data using Batch patron deletion and anonymization 10 - repeat #6, confirm the Default patron's OPAC renewal now shows the anonymous borrowernumber but other values have not changed
This all performs as desired, except for steps 9 and 10, which I hadn't thought about until writing the test plan. Currently this patch anonymizes renewals at checkin for patrons set to Never for privacy. We should also anonymize renewals for patrons set to Default, but as part of the Batch Anonymize tool/cron. I'm failing QA for that reason, but if you want to address that on a separate bug I've got no problem signing off on this one for the Never patron fix. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33284 --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Awesome spot Andrew, I have a fix, just writing the test for it now. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33284 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148486|0 |1 is obsolete| | --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 148670 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148670&action=edit Bug 33284: Unit test -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33284 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148487|0 |1 is obsolete| | --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 148671 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148671&action=edit Bug 33284: Set renewer_id appropriately for anonymize settings This patch adds a trigger into the anonymize function of Koha::Old::Checkout such that we pass along the anonymize action to the renewals record. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33284 --- Comment #11 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 148672 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148672&action=edit Bug 33284: Set renewer_id for sets of checkouts This patch adds a trigger into the anonymize function of Koha::Old::Checkouts such that we pass along the anonymize action to the renewals record. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33284 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33284 Andrew Fuerste-Henry <andrewfh@dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33284 Andrew Fuerste-Henry <andrewfh@dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148670|0 |1 is obsolete| | --- Comment #12 from Andrew Fuerste-Henry <andrewfh@dubcolib.org> --- Created attachment 148772 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148772&action=edit Bug 33284: Unit test Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33284 Andrew Fuerste-Henry <andrewfh@dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148671|0 |1 is obsolete| | --- Comment #13 from Andrew Fuerste-Henry <andrewfh@dubcolib.org> --- Created attachment 148773 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148773&action=edit Bug 33284: Set renewer_id appropriately for anonymize settings This patch adds a trigger into the anonymize function of Koha::Old::Checkout such that we pass along the anonymize action to the renewals record. Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33284 Andrew Fuerste-Henry <andrewfh@dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148672|0 |1 is obsolete| | --- Comment #14 from Andrew Fuerste-Henry <andrewfh@dubcolib.org> --- Created attachment 148774 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148774&action=edit Bug 33284: Set renewer_id for sets of checkouts This patch adds a trigger into the anonymize function of Koha::Old::Checkouts such that we pass along the anonymize action to the renewals record. Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33284 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33284 --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Please remember to add the test plan to the commit messages. I am going to use Andrew's from comment 3. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33284 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #16 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think that the option to immediately "delete circulation history" from the patron account in the OPAC doesn't work correctly yet. I have no more issues, but there is still a renewal entry that has the renewer_id of my user. The immediately deletion should always work, independent of the privacy setting. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33284 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_23_05_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33284 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|katrin.fischer@bsz-bw.de |testopia@bugs.koha-communit | |y.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33284 --- Comment #17 from Andrew Fuerste-Henry <andrewfh@dubcolib.org> --- Hi all, giving this bug a bump as it continues to force us to keep patron circulation history in violation of their privacy selection. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33284 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off CC| |nick@bywatersolutions.com --- Comment #18 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Katrin Fischer from comment #16)
I think that the option to immediately "delete circulation history" from the patron account in the OPAC doesn't work correctly yet. I have no more issues, but there is still a renewal entry that has the renewer_id of my user.
The immediately deletion should always work, independent of the privacy setting.
This works in my testing - the renewal from the opac is cleared - the renewal from the staff remains, I used a different patron on staff and opac side. When I used the same patron, both renewals were anonymized - again, this makes sense. In this case, the original renewal with the staff patron for the other account remained, and I htink this is correct too - the patron gets anonymized - other staff don't -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33284 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #19 from Nick Clemens <nick@bywatersolutions.com> --- The tests here randomly fail - using builder to create the renewals seems to sometimes create a related checkotu object, and sometimes a related old checkotu object - I think you need to generate the correct data using AddIssue/AddRenew/MarkIssueReturned -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33284 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wizzyrea@gmail.com --- Comment #20 from Liz Rea <wizzyrea@gmail.com> --- Hi, This kitten seems lost, and people are still wanting this functionality. Is there any chance it can get another look? Cheers, Liz -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33284 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P1 - high -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33284 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148772|0 |1 is obsolete| | --- Comment #21 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 168596 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168596&action=edit Bug 33284: Unit test This patch adds unit tests to ensure renewals properly respect the patron privacy settings. Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33284 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148773|0 |1 is obsolete| | --- Comment #22 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 168597 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168597&action=edit Bug 33284: Set renewer_id appropriately for anonymize settings This patch adds a trigger into the anonymize function of Koha::Old::Checkout such that we pass along the anonymize action to the renewals record. Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33284 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #148774|0 |1 is obsolete| | --- Comment #23 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 168598 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168598&action=edit Bug 33284: Set renewer_id for sets of checkouts This patch adds a trigger into the anonymize function of Koha::Old::Checkouts such that we pass along the anonymize action to the renewals record. Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33284 --- Comment #24 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 168599 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168599&action=edit Bug 33284: (follow-up) Fix unit tests We have a case here where we have checkout_id pointing at issues and old_issues tables. We need to trick TestBuilder to NOT automagically build our related checkout.. This patch passes 'undef' to the foreign key field and then sets it after the fact to the related Old::Checkouts objects we've already built above. This patch should prevent the random failures we were seeing before -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33284 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33284 --- Comment #25 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Rebased and added a follow-up to address Nicks QA concerns. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33284 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |nick@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33284 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #26 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Still getting random failures: # Subtest: anonymize() tests 1..9 ok 1 - Patron has no old checkouts Value not allowed for auto_incr issue_id in Issue at /kohadevbox/koha/t/lib/TestBuilder.pm line 402. Value not allowed for auto_incr issue_id in Issue at /kohadevbox/koha/t/lib/TestBuilder.pm line 402. ok 2 - Patron has 2 completed checkouts ok 3 - Exception thrown because AnonymousPatron not set ok 4 - syspref parameter is correctly passed ok 5 - No changes, patron has 2 linked completed checkouts ok 6 - Checkout to anonymize still linked to patron not ok 7 - Checkout 2 has 2 renewals # Failed test 'Checkout 2 has 2 renewals' # at /kohadevbox/koha/t/db_dependent/Koha/Old/Checkout.t line 87. # got: '0' # expected: '2' ok 8 - Anonymized checkout linked to anonymouspatron not ok 9 - OPAC renewal was anonymized # Failed test 'OPAC renewal was anonymized' # at /kohadevbox/koha/t/db_dependent/Koha/Old/Checkout.t line 98. # got: '0' # expected: '1' # Looks like you failed 2 tests of 9. not ok 1 - anonymize() tests # Failed test 'anonymize() tests' # at /kohadevbox/koha/t/db_dependent/Koha/Old/Checkout.t line 107. # Subtest: deleteitem() tests 1..1 ok 1 - Item is deleted ok 2 - deleteitem() tests # Looks like you failed 1 test of 2. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/2 subtests Test Summary Report ------------------- /kohadevbox/koha/t/db_dependent/Koha/Old/Checkout.t (Wstat: 256 (exited 1) Tests: 2 Failed: 1) Failed test: 1 Non-zero exit status: 1 Files=1, Tests=2, 3 wallclock secs ( 0.02 usr 0.00 sys + 2.77 cusr 0.44 csys = 3.23 CPU) Result: FAIL -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33284 --- Comment #27 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Hmm, I can't get the test to fail.. I just ran it 100 times in a loop and it passed every time. 😞 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33284 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #168596|0 |1 is obsolete| | --- Comment #28 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 178949 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178949&action=edit Bug 33284: Unit test This patch adds unit tests to ensure renewals properly respect the patron privacy settings. Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33284 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #168597|0 |1 is obsolete| | --- Comment #29 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 178950 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178950&action=edit Bug 33284: Set renewer_id appropriately for anonymize settings This patch adds a trigger into the anonymize function of Koha::Old::Checkout such that we pass along the anonymize action to the renewals record. Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33284 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #168598|0 |1 is obsolete| | --- Comment #30 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 178951 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178951&action=edit Bug 33284: Set renewer_id for sets of checkouts This patch adds a trigger into the anonymize function of Koha::Old::Checkouts such that we pass along the anonymize action to the renewals record. Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33284 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #168599|0 |1 is obsolete| | --- Comment #31 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 178952 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178952&action=edit Bug 33284: (follow-up) Fix unit tests We have a case here where we have checkout_id pointing at issues and old_issues tables. We need to trick TestBuilder to NOT automagically build our related checkout.. This patch passes 'undef' to the foreign key field and then sets it after the fact to the related Old::Checkouts objects we've already built above. This patch should prevent the random failures we were seeing before -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33284 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33284 --- Comment #32 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- This should be good to go now.. I can't replicate any failures since updating the follow-up to catch a final case. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33284 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33284 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178949|0 |1 is obsolete| | --- Comment #33 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 179043 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179043&action=edit Bug 33284: Unit test This patch adds unit tests to ensure renewals properly respect the patron privacy settings. Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33284 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178950|0 |1 is obsolete| | --- Comment #34 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 179044 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179044&action=edit Bug 33284: Set renewer_id appropriately for anonymize settings This patch adds a trigger into the anonymize function of Koha::Old::Checkout such that we pass along the anonymize action to the renewals record. Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33284 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178951|0 |1 is obsolete| | --- Comment #35 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 179045 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179045&action=edit Bug 33284: Set renewer_id for sets of checkouts This patch adds a trigger into the anonymize function of Koha::Old::Checkouts such that we pass along the anonymize action to the renewals record. Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33284 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178952|0 |1 is obsolete| | --- Comment #36 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 179046 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179046&action=edit Bug 33284: (follow-up) Fix unit tests We have a case here where we have checkout_id pointing at issues and old_issues tables. We need to trick TestBuilder to NOT automagically build our related checkout.. This patch passes 'undef' to the foreign key field and then sets it after the fact to the related Old::Checkouts objects we've already built above. This patch should prevent the random failures we were seeing before Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33284 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|nick@bywatersolutions.com |m.de.rooy@rijksmuseum.nl Keywords|rel_23_05_candidate | CC| |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33284 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed --- Comment #37 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Since this involved deleting data - can we have a quick note in the release notes please? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33284 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |25.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33284 --- Comment #38 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33284 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed | Text to go in the| |With the introduction of release notes| |more fine-grained renewals | |tracking in "Checkout | |renewals should be stored | |in their own table", we | |inadvertently missed | |applying patron | |anonymization preferences. | | | |This bug corrects that by | |adding logic to ensure we | |follow a patrons preference | |for removing this data. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33284 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|25.05.00 |25.05.00,24.11.08 released in| | Status|Pushed to main |Pushed to stable CC| |fridolin.somers@biblibre.co | |m --- Comment #39 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 24.11.x for 24.11.08 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33284 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting --- Comment #40 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11.x as it wasn't backported to 24.05.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org