[Bug 39572] New: Create EDIFACT order button no longer gives librarians chance to review
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39572 Bug ID: 39572 Summary: Create EDIFACT order button no longer gives librarians chance to review Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: kyle@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org Previously, the Create EDIFACT order button would take librarians to a page to select the correct EDI Library EAN. Now those EANs are listed on the button when clicked. The problem is this removes the chance to review the selection. There is no chance to review the selected EAN to confirm is was chosen correctly. In addition, some libraries have dozens of Library EANs making the button pulldown cumbersome to use. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39572 SamSowanick <sam.sowanick@corvallisoregon.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sam.sowanick@corvallisorego | |n.gov --- Comment #1 from SamSowanick <sam.sowanick@corvallisoregon.gov> --- +1, Our acquisitions person would greatly appreciate having the secondary confirmation screen when selecting EAN account. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39572 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@openfifth.c | |o.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39572 Jeremy Evans <jeremy.evans@ukhsa.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jeremy.evans@ukhsa.gov.uk --- Comment #2 from Jeremy Evans <jeremy.evans@ukhsa.gov.uk> --- Ideally it should show by default the supplier who sent the original EDI quote for that basket into Koha. That would reduce the possibility of user error of sending the confirmed order to the wrong supplier. At the moment it shows the first supplier sorted alphabetically by default. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39572 --- Comment #3 from SamSowanick <sam.sowanick@corvallisoregon.gov> --- Limiting to the vendor sounds like a good idea. Even still, we have several accounts per vendor and accidently sending via the wrong account is still not ideal. Could it also be possible to have the best of both worlds, by splitting the button? One that takes you to a separate page as it was before, and the arrow-dropdown portion of the button provides the accounts as it is now. Like the "Export as CSV" button to its left. Maybe that is needlessly complicated; just a thought. -- Another possibility could be a popup confirmation with the opportunity to cancel the selection, without going to a new page. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39572 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |emily.lamancusa@montgomeryc | |ountymd.gov Assignee|koha-bugs@lists.koha-commun |emily.lamancusa@montgomeryc |ity.org |ountymd.gov -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39572 --- Comment #4 from Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> --- Created attachment 183501 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183501&action=edit Bug 39572: Improve EDIFACT order confirmation message Add EAN account information to EDIFACT order confirmation message To test: 1. Set EDIFACT system preference to Enable 2. Create at least 2 EANs, one with a description and one without a description i. Go to Acquisitions > Library EANs ii. Click "New EAN" and fill in the fields 3. Create an EDI account i. Go to Acquisitions > EDI accounts ii. Click "New account" iii. Click Submit (for testing purposes you don't need to fill in the fields) 4. Find or create a basket for the same vendor that's on the EDI account 5. Add an order to the basket from any source 6. In the menu bar at the top of the basket screen, click "Create EDIFACT order" and select an EAN --> Note that the confirmation page doesn't tell you which EAN was selected 7. Click "No, don't close" 8. Apply patch and restart_all 9. Repeat step 6 --> The confirmation page should now display both the basket and the selected EAN 10. Click "Cancel" --> Confirm that the basket is still open 11. Repeat step 6 12. Click "Yes, generate order and close basket" --> Confirm the basket is closed 13. Click "EDIFACT messages" in the sidebar menu --> Confirm that you see a message with type ORDERS for that basket -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39572 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39572 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39572 --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Emily Lamancusa (emlam) from comment #4)
6. In the menu bar at the top of the basket screen, click "Create EDIFACT order" and select an EAN --> Note that the confirmation page doesn't tell you which EAN was selected 7. Click "No, don't close"
I don't see a confirmation page when trying to reproduce this bug. Am I missing a setting somewhere? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39572 --- Comment #6 from Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> --- (In reply to Owen Leonard from comment #5)
(In reply to Emily Lamancusa (emlam) from comment #4)
6. In the menu bar at the top of the basket screen, click "Create EDIFACT order" and select an EAN --> Note that the confirmation page doesn't tell you which EAN was selected 7. Click "No, don't close"
I don't see a confirmation page when trying to reproduce this bug. Am I missing a setting somewhere?
I think there might not be a confirmation page if you only have one EAN created? (I didn't specifically test with only one EAN, so I'm not 100% sure) Could that be it? If not, I'll try starting over with a fresh KTD and see if I changed something that I forgot to include in the test plan. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39572 --- Comment #7 from Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> --- P.S. Thank you for testing! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39572 --- Comment #8 from Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> --- Aha! It's probably the BasketConfirmations system preference - it needs to be set to "always ask for confirmation". -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39572 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39572 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183501|0 |1 is obsolete| | --- Comment #9 from David Nind <david@davidnind.com> --- Created attachment 183632 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183632&action=edit Bug 39572: Improve EDIFACT order confirmation message Add EAN account information to EDIFACT order confirmation message To test: 1. Set EDIFACT system preference to Enable 2. Create at least 2 EANs, one with a description and one without a description i. Go to Acquisitions > Library EANs ii. Click "New EAN" and fill in the fields 3. Create an EDI account i. Go to Acquisitions > EDI accounts ii. Click "New account" iii. Click Submit (for testing purposes you don't need to fill in the fields) 4. Find or create a basket for the same vendor that's on the EDI account 5. Add an order to the basket from any source 6. In the menu bar at the top of the basket screen, click "Create EDIFACT order" and select an EAN --> Note that the confirmation page doesn't tell you which EAN was selected 7. Click "No, don't close" 8. Apply patch and restart_all 9. Repeat step 6 --> The confirmation page should now display both the basket and the selected EAN 10. Click "Cancel" --> Confirm that the basket is still open 11. Repeat step 6 12. Click "Yes, generate order and close basket" --> Confirm the basket is closed 13. Click "EDIFACT messages" in the sidebar menu --> Confirm that you see a message with type ORDERS for that basket Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39572 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes the EDIFACT release notes| |order confirmation message | |for a basket so that the | |EAN information is now | |included on the | |confirmation page ([a | |basket for a vendor] > | |Create EDIFACT order > | |[select EAN from dropdown | |list], with the | |BasketConfirmations system | |preference set to 'always | |ask for conformation'). | | | |Previously, the `Create | |EDIFACT order` action would | |take librarians to a page | |to select the EDI Library | |EAN. Now, the EANs are | |included in a dropdown list | |for the action. This | |removed the chance to | |review the selected EAN to | |confirm it was correct. In | |addition, some libraries | |have dozens of Library | |EANs, making the button | |dropdown list cumbersome to | |use. CC| |david@davidnind.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39572 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|Trivial patch |String patch CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39572 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |kyle@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39572 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183632|0 |1 is obsolete| | --- Comment #10 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- Created attachment 183675 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183675&action=edit Bug 39572: Improve EDIFACT order confirmation message Add EAN account information to EDIFACT order confirmation message To test: 1. Set EDIFACT system preference to Enable 2. Create at least 2 EANs, one with a description and one without a description i. Go to Acquisitions > Library EANs ii. Click "New EAN" and fill in the fields 3. Create an EDI account i. Go to Acquisitions > EDI accounts ii. Click "New account" iii. Click Submit (for testing purposes you don't need to fill in the fields) 4. Find or create a basket for the same vendor that's on the EDI account 5. Add an order to the basket from any source 6. In the menu bar at the top of the basket screen, click "Create EDIFACT order" and select an EAN --> Note that the confirmation page doesn't tell you which EAN was selected 7. Click "No, don't close" 8. Apply patch and restart_all 9. Repeat step 6 --> The confirmation page should now display both the basket and the selected EAN 10. Click "Cancel" --> Confirm that the basket is still open 11. Repeat step 6 12. Click "Yes, generate order and close basket" --> Confirm the basket is closed 13. Click "EDIFACT messages" in the sidebar menu --> Confirm that you see a message with type ORDERS for that basket Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39572 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |37993 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37993 [Bug 37993] Having a single EDI EAN account produces a bad redirect -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39572 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Create EDIFACT order button |Create EDIFACT order button |no longer gives librarians |no longer forces librarians |chance to review |to review EAN to select -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39572 --- Comment #11 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- (In reply to Jeremy Evans from comment #2)
Ideally it should show by default the supplier who sent the original EDI quote for that basket into Koha. That would reduce the possibility of user error of sending the confirmed order to the wrong supplier. At the moment it shows the first supplier sorted alphabetically by default.
I think you're a little confused here Jeremy. The EAN you're selecting here is actually the 'from' library EAN.. not the 'to' Vendor SAN. We should perhaps understand your problem better and address it in another bug if that's OK.. I think this bug is an improvement as it stands using the basketconfirm functionality that already existed and adding a little more detail to it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39572 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183675|0 |1 is obsolete| | --- Comment #12 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 183873 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183873&action=edit Bug 39572: Improve EDIFACT order confirmation message Add EAN account information to EDIFACT order confirmation message when the BasketConfirmations system preference is enabled. To test: 1. Set EDIFACT system preference to Enable 2. Set BasketConfirmations system preference to Enable 3. Create at least 2 EANs, one with a description and one without a description i. Go to Acquisitions > Library EANs ii. Click "New EAN" and fill in the fields 4. Create an EDI account i. Go to Acquisitions > EDI accounts ii. Click "New account" iii. Click Submit (for testing purposes you don't need to fill in the fields) 5. Find or create a basket for the same vendor that's on the EDI account 6. Add an order to the basket from any source 7. In the menu bar at the top of the basket screen, click "Create EDIFACT order" and select an EAN --> Note that the confirmation page doesn't tell you which EAN was selected 8. Click "No, don't close" 9. Apply patch and restart_all 10. Repeat step 7 --> The confirmation page should now display both the basket and the selected EAN 11. Click "Cancel" --> Confirm that the basket is still open 12. Repeat step 7 13. Click "Yes, generate order and close basket" --> Confirm the basket is closed 14. Click "EDIFACT messages" in the sidebar menu --> Confirm that you see a message with type ORDERS for that basket Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39572 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39572 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |25.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39572 --- Comment #13 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 25.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39572 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|25.11.00 |25.11.00,25.05.02 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39572 --- Comment #14 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Nice work everyone! Pushed to 25.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39572 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to stable |Pushed to oldstable Version(s)|25.11.00,25.05.02 |25.11.00,25.05.02,24.11.08 released in| | --- Comment #15 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 24.11.x for 24.11.08 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39572 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |40587 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40587 [Bug 40587] Prevent selection of different EAN's on EDI ORDER when the Basket is generated from a QUOTE message -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39572 Bug 39572 depends on bug 37993, which changed state. Bug 37993 Summary: Having a single EDI EAN account produces a bad redirect https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37993 What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |Needs documenting Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39572 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |Needs documenting --- Comment #16 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11.x as it wasn't backported to 24.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39572 Bug 39572 depends on bug 37993, which changed state. Bug 37993 Summary: Having a single EDI EAN account produces a bad redirect https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37993 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org