[Bug 19600] New: Move admin templates JavaScript to the footer: Other catalog pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19600 Bug ID: 19600 Summary: Move admin templates JavaScript to the footer: Other catalog pages Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: jonathan.druart@bugs.koha-community.org, nick@bywatersolutions.com, simon.pouchol@biblibre.com, testopia@bugs.koha-community.org Depends on: 19594 Blocks: 17858 In order to conform to best practices for performance staff client template javascript should be in the footer instead of the header. This patch will do so for the other catalog-related administration templates not covered in Bug 19594. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858 [Bug 17858] Omnibus: Move staff client JavaScript to the footer https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19594 [Bug 19594] Move admin templates JavaScript to the footer: MARC-related -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19600 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19600 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 69051 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69051&action=edit Bug 19600: Move admin templates JavaScript to the footer: Other catalog pages This patch modifies the staff client catalog-related administration templates so that JavaScript is included in the footer instead of the header. To test, apply the patch and test the JavaScript-driven features of the cart: All button controls, DataTables functionality, tabs, etc. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19600 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69051|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 69053 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69053&action=edit Bug 19600: Move admin templates JavaScript to the footer: Other catalog pages This patch modifies the staff client catalog-related administration templates so that JavaScript is included in the footer instead of the header. To test, apply the patch and test the JavaScript-driven features of each modified template: All button controls, DataTables functionality, tabs, etc. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19600 Simon Pouchol <simon.pouchol@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69053|0 |1 is obsolete| | --- Comment #3 from Simon Pouchol <simon.pouchol@biblibre.com> --- Created attachment 69068 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69068&action=edit Bug 19600: Move admin templates JavaScript to the footer: Other catalog pages This patch modifies the staff client catalog-related administration templates so that JavaScript is included in the footer instead of the header. To test, apply the patch and test the JavaScript-driven features of each modified template: All button controls, DataTables functionality, tabs, etc. Signed-off-by: Simon Pouchol <simon.pouchol@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19600 Simon Pouchol <simon.pouchol@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19600 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19600 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69068|0 |1 is obsolete| | --- Comment #4 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 69497 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69497&action=edit Bug 19600: Move admin templates JavaScript to the footer: Other catalog pages This patch modifies the staff client catalog-related administration templates so that JavaScript is included in the footer instead of the header. To test, apply the patch and test the JavaScript-driven features of each modified template: All button controls, DataTables functionality, tabs, etc. Signed-off-by: Simon Pouchol <simon.pouchol@biblibre.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19600 --- Comment #5 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 69498 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69498&action=edit Bug 19600: (QA followup) Apply css to menu item for item_search_field page Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19600 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec@gmail.com QA Contact|testopia@bugs.koha-communit |josef.moravec@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19600 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19600 Bug 19600 depends on bug 19594, which changed state. Bug 19594 Summary: Move admin templates JavaScript to the footer: MARC-related https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19594 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19600 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED --- Comment #7 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Skipping for 17.11, enhancement -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org