[Bug 19647] New: Move patron lists templates JS to the footer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19647 Bug ID: 19647 Summary: Move patron lists templates JS to the footer Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: testopia@bugs.koha-community.org Blocks: 17858 In order to conform to best practices for performance, staff client template JavaScript should be in the footer instead of the header. This patch will do so for the patron lists templates. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858 [Bug 17858] Omnibus: Move staff client JavaScript to the footer -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19647 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19647 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 69202 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69202&action=edit Bug 19647: Move patron lists templates JS to the footer This patch modifies the staff client patron lists templates so that JavaScript is included in the footer instead of the header. This patch adds a new JS file, tools-menu.js, which will be added to each template which has the Tools sidebar menu. Highlighting of the current page in the sidebar menu will be broken for pages which have not been modified to use this file. To test, apply the patch and test the JavaScript-driven features of each modified template: All button controls, DataTables functionality, form validation, etc. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19647 Dominic Pichette <dominic.pichette@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dominic.pichette@inlibro.co | |m --- Comment #2 from Dominic Pichette <dominic.pichette@inlibro.com> --- Looks good to me! I'm having trouble signing it off though: Failed to attach patch to bug 19647, status=200 Maybe if someone else could attach it... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19647 Dominic Pichette <dominic.pichette@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69202|0 |1 is obsolete| | --- Comment #3 from Dominic Pichette <dominic.pichette@inlibro.com> --- Created attachment 69211 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69211&action=edit Bug 19647: Move patron lists templates JS to the footer This patch modifies the staff client patron lists templates so that JavaScript is included in the footer instead of the header. This patch adds a new JS file, tools-menu.js, which will be added to each template which has the Tools sidebar menu. Highlighting of the current page in the sidebar menu will be broken for pages which have not been modified to use this file. To test, apply the patch and test the JavaScript-driven features of each modified template: All button controls, DataTables functionality, form validation, etc. resolved the issue, sorry about that, everything is working fine!Signed-off-by: Dominic Pichette <dominic@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19647 Dominic Pichette <dominic.pichette@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19647 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |19653 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19653 [Bug 19653] Move tools templates JavaScript to the footer: Additional tools -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19647 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |19654 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19654 [Bug 19654] Move tools templates JavaScript to the footer: Batch MARC tools -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19647 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |19672 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19672 [Bug 19672] Move tools templates JavaScript to the footer: More MARC tools -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19647 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |19679 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19679 [Bug 19679] Move tools templates JavaScript to the footer: More MARC tools -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19647 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |19680 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19680 [Bug 19680] Move JS to the footer: Patron and circulation tools -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19647 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |19682 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19682 [Bug 19682] Move JS to the footer: Two patron-related tools -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19647 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |19709 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19709 [Bug 19709] Move template JavaScript to the footer: Labels -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19647 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |19710 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19710 [Bug 19710] Move plugins templates to the footer -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19647 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |19656 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19656 [Bug 19656] Move rotating collections templates JS to the footer -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19647 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19647 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69211|0 |1 is obsolete| | --- Comment #4 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 69556 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69556&action=edit Bug 19647: Move patron lists templates JS to the footer This patch modifies the staff client patron lists templates so that JavaScript is included in the footer instead of the header. This patch adds a new JS file, tools-menu.js, which will be added to each template which has the Tools sidebar menu. Highlighting of the current page in the sidebar menu will be broken for pages which have not been modified to use this file. To test, apply the patch and test the JavaScript-driven features of each modified template: All button controls, DataTables functionality, form validation, etc. resolved the issue, sorry about that, everything is working fine!Signed-off-by: Dominic Pichette <dominic@inlibro.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19647 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |josef.moravec@gmail.com |y.org | CC| |josef.moravec@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19647 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |19627 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19627 [Bug 19627] Move patron clubs templates JS to the footer -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19647 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19647 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED CC| |nick@bywatersolutions.com Resolution|--- |FIXED --- Comment #6 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Skipping for 17.11, enhancement -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org