[Bug 15573] New: String and translatability fix to Patron Card Creator
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15573 Bug ID: 15573 Summary: String and translatability fix to Patron Card Creator Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: gmcharlt@gmail.com Reporter: aleishaamohia@hotmail.com QA Contact: testopia@bugs.koha-community.org Most of the changes from 'Item' to 'Patron' were fixed, but there is one case where it still says 'Item Count' and a case for a translatability fix. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15573 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15573 --- Comment #1 from Aleisha Amohia <aleishaamohia@hotmail.com> --- Created attachment 46624 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46624&action=edit Bug 15573: String and translatability fix to Patron Card Creator To test: 1) Go to Tools -> Patron Card Creator -> Manage -> Card batches 2) Confirm the table heading reads 'Patron Count' 3) Edit a batch 4) Click Remove duplicates 5) Confirm it reads 'Duplicates removed from batch number X: Y patron(s)' -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15573 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15573 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46624|0 |1 is obsolete| | --- Comment #2 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- Created attachment 46638 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46638&action=edit [SIGNED-OFF]Bug 15573: String and translatability fix to Patron Card Creator To test: 1) Go to Tools -> Patron Card Creator -> Manage -> Card batches 2) Confirm the table heading reads 'Patron Count' 3) Edit a batch 4) Click Remove duplicates 5) Confirm it reads 'Duplicates removed from batch number X: Y patron(s)' Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as described. Rewording Ok for translatability purpose -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15573 --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Comment on attachment 46638 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46638 [SIGNED-OFF]Bug 15573: String and translatability fix to Patron Card Creator Review of attachment 46638: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=15573&attachment=46638) ----------------------------------------------------------------- ::: koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/edit-batch.tt @@ +179,4 @@
[% IF ( duplicate_message ) %] <div class="dialog message"> + <strong>Duplicates removed from batch number [% batch_id %]:</strong> [% duplicate_count %] patron(s)
To avoid the string to be split, maybe could we put the entire string in the same tag? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15573 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |aleishaamohia@hotmail.com CC| |jonathan.druart@bugs.koha-c | |ommunity.org, | |veron@veron.ch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15573 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15573 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46638|0 |1 is obsolete| | --- Comment #4 from Aleisha Amohia <aleishaamohia@hotmail.com> --- Created attachment 46671 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46671&action=edit Bug 15573: String and translatability fix to Patron Card Creator Fixing the split string To test: 1) Go to Tools -> Patron Card Creator -> Manage -> Card batches 2) Confirm the table heading reads 'Patron Count' 3) Edit a batch 4) Click Remove duplicates 5) Confirm it reads 'Duplicates removed from batch number X: Y patron(s)' -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15573 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15573 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46671|0 |1 is obsolete| | --- Comment #5 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- Created attachment 46678 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46678&action=edit [SIGNED-OFF]Bug 15573: String and translatability fix to Patron Card Creator Fixing the split string To test: 1) Go to Tools -> Patron Card Creator -> Manage -> Card batches 2) Confirm the table heading reads 'Patron Count' 3) Edit a batch 4) Click Remove duplicates 5) Confirm it reads 'Duplicates removed from batch number X: Y patron(s)' Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as described. Rewording Ok for translatability purpose -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15573 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hector.hecaxmmx@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15573 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15573 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46678|0 |1 is obsolete| | --- Comment #6 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 46703 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46703&action=edit Bug 15573: String and translatability fix to Patron Card Creator Fixing the split string To test: 1) Go to Tools -> Patron Card Creator -> Manage -> Card batches 2) Confirm the table heading reads 'Patron Count' 3) Edit a batch 4) Click Remove duplicates 5) Confirm it reads 'Duplicates removed from batch number X: Y patron(s)' Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as described. Rewording Ok for translatability purpose Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15573 --- Comment #7 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 46704 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46704&action=edit Bug 15573 [QA Followup] - Tweak wording Based on JS4 of the coding guidelines, it seems improper embed the count in the middle of this string. I think this working may be more correct. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org