http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15274 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14459 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15274 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleishaamohia@hotmail.com --- Comment #1 from Aleisha Amohia <aleishaamohia@hotmail.com> --- I suppose we can either take the tags out completely or put the entire string within the tags. I can write a patch for both options -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15274 --- Comment #2 from Aleisha Amohia <aleishaamohia@hotmail.com> --- Created attachment 46672 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46672&action=edit Bug 15274: Removing <span> tags from circulation.tt which split the sentence I have only removed the <span class="circ-hlt"> </span> tags from strings where the tags split the sentence. To test: 1) Go to a borrower's check out page (circulation.pl) 2) Check out a book and specify the due date to a past date (ie, to 2015 etc) 3) Confirm the "ITEMS OVERDUE" in the error message is no longer styled by the span tags. 4) Create a manual invoice of $100 for the borrower 5) Confirm the "BLOCKED" and "OVER THE LIMIT" is no longer styled by span tags. 6) Check the patch and the circulation.tt file and confirm that I haven't missed any tags that split the string and make translation difficult. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15274 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46673|Bug 15274: Putting <span> |[Alternative Patch] Bug description|tags around entire string |15274: Putting <span> tags |where the originally split |around entire string where |the sentence |the originally split the | |sentence Attachment #46673|Bug-15274-Putting-span-tags |[ALTERNATIVE-PATCH]Bug-1527 filename|-around-entire-string-w.pat |4-Putting-span-tags-around- |ch |entire-string-w.patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15274 --- Comment #5 from Marc Véron <veron@veron.ch> --- Created attachment 46681 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46681&action=edit Bug 15274: Putting <span> tags around entire string where the originally split the sentence I have only done this where the tags split the sentence. To test: 1) Go to a borrower's check out page (circulation.pl) 2) Check out a book and specify the due date to a past date (ie, to 2015 etc) 3) Confirm the entire sentence in the error message is styled by the span tags. 4) Create a manual invoice of $100 for the borrower 5) Confirm the entire sentence in the error message styled by span tags. 6) Check the patch and the circulation.tt file and confirm that I haven't missed any tags that split the string and make translation difficult. I personally do not prefer this patch because the red bold sentences don't look very good and aren't highly readable. Signed off on this second patch, see screenshots in comment #4. (Forbidden tab char in line 779 removed) Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15274 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46672|0 |1 is obsolete| | --- Comment #6 from Marc Véron <veron@veron.ch> --- Created attachment 46682 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46682&action=edit Bug 15274: Removing <span> tags from circulation.tt which split the sentence I have only removed the <span class="circ-hlt"> </span> tags from strings where the tags split the sentence. To test: 1) Go to a borrower's check out page (circulation.pl) 2) Check out a book and specify the due date to a past date (ie, to 2015 etc) 3) Confirm the "ITEMS OVERDUE" in the error message is no longer styled by the span tags. 4) Create a manual invoice of $100 for the borrower 5) Confirm the "BLOCKED" and "OVER THE LIMIT" is no longer styled by span tags. 6) Check the patch and the circulation.tt file and confirm that I haven't missed any tags that split the string and make translation difficult. Sign-off on first patch (offending tab char in line 779 removed) Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15274 --- Comment #8 from Aleisha Amohia <aleishaamohia@hotmail.com> --- (In reply to Marc Véron from comment #7)

Hi Aleisha, I signed off on both patches, I propose that you decide and obsolete one of them. :-)

Happy to go with what you think is best! Will obselete the first patch :) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15274 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.