[Bug 9635] New: Replace YUI buttons on label batches pages with Bootstrap
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9635 Bug ID: 9635 Summary: Replace YUI buttons on label batches pages with Bootstrap Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/labels/label-edit-batch.pl?op=edit&e lement_id=X OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org The toolbar buttons on the label batch pages are generated using YUI. They should use Bootstrap instead. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9635 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9635 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 15396 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15396&action=edit Bug 9635 - Replace YUI buttons on label batches pages with Bootstrap This patch converts the toolbar used by label batches pages to Bootstrap, replacing YUI button and menu code with Bootstrap markup. This patch also consolidates the include file and main template. The include file was used in only one template. To test, create a label batch and test all functions related to that batch: adding and removing items, de-duplicating the batch, exporting individual items, exporting the batch, and deleting the batch. Buttons should look correct and work correctly. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9635 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15396|0 |1 is obsolete| | --- Comment #2 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 15403 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15403&action=edit [SIGNED-OFF] Bug 9635 - Replace YUI buttons on label batches pages with Bootstrap This patch converts the toolbar used by label batches pages to Bootstrap, replacing YUI button and menu code with Bootstrap markup. This patch also consolidates the include file and main template. The include file was used in only one template. To test, create a label batch and test all functions related to that batch: adding and removing items, de-duplicating the batch, exporting individual items, exporting the batch, and deleting the batch. Buttons should look correct and work correctly. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: Work as described, no errors. Tested all functions (add, del, de-duplicate, export item, export batch) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9635 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |bgkriegel@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9635 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9635 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15403|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 15464 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15464&action=edit [PASSED QA] Bug 9635 - Replace YUI buttons on label batches pages with Bootstrap This patch converts the toolbar used by label batches pages to Bootstrap, replacing YUI button and menu code with Bootstrap markup. This patch also consolidates the include file and main template. The include file was used in only one template. To test, create a label batch and test all functions related to that batch: adding and removing items, de-duplicating the batch, exporting individual items, exporting the batch, and deleting the batch. Buttons should look correct and work correctly. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: Work as described, no errors. Tested all functions (add, del, de-duplicate, export item, export batch) Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works nicely, no problems found. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9635 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de QA Contact| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9635 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #4 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org