http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9636 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Replace YUI buttons on |Replace YUI buttons on |lables pages with Bootstrap |labels pages with Bootstrap -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9636 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 15398 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15398&action=edit Bug 9636 - Replace YUI buttons on labels pages with Bootstrap This patch converts the toolbar include file used by the label manager to Bootstrap, replacing YUI button and menu code with Bootstrap markup. This patch converts the previous menu buttons to plain buttons, removing the redundant links to the manage pages, which are in the left-hand sidebar. This keeps toolbar buttons within the general category of "action" (as opposed to "view"). This patch also removes an unused include file, labels-new-toolbar.inc To test, view the labels home page and any of the label manage pages (layouts, templates, profiles, batches). Buttons should look correct and work correctly. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9636 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |bgkriegel@gmail.com -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9636 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15406|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 15456 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15456&action=edit [PASSED QA] Bug 9636 - Replace YUI buttons on labels pages with Bootstrap This patch converts the toolbar include file used by the label manager to Bootstrap, replacing YUI button and menu code with Bootstrap markup. This patch converts the previous menu buttons to plain buttons, removing the redundant links to the manage pages, which are in the left-hand sidebar. This keeps toolbar buttons within the general category of "action" (as opposed to "view"). This patch also removes an unused include file, labels-new-toolbar.inc To test, view the labels home page and any of the label manage pages (layouts, templates, profiles, batches). Buttons should look correct and work correctly. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: Work as described. No errors. Nicole is not going to be happy, images in Label creator section of manual needs to change :) Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works nicely, I was wondering if we should have the plus icon on those buttons like we have on the other 'New' buttons. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9636 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #5 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes.