[Bug 26367] New: Warn in HoldsQueue if request itemtype set but request is not item specific
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26367 Bug ID: 26367 Summary: Warn in HoldsQueue if request itemtype set but request is not item specific Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com To recreate: 0 - set AllowHoldItemTypeSelection to 'Allow' 1 - Place a title level hold for a record with an item from Library A for delivery at Library A for a patron from Library A with an itemtype specified 2 - perl misc/cronjobs/holds/build_holds_queue.pl 3 - There are warns: Use of uninitialized value in hash element at /kohadevbox/koha/C4/HoldsQueue.pm line 523. Use of uninitialized value in string eq at /kohadevbox/koha/C4/HoldsQueue.pm line 523. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26367 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26367 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 109620 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109620&action=edit Bug 26367: Unit test This warn only appears when: The borrower and item branches match AND The hold fulfillment policy is any or the pickupbranch matches the items branch specified by hold_fulfillment_policy AND The request has an itemtype set To trigger we simply add some itemtype to existing hold requests in the test To test: 1 - prove -v t/db_dependent/HoldsQueue.t -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26367 --- Comment #2 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 109621 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109621&action=edit Bug 26367: Prevent warn about undefined values when record level hold has an itemtype To test: 1 - set AllowHoldItemTypeSelection to 'Allow' 2 - Find a patron from Library A 3 - Find a record with an item from Library A 4 - Place a title level hold with itemtype specified for a delivery at Library A for patron and record above 5 - perl misc/cronjobs/holds/build_holds_queue.pl 6 - There are warns: Use of uninitialized value in hash element at /kohadevbox/koha/C4/HoldsQueue.pm line 523. Use of uninitialized value in string eq at /kohadevbox/koha/C4/HoldsQueue.pm line 523 7 - Apply this patch 8 - perl misc/cronjobs/holds/build_holds_queue.pl 9 - No more warns! 10 - prove -v t/db_dependent/HoldsQueue.t 11 - All tests pass! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26367 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26367 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | CC| |andrew@bywatersolutions.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26367 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26367 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109620|0 |1 is obsolete| | --- Comment #3 from David Nind <david@davidnind.com> --- Created attachment 113031 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113031&action=edit Bug 26367: Unit test This warn only appears when: The borrower and item branches match AND The hold fulfillment policy is any or the pickupbranch matches the items branch specified by hold_fulfillment_policy AND The request has an itemtype set To trigger we simply add some itemtype to existing hold requests in the test To test: 1 - prove -v t/db_dependent/HoldsQueue.t Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26367 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109621|0 |1 is obsolete| | --- Comment #4 from David Nind <david@davidnind.com> --- Created attachment 113032 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113032&action=edit Bug 26367: Prevent warn about undefined values when record level hold has an itemtype To test: 1 - set AllowHoldItemTypeSelection to 'Allow' 2 - Find a patron from Library A 3 - Find a record with an item from Library A 4 - Place a title level hold with itemtype specified for a delivery at Library A for patron and record above 5 - perl misc/cronjobs/holds/build_holds_queue.pl 6 - There are warns: Use of uninitialized value in hash element at /kohadevbox/koha/C4/HoldsQueue.pm line 523. Use of uninitialized value in string eq at /kohadevbox/koha/C4/HoldsQueue.pm line 523 7 - Apply this patch 8 - perl misc/cronjobs/holds/build_holds_queue.pl 9 - No more warns! 10 - prove -v t/db_dependent/HoldsQueue.t 11 - All tests pass! Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26367 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #5 from David Nind <david@davidnind.com> --- Testing notes - to generate the warnings when build_holds_queue.pl is run (using koha-testing-docker): 1. In staff interface change the library to Midway. 2. Search the catalog for Xenophōntos Agēsilaos. 3. Click on 'Place hold'. 4. For the patron choose Henry Acevedo. 5. For hold details for "Request specific item type" select "Books", then Place hold. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26367 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26367 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26367 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113031|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 114823 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114823&action=edit Bug 26367: Unit test This warn only appears when: The borrower and item branches match AND The hold fulfillment policy is any or the pickupbranch matches the items branch specified by hold_fulfillment_policy AND The request has an itemtype set To trigger we simply add some itemtype to existing hold requests in the test To test: 1 - prove -v t/db_dependent/HoldsQueue.t Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26367 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113032|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 114824 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114824&action=edit Bug 26367: Prevent warn about undefined values when record level hold has an itemtype To test: 1 - set AllowHoldItemTypeSelection to 'Allow' 2 - Find a patron from Library A 3 - Find a record with an item from Library A 4 - Place a title level hold with itemtype specified for a delivery at Library A for patron and record above 5 - perl misc/cronjobs/holds/build_holds_queue.pl 6 - There are warns: Use of uninitialized value in hash element at /kohadevbox/koha/C4/HoldsQueue.pm line 523. Use of uninitialized value in string eq at /kohadevbox/koha/C4/HoldsQueue.pm line 523 7 - Apply this patch 8 - perl misc/cronjobs/holds/build_holds_queue.pl 9 - No more warns! 10 - prove -v t/db_dependent/HoldsQueue.t 11 - All tests pass! Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26367 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26367 --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26367 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to master |Pushed to stable Version(s)|21.05.00 |21.05.00,20.11.02 released in| | --- Comment #9 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 20.11.x for 20.11.02 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26367 --- Comment #10 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Doesn't apply cleanly to 20.05.x, please rebase -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26367 --- Comment #11 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Andrew Fuerste-Henry from comment #10)
Doesn't apply cleanly to 20.05.x, please rebase
The tests for this rely on 19889, it reduces warns but does not affect functionality, can be skipped -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26367 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26367 --- Comment #12 from Didier Gautheron <didier.gautheron@biblibre.com> --- *** Bug 26387 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26367 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org