[Bug 27292] New: TablesSettings.GetColumns() returning nothing creates unexpected Javascript on request.tt
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27292 Bug ID: 27292 Summary: TablesSettings.GetColumns() returning nothing creates unexpected Javascript on request.tt Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: dcook@prosentient.com.au QA Contact: testopia@bugs.koha-community.org I was rebasing Bug 15565 when I noticed strange Javascript errors. The following code in master was the actual problem: columns_settings_borrowers_table = [% TablesSettings.GetColumns( 'circ', 'circulation', 'table_borrowers', 'json' ) | $raw %] At the moment in koha-testing-docker, this creates the following Javascript: "columns_settings_borrowers_table = " For some reason, this doesn't currently cause a problem because the next line is blank and that line is followed by "$(document).ready(function() {". Anyway, there should be data coming back there, so that's something to investigate... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27292 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |22477 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22477 [Bug 22477] Missing DataTables configuration when searching patrons for holds -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27292 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27292 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27292 --- Comment #1 from David Cook <dcook@prosentient.com.au> --- Created attachment 114660 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114660&action=edit Bug 27292: Add TablesSettings directive to fix columns_settings_borrowers_table This patch adds the USE TablesSettings directive which allows the plugin to be invoked to fill the columns_settings_borrowers_table variable. Test plan: 0. Do not apply the patch 1. Go to http://localhost:8081/cgi-bin/koha/reserve/request.pl?borrowernumber=51&biblionumber=29 2. View source on the page and note columns_settings_borrowers_table has no value assigned 2. Apply the patch 3. In a new tab, go to http://localhost:8081/cgi-bin/koha/reserve/request.pl?borrowernumber=51&biblionumber=29 4. Note that nothing has changed on the surfeace 5. View source ont he page and note columns_settings_borrowers_table now has a value assigned -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27292 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy --- Comment #2 from David Cook <dcook@prosentient.com.au> --- Thanks for adding that dependency, Owen. That helped a lot. And now a patch for you (or someone else) to test :D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27292 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27292 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114660|0 |1 is obsolete| | --- Comment #3 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 114703 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114703&action=edit Bug 27292: Add TablesSettings directive to fix columns_settings_borrowers_table This patch adds the USE TablesSettings directive which allows the plugin to be invoked to fill the columns_settings_borrowers_table variable. Test plan: 0. Do not apply the patch 1. Go to http://localhost:8081/cgi-bin/koha/reserve/request.pl?borrowernumber=51&biblionumber=29 2. View source on the page and note columns_settings_borrowers_table has no value assigned 2. Apply the patch 3. In a new tab, go to http://localhost:8081/cgi-bin/koha/reserve/request.pl?borrowernumber=51&biblionumber=29 4. Note that nothing has changed on the surfeace 5. View source ont he page and note columns_settings_borrowers_table now has a value assigned Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27292 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114703|0 |1 is obsolete| | --- Comment #4 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 114946 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114946&action=edit Bug 27292: Add TablesSettings directive to fix columns_settings_borrowers_table This patch adds the USE TablesSettings directive which allows the plugin to be invoked to fill the columns_settings_borrowers_table variable. Test plan: 0. Do not apply the patch 1. Go to http://localhost:8081/cgi-bin/koha/reserve/request.pl?borrowernumber=51&biblionumber=29 2. View source on the page and note columns_settings_borrowers_table has no value assigned 2. Apply the patch 3. In a new tab, go to http://localhost:8081/cgi-bin/koha/reserve/request.pl?borrowernumber=51&biblionumber=29 4. Note that nothing has changed on the surfeace 5. View source ont he page and note columns_settings_borrowers_table now has a value assigned Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27292 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27292 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27292 --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27292 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to master |Pushed to stable --- Comment #6 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 20.11.x for 20.11.02 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27292 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.05.00 |21.05.00,20.11.02 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27292 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com --- Comment #7 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Missing dependencies, not backported to 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27292 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|22477 |24156 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22477 [Bug 22477] Missing DataTables configuration when searching patrons for holds https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24156 [Bug 24156] Basket - Make sort order and number of items to display configurable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27292 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org