[Bug 12109] New: Authority subfield configuration page for controlled fields is broken
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12109 Bug ID: 12109 Summary: Authority subfield configuration page for controlled fields is broken Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org To reproduce: 1) Go to Administration > Authority types 2) Open subfields configuration for one of the controlled fields 3) Verify that the new tab is not shown on top, but at the bottom of the page -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12109 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12109 --- Comment #1 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 38570 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38570&action=edit Bug 12109: Fix tab on the auth subfield configuration page There is a condition in the template to not display the "New" tab if the user is editing a control field. But it results in a broken template. Looking at the biblio frameworks, the New tab exists even for control fields. This patch only fixes the html structure, but a complete fix should be provide, for auth and biblio, if we want not to let the ability to create subfields for control fields. Test plan: Edit subfields for a control field (admin/marc_subfields_structure.pl?op=add_form&tagfield=001&frameworkcode= for instance) and confirm that the view is now fixed. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12109 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m Assignee|oleonard@myacpl.org |jonathan.druart@biblibre.co | |m Patch complexity|--- |Trivial patch Severity|minor |normal -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12109 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12109 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38570|0 |1 is obsolete| | --- Comment #2 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 38635 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38635&action=edit Bug 12109: Fix tab on the auth subfield configuration page There is a condition in the template to not display the "New" tab if the user is editing a control field. But it results in a broken template. Looking at the biblio frameworks, the New tab exists even for control fields. This patch only fixes the html structure, but a complete fix should be provide, for auth and biblio, if we want not to let the ability to create subfields for control fields. Test plan: Edit subfields for a control field (admin/marc_subfields_structure.pl?op=add_form&tagfield=001&frameworkcode= for instance) and confirm that the view is now fixed. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> NOTE: Checked LDR, 001, and 008. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12109 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12109 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38635|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 38701 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38701&action=edit [PASSED QA] Bug 12109: Fix tab on the auth subfield configuration page There is a condition in the template to not display the "New" tab if the user is editing a control field. But it results in a broken template. Looking at the biblio frameworks, the New tab exists even for control fields. This patch only fixes the html structure, but a complete fix should be provide, for auth and biblio, if we want not to let the ability to create subfields for control fields. Test plan: Edit subfields for a control field (admin/marc_subfields_structure.pl?op=add_form&tagfield=001&frameworkcode= for instance) and confirm that the view is now fixed. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> NOTE: Checked LDR, 001, and 008. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12109 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Status|Passed QA |Pushed to Master --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org