[Bug 8399] New: Problems with mandatory field alert message for authorities
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8399 Priority: P5 - low Change sponsored?: --- Bug ID: 8399 CC: jcamins@cpbibliography.com Assignee: gmcharlt@gmail.com Summary: Problems with mandatory field alert message for authorities Severity: normal Classification: Unclassified OS: All Reporter: katrin.fischer@bsz-bw.de Hardware: All Status: NEW Version: master Component: MARC Authority data support Product: Koha Created attachment 10725 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10725&action=edit screenshot When creating a new authority (example: PERS_NAME) and only entering 100$a, on saving the record an alert will show the missing mandatory fields. In the alert the descriptions of the messages are cut off and the tab number is missing (see screenshot). -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8399 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This is still valid in current master. The tab numbers are not included in the error message and longer descriptions are cut off. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8399 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8399 --- Comment #2 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 37405 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37405&action=edit Bug 8399: Display tab number on the mandatory field alert (authority) A wrong variable scope was used here, the number value is contained in the BIG_LOOP (note for later: change this variable name...). Test plan: 1/ Define 1+ mandatory fields for an authority type 2/ Create an authority and don't fill the mandatory fields 3/ Try to save: the popup alert should display the number of the tab. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8399 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m Assignee|gmcharlt@gmail.com |jonathan.druart@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8399 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8399 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard@gmail.com --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> --- *** Bug 8830 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8399 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolyn.somers@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8399 Andreas Hedström Mace <andreas.hedstrom.mace@sub.su.se> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andreas.hedstrom.mace@sub.s | |u.se Status|Needs Signoff |Failed QA --- Comment #4 from Andreas Hedström Mace <andreas.hedstrom.mace@sub.su.se> --- This patch only seems to solve one of the two issues in the bug. The tab number are there but longer descriptions are still being cut off. Please correct me if i have missed something or misunderstood. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8399 --- Comment #5 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Andreas Hedström Mace from comment #4)
This patch only seems to solve one of the two issues in the bug. The tab number are there but longer descriptions are still being cut off.
Please detail, I don't understand the problem here. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8399 --- Comment #6 from Andreas Hedström Mace <andreas.hedstrom.mace@sub.su.se> --- Created attachment 37795 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37795&action=edit Screenshot -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8399 --- Comment #7 from Andreas Hedström Mace <andreas.hedstrom.mace@sub.su.se> --- Added a screenshot of the issue. The description of the fields are still being cut off, like "fixed length control field" turning up as "fixed length control f". Hope this helps, otherwise ask again! =) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8399 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8399 --- Comment #8 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 37800 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37800&action=edit Bug 8399: No need to truncate the marc field text to 22 chars The text for the marc field are truncated to 22 chars when displaying an error on mandatory fields. This limitation is useless and this patch removes it. Test plan: Create a mandatory subfield and set a long text (more than 22 chars) edit or add an authority, click on save. You should get the error displayed with the full text Note that this patch modifies the same code for biblio. Test plan is the same for biblio. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8399 --- Comment #9 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Andreas Hedström Mace from comment #7)
Added a screenshot of the issue. The description of the fields are still being cut off, like "fixed length control field" turning up as "fixed length control f". Hope this helps, otherwise ask again! =)
Perfect thanks! The last patch fixes that. Same on the biblio side. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8399 Andreas Hedström Mace <andreas.hedstrom.mace@sub.su.se> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8399 Andreas Hedström Mace <andreas.hedstrom.mace@sub.su.se> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37405|0 |1 is obsolete| | Attachment #37800|0 |1 is obsolete| | --- Comment #10 from Andreas Hedström Mace <andreas.hedstrom.mace@sub.su.se> --- Created attachment 37804 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37804&action=edit Bug 8399: No need to truncate the marc field text to 22 chars The text for the marc field are truncated to 22 chars when displaying an error on mandatory fields. This limitation is useless and this patch removes it. Test plan: Create a mandatory subfield and set a long text (more than 22 chars) edit or add an authority, click on save. You should get the error displayed with the full text Note that this patch modifies the same code for biblio. Test plan is the same for biblio. Signed-off-by: Andreas Hedström Mace <andreas.hedstrom.mace@sub.su.se> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8399 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37405|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8399 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8399 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37405|0 |1 is obsolete| | Attachment #37804|0 |1 is obsolete| | --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 37995 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37995&action=edit [PASSED QA] Bug 8399: No need to truncate the marc field text to 22 chars The text for the marc field are truncated to 22 chars when displaying an error on mandatory fields. This limitation is useless and this patch removes it. Test plan: Create a mandatory subfield and set a long text (more than 22 chars) edit or add an authority, click on save. You should get the error displayed with the full text Note that this patch modifies the same code for biblio. Test plan is the same for biblio. Signed-off-by: Andreas Hedström Mace <andreas.hedstrom.mace@sub.su.se> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8399 --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 37996 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37996&action=edit [PASSED QA] Bug 8399: Display tab number on the mandatory field alert (authority) A wrong variable scope was used here, the number value is contained in the BIG_LOOP (note for later: change this variable name...). Test plan: 1/ Define 1+ mandatory fields for an authority type 2/ Create an authority and don't fill the mandatory fields 3/ Try to save: the popup alert should display the number of the tab. Signed-off-by: Andreas Hedström Mace <andreas.hedstrom.mace@sub.su.se> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8399 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Status|Passed QA |Pushed to Master --- Comment #13 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patches pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org