[Bug 15197] New: Multiple special characters (</&/>) not escaped correctly in Rancor
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15197 Bug ID: 15197 Summary: Multiple special characters (</&/>) not escaped correctly in Rancor Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: Cataloging Assignee: jweaver@bywatersolutions.com Reporter: jweaver@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl Due to a slight regex issue, multiple special characters will not be correctly escaped when saving a record, and data loss may occur. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15197 Jesse Weaver <jweaver@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15197 Jesse Weaver <jweaver@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15197 --- Comment #1 from Jesse Weaver <jweaver@bywatersolutions.com> --- Created attachment 44894 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44894&action=edit Bug 15197: In Rancor, multiple &/</> characters not escaped on saving -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15197 Jesse Weaver <jweaver@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44894|0 |1 is obsolete| | --- Comment #2 from Jesse Weaver <jweaver@bywatersolutions.com> --- Created attachment 44895 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44895&action=edit Bug 15197: In Rancor, multiple &/</" characters not escaped on saving -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15197 --- Comment #3 from Jesse Weaver <jweaver@bywatersolutions.com> --- Test plan: 1) On current master, create a record in Rancor containing multiple <, > or & characters ("A & B & C", for example). 2) Try to save the record, it will silently fail. 3) Apply this patch. 4) The record should now save correctly. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15197 Jesse Weaver <jweaver@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Multiple special characters |In Rancor, multiple &/</" |(</&/>) not escaped |characters not escaped on |correctly in Rancor |saving -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15197 --- Comment #4 from Jesse Weaver <jweaver@bywatersolutions.com> --- (In reply to Jesse Weaver from comment #3)
Test plan:
1) On current master, create a record in Rancor containing multiple <, > or & characters ("A & B & C", for example). 2) Try to save the record, it will silently fail. 3) Apply this patch. 4) The record should now save correctly.
Ugh, I shouldn't comment when tired. The characters in question are <, & and ". -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15197 Jesse Weaver <jweaver@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44895|0 |1 is obsolete| | --- Comment #5 from Jesse Weaver <jweaver@bywatersolutions.com> --- Created attachment 44896 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44896&action=edit Bug 15197: In Rancor, multiple &/</" characters not escaped on saving Test plan: 1) On current master, create a record in Rancor containing multiple &, < or " characters ("A & B & C", for example). 2) Try to save the record, it will silently fail. 3) Apply this patch. 4) The record should now save correctly. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15197 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15197 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44896|0 |1 is obsolete| | --- Comment #6 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 44897 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44897&action=edit [SIGNED-OFF] Bug 15197: In Rancor, multiple &/</" characters not escaped on saving Test plan: 1) On current master, create a record in Rancor containing multiple &, < or " characters ("A & B & C", for example). 2) Try to save the record, it will silently fail. 3) Apply this patch. 4) The record should now save correctly. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Works well, record saved No errors -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15197 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15197 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44897|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 44905 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44905&action=edit [PASSED QA] Bug 15197: In Rancor, multiple &/</" characters not escaped on saving Test plan: 1) On current master, create a record in Rancor containing multiple &, < or " characters ("A & B & C", for example). 2) Try to save the record, it will silently fail. 3) Apply this patch. 4) The record should now save correctly. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Works well, record saved No errors Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15197 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Status|Passed QA |Pushed to Master --- Comment #8 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org