[Bug 10067] New: decreaseLoanHighHolds messes with specify due date
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10067 Bug ID: 10067 Summary: decreaseLoanHighHolds messes with specify due date Classification: Unclassified Change sponsored?: --- Product: Koha Version: 3.10 Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: nengard@gmail.com CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com It appears that when the criterion for the shortened loan period is met, not only does that particular item get the shortened loan period, so does any subsequent item checked out in that session. It appears that decreaseLoanHighHolds functionally affects Specify due date, and requires the staff member to click on Clear in order to make sure the correct loan period is applied for the next item(s). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10067 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.10 |master --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Confirmed in master. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10067 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cbrannon@cdalibrary.org -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10067 --- Comment #2 from Galen Charlton <gmcharlt@gmail.com> --- Summarizing some discussion in IRC today, it would be reasonable for the high holds functionality to simply announce that it has shortened the loan period, and not hook into the confirmation mechanism. That way, it would need to touch the due date input widget at all. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10067 --- Comment #3 from Christopher Brannon <cbrannon@cdalibrary.org> --- How would this relate to a scenario where staff are actually using the Specify due date field? For example, a longer loan period is specified. Or perhaps a shorter loan period is specified. Christopher -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10067 Viktor Sarge <viktor.sarge@regionhalland.se> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |viktor.sarge@regionhalland. | |se --- Comment #4 from Viktor Sarge <viktor.sarge@regionhalland.se> --- I've been giving this some thought and I don't mind the current workflow where you get a chance to tell a patron that the book will have a shorter loan period than usual. But the problem is that decreaseLoanHighHolds hooks into duedatespec and overwrites it. So even if you auto clear after using highholds you will lose any date you had entered manually. My two cents is that this could be solved with this workflow: 1) When highholds is active pick upp anything stored in "duedatespec" and stick it into the new parameter "specifiedDueDateToRestore" 2) Let highholds overwrite duedatespec as it currently do. 3) When circulation.pl finds a non empty specifiedDueDateToRestore parameter stick this back into duedatespec. This way the due date from highholds will be the one off value it's supposed to be and manually defined due dates will be restored. I've been looking at 10067 from a few different angles and this is what I can come up with that does'nt change peoples current workflow. I have yet to discover any fatal flaws with this approach althoguh there might be several for all I know. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10067 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11565 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10067 --- Comment #5 from Christopher Brannon <cbrannon@cdalibrary.org> --- I would also suggest considering http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11565 while looking at this. There are times you don't want to allow this feature to change the date. For example, we have a bookmobile that visits a location once a month. There needs to be a way this shortened due date can be overridden on the fly, or perhaps an issuing library can ignore this rule in the circulation rules. I know this is an entirely separate functionality, but I think it should be kept in mind for something to work towards as this is being worked out. That's my two cents. Christopher -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10067 Eivin Giske Skaaren <eskaaren@yahoo.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |eskaaren@yahoo.no |ity.org | CC| |eskaaren@yahoo.no -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10067 --- Comment #6 from Eivin Giske Skaaren <eskaaren@yahoo.no> --- Created attachment 39466 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39466&action=edit Bug 10067 fix due date issue -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10067 Eivin Giske Skaaren <eskaaren@yahoo.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff --- Comment #7 from Eivin Giske Skaaren <eskaaren@yahoo.no> --- To test: Apply the patch and try to check out items both that have enough holds that the decreaseLoanHighHolds function kicks in and without. See that the due date now is cleared if sticky is not selected and that the picked date stays put when sticky is selected. Also when the due date is restricted it is checked out with the correct date but the due date in the "Specify due date" box either is cleared or kept to the picked date depending on if sticky is selected. Known limitation: Does not work too well when jumping between different parts of the system as it relies on the values posted to the circulation.pl script. Sponsored-by: Halland County Library -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10067 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Eivin, could you make your last comment be part of your commit message please? And to make it easier for testers, could you please also add a step by step test plan to the commit message? Thx! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10067 Eivin Giske Skaaren <eskaaren@yahoo.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39466|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10067 --- Comment #9 from Eivin Giske Skaaren <eskaaren@yahoo.no> --- Created attachment 39491 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39491&action=edit Bug 10067 - decreaseLoanHighHolds messes with specify due date To test: 1. On a branch up to date with master: apply the patch. 2. Try to check out items both with and without holds. (The decreaseLoanHighHolds function should be configured and kick in when testing an item. 3. Expected results are: The due date date field should be cleared after checkout if "Remember for session" is not selected. If it is selected then the chosen date should stay in the field even if the warning about reduced loan time for an item with too many holds is displayed. Also the correct due dates are shown in the table after a checkout. Known limitation: Does not work too well when jumping between different parts of the system as it relies on the values sent to the circulation.pl script. Sponsored-by: Halland County Library -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10067 --- Comment #10 from Viktor Sarge <viktor.sarge@regionhalland.se> --- I've tested it and it does what it's supposed to do. Even with the listed limitations it's a bliss compared to the current situation. I will still leave it in "Needs signoff" however since Eivin is working on our behalf. Anyone else that's up for having a look at it? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10067 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39491|0 |1 is obsolete| | --- Comment #11 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 40707 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40707&action=edit Bug 10067 - decreaseLoanHighHolds messes with specify due date To test: 1. On a branch up to date with master: apply the patch. 2. Try to check out items both with and without holds. (The decreaseLoanHighHolds function should be configured and kick in when testing an item. 3. Expected results are: The due date date field should be cleared after checkout if "Remember for session" is not selected. If it is selected then the chosen date should stay in the field even if the warning about reduced loan time for an item with too many holds is displayed. Also the correct due dates are shown in the table after a checkout. Known limitation: Does not work too well when jumping between different parts of the system as it relies on the values sent to the circulation.pl script. Sponsored-by: Halland County Library Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> This does what it says it will do, however I think it might be a change of behaviour, in terms of the specify due date. It now clears it the date after ever item is checked out. Previously the due date would stay, until the current borrower is dealt with. And remember for session sets it so that it stays until the staff member logs out, or clears it. With the patch, now the date is clear after every check out .. this is a change that may annoy some people. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10067 --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> ---
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
This does what it says it will do, however I think it might be a change of behaviour, in terms of the specify due date. It now clears it the date after ever item is checked out.
Previously the due date would stay, until the current borrower is dealt with. And remember for session sets it so that it stays until the staff member logs out, or clears it.
With the patch, now the date is clear after every check out .. this is a change that may annoy some people.
Hm I agree with Chris that this change of behaviour might not be good for every library and use case - so people might get annoyed. I'd prefer if the date was only cleared out after checking out an item where the due date gets shortened. Would that work? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10067 --- Comment #13 from Eivin Giske Skaaren <eivin@sysmystic.com> --- Obviuously I am rather new to Koha but I actually thought it was the other way. Since you have the "Remember for session" checkbox and also probably a default due date in the system (perhaps even on item level? have not checked/can not remember right now) I found it strange that the value was not cleared. Do we want the default behavior to be that the value is cleared only when the due date is shortened? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10067 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz --- Comment #14 from Chris Cormack <chris@bigballofwax.co.nz> --- The rule for developing on Koha is that we don't change behaviour that people will have been using for years. (The specify due date feature is about 8 years old, so suddenly changing the way it works will most definitely catch some people out) The reason we have this rule is so people won't be scared to upgrade (it's also the rule why new features go in switched off by default on upgrade) Hope this makes sense -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10067 Eivin Giske Skaaren <eivin@sysmystic.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40707|0 |1 is obsolete| | --- Comment #15 from Eivin Giske Skaaren <eivin@sysmystic.com> --- Created attachment 41012 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41012&action=edit Bug 10067 - decreaseLoanHighHolds messes with specify due date To test: 1. On a branch up to date with master: apply the patch. 2. Try to check out items both with and without holds. (The decreaseLoanHighHolds function should be configured and kick in when testing an item. 3. Expected results are: The due date date field should be cleared after checkout if "Remember for session" is not selected. If it is selected then the chosen date should stay in the field even if the warning about reduced loan time for an item with too many holds is displayed. Also the correct due dates are shown in the table after a checkout. Known limitation: Does not work too well when jumping between different parts of the system as it relies on the values sent to the circulation.pl script. Sponsored-by: Halland County Library Refactored to both fix specific issue where date is changed and still have the old behaviour with date kept intact. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10067 --- Comment #16 from Eivin Giske Skaaren <eivin@sysmystic.com> --- Change in expected result: The date is not cleared anymore. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10067 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #17 from Nicole C. Engard <nengard@gmail.com> --- This looks like it's signed off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10067 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff --- Comment #18 from Chris Cormack <chris@bigballofwax.co.nz> --- (In reply to Nicole C. Engard from comment #17)
This looks like it's signed off
Hmm wrong bug by accident Nicole? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10067 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion --- Comment #19 from Christopher Brannon <cbrannon@cdalibrary.org> --- If I am testing correctly, and reading correctly, I am not seeing any benefit to this patch. In it's current state, it is doing what it always did. Can someone tell me what should be different in behavior with the patch applied? Sorry. Don't know if it just me or what. Christopher -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10067 --- Comment #20 from Eivin Giske Skaaren <eivin@sysmystic.com> --- The difference is that the loan period is not shortened for the next scanned book. Without the patch if you get a shortened loan period then the next scanned book will also get that same shortened period automatically. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10067 Nicole Engard (ByWater) <nicole@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nicole@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10067 --- Comment #21 from Eivin Giske Skaaren <eivin@sysmystic.com> --- I have just retested this and the difference is what I said earlier: With the patch you can set the "specify due date" and when the item get shortened loan date "specify due date" will not be changed to the shortened date and you can keep on checking out items with the original date. I have attached some screenshots. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10067 --- Comment #22 from Eivin Giske Skaaren <eivin@sysmystic.com> --- Created attachment 42127 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42127&action=edit Shortened loan -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10067 --- Comment #23 from Eivin Giske Skaaren <eivin@sysmystic.com> --- Created attachment 42128 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42128&action=edit Specify due date not changed -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10067 Eivin Giske Skaaren <eivin@sysmystic.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10067 Zeno Tajoli <z.tajoli@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch CC| |z.tajoli@cineca.it -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10067 Zeno Tajoli <z.tajoli@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|z.tajoli@cineca.it | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10067 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10067 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #41012|0 |1 is obsolete| | --- Comment #24 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 42259 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42259&action=edit Bug 10067 - decreaseLoanHighHolds messes with specify due date To test: 1. On a branch up to date with master: apply the patch. 2. Try to check out items both with and without holds. (The decreaseLoanHighHolds function should be configured and kick in when testing an item. 3. Expected results are: The due date date field should be cleared after checkout if "Remember for session" is not selected. If it is selected then the chosen date should stay in the field even if the warning about reduced loan time for an item with too many holds is displayed. Also the correct due dates are shown in the table after a checkout. Known limitation: Does not work too well when jumping between different parts of the system as it relies on the values sent to the circulation.pl script. Sponsored-by: Halland County Library Refactored to both fix specific issue where date is changed and still have the old behaviour with date kept intact. Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10067 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #25 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Please resubmit the same patch but without the code cleaning: -my $stickyduedate = $query->param('stickyduedate') || +my $stickyduedate = $query->param('stickyduedate') || $session->param('stickyduedate'); This make 1/ the patch hard to read and 2/ all the other patches in the queue in conflict and won't apply anymore (13 at the moment). -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10067 Eivin Giske Skaaren <eivin@sysmystic.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42259|0 |1 is obsolete| | --- Comment #26 from Eivin Giske Skaaren <eivin@sysmystic.com> --- Created attachment 42437 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42437&action=edit Bug 10067 - decreaseLoanHighHolds messes with specify due date To test: 1. On a branch up to date with master: apply the patch. 2. Try to check out items both with and without holds. (The decreaseLoanHighHolds function should be configured and kick in when testing an item. 3. Expected results are: The due date date field should be cleared after checkout if "Remember for session" is not selected. If it is selected then the chosen date should stay in the field even if the warning about reduced loan time for an item with too many holds is displayed. Also the correct due dates are shown in the table after a checkout. Known limitation: Does not work too well when jumping between different parts of the system as it relies on the values sent to the circulation.pl script. Sponsored-by: Halland County Library Refactored to both fix specific issue where date is changed and still have the old behaviour with date kept intact. Rebase Remove code whitespace cleanup -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10067 Eivin Giske Skaaren <eivin@sysmystic.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42437|0 |1 is obsolete| | --- Comment #27 from Eivin Giske Skaaren <eivin@sysmystic.com> --- Created attachment 42438 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42438&action=edit Bug 10067 - decreaseLoanHighHolds messes with specify due date To test: 1. On a branch up to date with master: apply the patch. 2. Try to check out items both with and without holds. (The decreaseLoanHighHolds function should be configured and kick in when testing an item. 3. Expected results are: The due date date field should be cleared after checkout if "Remember for session" is not selected. If it is selected then the chosen date should stay in the field even if the warning about reduced loan time for an item with too many holds is displayed. Also the correct due dates are shown in the table after a checkout. Known limitation: Does not work too well when jumping between different parts of the system as it relies on the values sent to the circulation.pl script. Sponsored-by: Halland County Library Refactored to both fix specific issue where date is changed and still have the old behaviour with date kept intact. Rebase Remove code whitespace cleanup Remove one more code whitespace cleanup -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10067 Eivin Giske Skaaren <eivin@sysmystic.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #28 from Eivin Giske Skaaren <eivin@sysmystic.com> --- I think the readability is not better when it is very inconsistent but I have restored the original inconsistencies :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10067 --- Comment #29 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Comment on attachment 42438 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42438 Bug 10067 - decreaseLoanHighHolds messes with specify due date Review of attachment 42438: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=10067&attachment=42438) ----------------------------------------------------------------- ::: circ/circulation.pl @@ +524,5 @@
+ + if ($stickyduedate eq 'on') { + $session->param( 'stickyduedate', $duedatespec ); + } +}
Without a good reason, this should be merged into the following block: 565 # save stickyduedate to session 566 if ($stickyduedate) { 567 $session->param( 'stickyduedate', $duedatespec ); 568 } Something like: if ( $stickyduedate or $restoreduedatespec ) { $duedatespec = $restoreduedatespec || $duedatespec; if ($stickyduedate) { $session->param( 'stickyduedate', $duedatespec ); } } (not tested) ::: koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt @@ +388,3 @@
<input type="hidden" name="borrowernumber" value="[% borrowernumber %]" /> <input type="hidden" name="duedatespec" value="[% duedatespec %]" /> + <input type="hidden" name="restoreduedatespec" />
Duplicated. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10067 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10067 Eivin Giske Skaaren <eivin@sysmystic.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42438|0 |1 is obsolete| | --- Comment #30 from Eivin Giske Skaaren <eivin@sysmystic.com> --- Created attachment 42750 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42750&action=edit Bug 10067 - decreaseLoanHighHolds messes with specify due date To test: 1. On a branch up to date with master: apply the patch. 2. Try to check out items both with and without holds. (The decreaseLoanHighHolds function should be configured and kick in when testing an item. 3. Expected results are: The due date date field should be cleared after checkout if "Remember for session" is not selected. If it is selected then the chosen date should stay in the field even if the warning about reduced loan time for an item with too many holds is displayed. Also the correct due dates are shown in the table after a checkout. Known limitation: Does not work too well when jumping between different parts of the system as it relies on the values sent to the circulation.pl script. Sponsored-by: Halland County Library Refactored to both fix specific issue where date is changed and still have the old behaviour with date kept intact. Rebase Remove code whitespace cleanup Remove one more code whitespace cleanup Removed duplicate tag -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10067 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10067 --- Comment #31 from Eivin Giske Skaaren <eivin@sysmystic.com> --- Hi Jonathan, Yes there is a reason for that bit of code being outside of that block. It needs to be executed before the $template->param() that comes directly after on line 530. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10067 Eivin Giske Skaaren <eivin@sysmystic.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10067 --- Comment #32 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Eivin Giske Skaaren from comment #31)
Hi Jonathan,
Yes there is a reason for that bit of code being outside of that block.
It needs to be executed before the $template->param() that comes directly after on line 530.
Yes but you can move the existing block before the $template->param :) So that the stickyduedate value is set to the session at only 1 place in the script. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10067 Eivin Giske Skaaren <eivin@sysmystic.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42750|0 |1 is obsolete| | --- Comment #33 from Eivin Giske Skaaren <eivin@sysmystic.com> --- Created attachment 42791 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42791&action=edit Bug 10067 - decreaseLoanHighHolds messes with specify due date To test: 1. On a branch up to date with master: apply the patch. 2. Try to check out items both with and without holds. (The decreaseLoanHighHolds function should be configured and kick in when testing an item. 3. Expected results are: The due date date field should be cleared after checkout if "Remember for session" is not selected. If it is selected then the chosen date should stay in the field even if the warning about reduced loan time for an item with too many holds is displayed. Also the correct due dates are shown in the table after a checkout. Known limitation: Does not work too well when jumping between different parts of the system as it relies on the values sent to the circulation.pl script. Sponsored-by: Halland County Library Refactored to both fix specific issue where date is changed and still have the old behaviour with date kept intact. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10067 Eivin Giske Skaaren <eivin@sysmystic.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42791|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10067 Eivin Giske Skaaren <eivin@sysmystic.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42750|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10067 Eivin Giske Skaaren <eivin@sysmystic.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42750|0 |1 is obsolete| | --- Comment #34 from Eivin Giske Skaaren <eivin@sysmystic.com> --- Created attachment 42793 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42793&action=edit Bug 10067 - decreaseLoanHighHolds messes with specify due date To test: 1. On a branch up to date with master: apply the patch. 2. Try to check out items both with and without holds. (The decreaseLoanHighHolds function should be configured and kick in when testing an item. 3. Expected results are: The due date date field should be cleared after checkout if "Remember for session" is not selected. If it is selected then the chosen date should stay in the field even if the warning about reduced loan time for an item with too many holds is displayed. Also the correct due dates are shown in the table after a checkout. Known limitation: Does not work too well when jumping between different parts of the system as it relies on the values sent to the circulation.pl script. Sponsored-by: Halland County Library Refactored to both fix specific issue where date is changed and still have the old behaviour with date kept intact. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10067 Eivin Giske Skaaren <eivin@sysmystic.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42793|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10067 --- Comment #35 from Eivin Giske Skaaren <eivin@sysmystic.com> --- Created attachment 42794 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42794&action=edit Bug 10067 - decreaseLoanHighHolds messes with specify due date To test: 1. On a branch up to date with master: apply the patch. 2. Try to check out items both with and without holds. (The decreaseLoanHighHolds function should be configured and kick in when testing an item. 3. Expected results are: The due date date field should be cleared after checkout if "Remember for session" is not selected. If it is selected then the chosen date should stay in the field even if the warning about reduced loan time for an item with too many holds is displayed. Also the correct due dates are shown in the table after a checkout. Known limitation: Does not work too well when jumping between different parts of the system as it relies on the values sent to the circulation.pl script. Sponsored-by: Halland County Library Refactored to both fix specific issue where date is changed and still have the old behaviour with date kept intact. Rebase Remove code whitespace cleanup Remove one more code whitespace cleanup Removed duplicate tag Refactored stickyduedate session parameter -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10067 --- Comment #36 from Eivin Giske Skaaren <eivin@sysmystic.com> --- Changed as suggested. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10067 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff --- Comment #37 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- A signoff is needed for this last version. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10067
Nicole Engard (ByWater) <nicole@bywatersolutions.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Patch doesn't apply
--- Comment #38 from Nicole Engard (ByWater) <nicole@bywatersolutions.com> ---
11:02 ~/kohaclone (master % u=)$ git qa 10067
>From git://git.koha-community.org/koha
* branch master -> FETCH_HEAD
Branch bug10067-qa set up to track remote branch master from origin.
Switched to a new branch 'bug10067-qa'
Bug 10067 - decreaseLoanHighHolds messes with specify due date
42794 - Bug 10067 - decreaseLoanHighHolds messes with specify due date
Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 10067 - decreaseLoanHighHolds messes with specify due date
Using index info to reconstruct a base tree...
Falling back to patching base and 3-way merge...
Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt
Auto-merging circ/circulation.pl
CONFLICT (content): Merge conflict in circ/circulation.pl
Failed to merge in the changes.
Patch failed at 0001 Bug 10067 - decreaseLoanHighHolds messes with specify due
date
When you have resolved this problem run "git bz apply --continue".
If you would prefer to skip this patch, instead run "git bz apply --skip".
To restore the original branch and stop patching run "git bz apply --abort".
Patch left in
/tmp/Bug-10067---decreaseLoanHighHolds-messes-with-spec-ly2_w7.patch
11:03 ~/kohaclone (bug10067-qa *+%|AM u=)$
--
You are receiving this mail because:
You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10067 Eivin Giske Skaaren <eivin@sysmystic.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42794|0 |1 is obsolete| | --- Comment #39 from Eivin Giske Skaaren <eivin@sysmystic.com> --- Created attachment 44290 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44290&action=edit Bug 10067 - decreaseLoanHighHolds messes with specify due date To test: 1. On a branch up to date with master: apply the patch. 2. Try to check out items both with and without holds. (The decreaseLoanHighHolds function should be configured and kick in when testing an item. 3. Expected results are: The due date date field should be cleared after checkout if "Remember for session" is not selected. If it is selected then the chosen date should stay in the field even if the warning about reduced loan time for an item with too many holds is displayed. Also the correct due dates are shown in the table after a checkout. Known limitation: Does not work too well when jumping between different parts of the system as it relies on the values sent to the circulation.pl script. Sponsored-by: Halland County Library Refactored to both fix specific issue where date is changed and still have the old behaviour with date kept intact. Rebase Remove code whitespace cleanup Remove one more code whitespace cleanup Removed duplicate tag Refactored stickyduedate session parameter Rebased -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10067 Eivin Giske Skaaren <eivin@sysmystic.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10067 --- Comment #40 from Nicole Engard (ByWater) <nicole@bywatersolutions.com> --- Created attachment 44291 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44291&action=edit warning appears The behavior hasn't changed. It still uses the set due date and so the date is filled in so the next check out I do, which has no holds on it is automatically due in 2 days instead of the original loan period. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10067 --- Comment #41 from Nicole Engard (ByWater) <nicole@bywatersolutions.com> --- Created attachment 44292 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44292&action=edit specify due date filled in -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10067 Nicole Engard (ByWater) <nicole@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10067 Eivin Giske Skaaren <eivin@sysmystic.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44290|0 |1 is obsolete| | --- Comment #42 from Eivin Giske Skaaren <eivin@sysmystic.com> --- Created attachment 44300 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44300&action=edit Bug 10067 - decreaseLoanHighHolds messes with specify due date To test: 1. On a branch up to date with master: apply the patch. 2. Try to check out items both with and without holds. (The decreaseLoanHighHolds function should be configured and kick in when testing an item. 3. Expected results are: The due date date field should be cleared after checkout if "Remember for session" is not selected. If it is selected then the chosen date should stay in the field even if the warning about reduced loan time for an item with too many holds is displayed. Also the correct due dates are shown in the table after a checkout. Known limitation: Does not work too well when jumping between different parts of the system as it relies on the values sent to the circulation.pl script. Sponsored-by: Halland County Library Refactored to both fix specific issue where date is changed and still have the old behaviour with date kept intact. Rebase Remove code whitespace cleanup Remove one more code whitespace cleanup Removed duplicate tag Refactored stickyduedate session parameter Fix datefield set by highholds if blanc -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10067 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10067 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44300|0 |1 is obsolete| | --- Comment #43 from Nicole C. Engard <nengard@gmail.com> --- Created attachment 44301 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44301&action=edit Bug 10067 - decreaseLoanHighHolds messes with specify due date To test: 1. On a branch up to date with master: apply the patch. 2. Try to check out items both with and without holds. (The decreaseLoanHighHolds function should be configured and kick in when testing an item. 3. Expected results are: The due date date field should be cleared after checkout if "Remember for session" is not selected. If it is selected then the chosen date should stay in the field even if the warning about reduced loan time for an item with too many holds is displayed. Also the correct due dates are shown in the table after a checkout. Known limitation: Does not work too well when jumping between different parts of the system as it relies on the values sent to the circulation.pl script. Sponsored-by: Halland County Library Refactored to both fix specific issue where date is changed and still have the old behaviour with date kept intact. Rebase Remove code whitespace cleanup Remove one more code whitespace cleanup Removed duplicate tag Refactored stickyduedate session parameter Fix datefield set by highholds if blanc Signed-off-by: Nicole Engard <nengard@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10067 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #44 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I am sorry, I have tested this up and down, but it doesn't work for me. The specified due date always gets set to the shortened due date and my previously specified date is lost :( -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10067 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10067 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44301|0 |1 is obsolete| | --- Comment #45 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 44908 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44908&action=edit [PASSED QA] Bug 10067 - decreaseLoanHighHolds messes with specify due date To test: 1. On a branch up to date with master: apply the patch. 2. Try to check out items both with and without holds. (The decreaseLoanHighHolds function should be configured and kick in when testing an item. 3. Expected results are: The due date date field should be cleared after checkout if "Remember for session" is not selected. If it is selected then the chosen date should stay in the field even if the warning about reduced loan time for an item with too many holds is displayed. Also the correct due dates are shown in the table after a checkout. Known limitation: Does not work too well when jumping between different parts of the system as it relies on the values sent to the circulation.pl script. Sponsored-by: Halland County Library Refactored to both fix specific issue where date is changed and still have the old behaviour with date kept intact. Rebase Remove code whitespace cleanup Remove one more code whitespace cleanup Removed duplicate tag Refactored stickyduedate session parameter Fix datefield set by highholds if blanc Signed-off-by: Nicole Engard <nengard@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10067 --- Comment #46 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Ok, I tested again and after logging in and out again it started to work... I think my previous testing was flawed. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10067 --- Comment #47 from Eivin Giske Skaaren <eivin@sysmystic.com> --- (In reply to Katrin Fischer from comment #46)
Ok, I tested again and after logging in and out again it started to work... I think my previous testing was flawed.
Great, this has been redone and rebased a lot so I got a little bit worried there :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10067 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #48 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Eivin! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org