[Bug 21555] New: Merging Patrons allows for all patrons to be selected
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21555 Bug ID: 21555 Summary: Merging Patrons allows for all patrons to be selected Change sponsored?: --- Product: Koha Version: 18.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: kelly@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com The feature of merging patrons (bug #9302 ) did include a fail safe, according to the bug, if/when using this feature, the option of "selecting all" patrons from a search was chosen, then the option to merge could not be used. When testing this feature, if a few patrons were chosen and then "select all" is chosen, the merge feature is still available to use. If no patrons are chosen and then "select all" is chosen, merge option is not available. Test: how it currently works 1. Search for Patrons by Last Name by Letter 2. From this list, choose patron a, patron b, patron c 3. See that merge patron option available 4. Now select all patrons - merge patron option still available Test: (how it should work) 1. Search for patrons by last name by letter 2.From this list choose patron a, patron b, patron c 3. See that merge patron option avail 4. Now "select all" patrons 3. See that merge patron option not available (greyed out) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21555 Rebecca Coert <rcoert@arlingtonva.us> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rcoert@arlingtonva.us -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21555 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21555 --- Comment #1 from Brendan Lawlor <blawlor@clamsnet.org> --- Created attachment 186304 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186304&action=edit Bug 21555: Disable merge patrons button when using select all This patch disables the merge patrons button when select all is clicked. The button is re-enabled after clicking clear all or manually changing the selection. To test: 1. Do a patron search 2. Select at least 2 patrons 3. The merge patron button is enabled 4. Click select all 5. The merge patron button is still enabled 6. Apply patch and refresh browser 7. Click select alll 8. The merge patron button is not enabled anymore 9. Change the selection manually 10. Confirm the merge patron button is re-enabled Sponsored-by: CLAMS -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21555 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |blawlor@clamsnet.org |ity.org | CC| |blawlor@clamsnet.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21555 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #186304|0 |1 is obsolete| | CC| |emmi.takkinen@koha-suomi.fi --- Comment #2 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Created attachment 190771 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190771&action=edit Bug 21555: Disable merge patrons button when using select all This patch disables the merge patrons button when select all is clicked. The button is re-enabled after clicking clear all or manually changing the selection. To test: 1. Do a patron search 2. Select at least 2 patrons 3. The merge patron button is enabled 4. Click select all 5. The merge patron button is still enabled 6. Apply patch and refresh browser 7. Click select alll 8. The merge patron button is not enabled anymore 9. Change the selection manually 10. Confirm the merge patron button is re-enabled Sponsored-by: CLAMS Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21555 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #3 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Works as described. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21555 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21555 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190771|0 |1 is obsolete| | --- Comment #4 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 194392 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=194392&action=edit Bug 21555: Disable merge patrons button when using select all This patch disables the merge patrons button when select all is clicked. The button is re-enabled after clicking clear all or manually changing the selection. To test: 1. Do a patron search 2. Select at least 2 patrons 3. The merge patron button is enabled 4. Click select all 5. The merge patron button is still enabled 6. Apply patch and refresh browser 7. Click select alll 8. The merge patron button is not enabled anymore 9. Change the selection manually 10. Confirm the merge patron button is re-enabled Sponsored-by: CLAMS Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi> Signed-off-by: Laura_Escamilla <laura.escamilla@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21555 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |Laura.escamilla@bywatersolu | |tions.com QA Contact|testopia@bugs.koha-communit |Laura.escamilla@bywatersolu |y.org |tions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21555 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |26.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21555 --- Comment #5 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 26.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21555 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|26.05.00 |26.05.00,25.11.04 released in| | Status|Pushed to main |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21555 --- Comment #6 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Thanks all, pushed to 25.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21555 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting --- Comment #7 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Not backported to 25.05.x as this is an enhancement but I’m happy to revisit if needed. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org