[Bug 24949] New: Show password in staff login screen on user's demand
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24949 Bug ID: 24949 Summary: Show password in staff login screen on user's demand Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com A lot of applications allow you to see the password you typed in on demand, often requiring you to click on an "eye" symbol or similar. This would also be helpful for the staff interface to help people check for typos when trying to log into Koha. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24949 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Show password in staff |Provide password visibility |login screen on user's |toggle / icon to unmask |demand |password on staff login | |screen -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24949 Erica Rohlfs <erica.rohlfs@equinoxOLI.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alexander.borkowski@kau.se --- Comment #1 from Erica Rohlfs <erica.rohlfs@equinoxOLI.org> --- *** Bug 29247 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24949 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=34778 CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24949 --- Comment #2 from David Cook <dcook@prosentient.com.au> --- I've implemented this for the OPAC (at the request of one of my libraries) at bug 34778 Happy for someone to adapt it here as well. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24949 Alexander Borkowski <alexander.borkowski@kau.se> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|alexander.borkowski@kau.se | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24949 Lauri Hänninen <lauri.hanninen@lahti.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lauri.hanninen@lahti.fi --- Comment #3 from Lauri Hänninen <lauri.hanninen@lahti.fi> --- This feature would indeed be a welcome addition to the staff login (requested by staff). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24949 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |oleonard@myacpl.org |ity.org | Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24949 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24949 --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 184146 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184146&action=edit Bug 24949: Stylelint corrections for login.css This patch includes automated stylelint corrections for login.css. It should have no visible effect. To test, apply the patch and clear your browser cache. View the staff interface login form and confirm that everything looks correct. Sponsored-by: Athens County Public Libraries -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24949 --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 184147 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184147&action=edit Bug 24949: Provide password visibility toggle / icon to unmask password on staff login screen This patch adapts the work on Bug 34778 to the staff client, adding a "Show password" checkbox to the login form. To test, apply the batch and go to the staff client login screen. - You should see a "Show password" checkbox under the password field. - Type something in the password field. It should be masked (****). - Click the "Show password" label or check the checkbox. - The password field should now show the text you entered. - Confirm that you can log in successfully whether or not the password is visible. - `prove t/db_dependent/selenium/authentication.t` should pass. Sponsored-by: Athens County Public Libraries -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24949 Roman Dolny <roman.dolny@jezuici.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24949 Roman Dolny <roman.dolny@jezuici.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #184146|0 |1 is obsolete| | Attachment #184147|0 |1 is obsolete| | --- Comment #6 from Roman Dolny <roman.dolny@jezuici.pl> --- Created attachment 184167 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184167&action=edit Bug 24949: Stylelint corrections for login.css This patch includes automated stylelint corrections for login.css. It should have no visible effect. To test, apply the patch and clear your browser cache. View the staff interface login form and confirm that everything looks correct. Sponsored-by: Athens County Public Libraries Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24949 --- Comment #7 from Roman Dolny <roman.dolny@jezuici.pl> --- Created attachment 184168 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184168&action=edit Bug 24949: Provide password visibility toggle / icon to unmask password on staff login screen This patch adapts the work on Bug 34778 to the staff client, adding a "Show password" checkbox to the login form. To test, apply the batch and go to the staff client login screen. - You should see a "Show password" checkbox under the password field. - Type something in the password field. It should be masked (****). - Click the "Show password" label or check the checkbox. - The password field should now show the text you entered. - Confirm that you can log in successfully whether or not the password is visible. - `prove t/db_dependent/selenium/authentication.t` should pass. Sponsored-by: Athens County Public Libraries Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24949 Biblibre Sandboxes <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #184168|0 |1 is obsolete| | --- Comment #8 from Biblibre Sandboxes <sandboxes@biblibre.com> --- Created attachment 184181 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184181&action=edit Bug 24949: Provide password visibility toggle / icon to unmask password on staff login screen This patch adapts the work on Bug 34778 to the staff client, adding a "Show password" checkbox to the login form. To test, apply the batch and go to the staff client login screen. - You should see a "Show password" checkbox under the password field. - Type something in the password field. It should be masked (****). - Click the "Show password" label or check the checkbox. - The password field should now show the text you entered. - Confirm that you can log in successfully whether or not the password is visible. - `prove t/db_dependent/selenium/authentication.t` should pass. Sponsored-by: Athens County Public Libraries Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Signed-off-by: Mikko <mikko.liimatainen@turku.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24949 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |Laura.escamilla@bywatersolu | |tions.com --- Comment #9 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Hi! I'm running into this error when running the tests: Running tests (1) * Proving /kohadevbox/koha/t/db_dependent/selenium/authentication.t FAIL Selenium server did not return proper status at /usr/share/perl5/Selenium/Remote/Driver.pm line 552. # Looks like your test exited with 22 just after 1. /kohadevbox/koha/t/db_dependent/selenium/authentication.t .. Dubious, test returned 22 (wstat 5632, 0x1600) Failed 3/4 subtests Test Summary Report ------------------- /kohadevbox/koha/t/db_dependent/selenium/authentication.t (Wstat: 5632 (exited 22) Tests: 1 Failed: 0) Non-zero exit status: 22 Parse errors: Bad plan. You planned 4 tests but ran 1. Files=1, Tests=1, 1 wallclock secs ( 0.01 usr 0.00 sys + 0.90 cusr 0.11 csys = 1.02 CPU) Result: FAIL -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24949 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #10 from Owen Leonard <oleonard@myacpl.org> --- I got the same error, including in main, until I relaunched ktd with the "--selenium" flag. Then the test ran fine. Could someone try again? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24949 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24949 --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I've been waiting and hoping for this one, thanks a lot! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24949 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24949 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #184167|0 |1 is obsolete| | --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 193052 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193052&action=edit Bug 24949: Stylelint corrections for login.css This patch includes automated stylelint corrections for login.css. It should have no visible effect. To test, apply the patch and clear your browser cache. View the staff interface login form and confirm that everything looks correct. Sponsored-by: Athens County Public Libraries Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24949 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #184181|0 |1 is obsolete| | --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 193053 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193053&action=edit Bug 24949: Provide password visibility toggle / icon to unmask password on staff login screen This patch adapts the work on Bug 34778 to the staff client, adding a "Show password" checkbox to the login form. To test, apply the batch and go to the staff client login screen. - You should see a "Show password" checkbox under the password field. - Type something in the password field. It should be masked (****). - Click the "Show password" label or check the checkbox. - The password field should now show the text you entered. - Confirm that you can log in successfully whether or not the password is visible. - `prove t/db_dependent/selenium/authentication.t` should pass. Sponsored-by: Athens County Public Libraries Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Signed-off-by: Mikko <mikko.liimatainen@turku.fi> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24949 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |26.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24949 --- Comment #14 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 26.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24949 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|26.05.00 |26.05.00,25.11.04 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24949 --- Comment #15 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Thanks all, pushed to 25.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24949 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting --- Comment #16 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Not backported to 25.05.x as this is an enhancement but I’m happy to revisit if needed. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org