[Bug 24630] New: UNIMARC XSLT Update for bug 7611
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24630 Bug ID: 24630 Summary: UNIMARC XSLT Update for bug 7611 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org Add some classes and display authorized values for notforloan statuses based on work from bug 7611 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24630 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24630 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 98709 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98709&action=edit Bug 24630: UNIMARC XSLT changes for bug 7611 Follow test plan from 7611 on a UNIMARC system. These changes have not been tested by me -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24630 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |nick@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24630 didier <didier.gautheron@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |didier.gautheron@biblibre.c | |om Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24630 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24630 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98709|0 |1 is obsolete| | --- Comment #2 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 107462 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107462&action=edit Bug 24630: UNIMARC XSLT changes for bug 7611 Follow test plan from 7611 on a UNIMARC system. These changes have not been tested by me -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24630 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24630 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |7611 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7611 [Bug 7611] Show the NOT_LOAN authorised values for item status in XSLT OPAC search results -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24630 --- Comment #3 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- I start testing, looks good -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24630 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24630 --- Comment #4 from Fridolin Somers <fridolin.somers@biblibre.com> --- I see it adds callnumber with classes like in MARC21 : <span class="CallNumberAndLabel"> <span class="LabelCallNumber">Call number: </span> <span class="CallNumber"><xsl:value-of select="items:itemcallnumber"/></span> </span> This is really great for styling. But I see [] are added by CSS : .ItemSummary .LabelCallNumber:before { content:" [" } .ItemSummary .CallNumber:after { content:"]" } In this case [ disappears if you hide LabelCallNumber. Shouldn't it be : .ItemSummary .CallNumberAndLabel:before { content:" [" } .ItemSummary .CallNumberAndLabel:after { content:"]" } I'll create another bug report it confirmed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24630 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #107462|0 |1 is obsolete| | --- Comment #5 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 116578 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116578&action=edit Bug 24630: UNIMARC XSLT changes for bug 7611 Follow test plan from 7611 on a UNIMARC system. These changes have not been tested by me Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24630 --- Comment #6 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 116579 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116579&action=edit Bug 24630: (follow-up 1) fix indenting -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24630 --- Comment #7 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 116580 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116580&action=edit Bug 24630: (follow-up 2) call number when singleBranchMode=1 singleBranchMode=1 is when there is only one library (branch). Test disply of available item. Patch allows display of call number like in regular mode -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24630 --- Comment #8 from Fridolin Somers <fridolin.somers@biblibre.com> --- I've signed main patch and added 2 followups -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24630 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |severine.queune@bulac.fr -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24630 jmbroust <jean-manuel.broust@univ-lyon2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jean-manuel.broust@univ-lyo | |n2.fr -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24630 Florian <florian.bontemps@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24630 Florian <florian.bontemps@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116580|0 |1 is obsolete| | --- Comment #9 from Florian <florian.bontemps@biblibre.com> --- Created attachment 128935 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128935&action=edit Bug 24630: (follow-up 2) call number when singleBranchMode=1 singleBranchMode=1 is when there is only one library (branch). Test disply of available item. Patch allows display of call number like in regular mode Signed-off-by: Florian Bontemps <florian.bontemps@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24630 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com Status|Signed Off |Passed QA --- Comment #10 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- No UNIMARC user in the QA team, trusting author and testers. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24630 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24630 --- Comment #11 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24630 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24630 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=26302 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org