[Bug 26302] New: OPAC XSLT Results: List variable number of itemcallnumbers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26302 Bug ID: 26302 Summary: OPAC XSLT Results: List variable number of itemcallnumbers Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: m.de.rooy@rijksmuseum.nl QA Contact: testopia@bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26302 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|oleonard@myacpl.org |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26302 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |21260 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21260 [Bug 21260] Improve the Availability line of OPAC XSLT search results -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26302 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26302 --- Comment #1 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 109184 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109184&action=edit Bug 26302: OPAC XSLT Results: List variable number of itemcallnumbers We define a local preference resultsMaxItems and add it to the xml passed to the results XSLT (in C4::XSLT). Instead of showing one item, we add this number of items for the available for loan and reference segments. Test plan: Play with the value of local pref resultsMaxItems. Check if it matches with displayed callnumbers. Try home and holdingbranch for results location. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26302 Ella <ellawipatene@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ellawipatene@gmail.com --- Comment #2 from Ella <ellawipatene@gmail.com> --- I do not see that preference, can you please tell me where to find it? Thanks -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26302 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I believe you are supposed to add one yourself in the "local use" tab, but I am not sure where this patch is headed with that approach. Marcel, can you please explain? There seems to be no other linked bugs to take this further. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26302 --- Comment #4 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Ella from comment #2)
I do not see that preference, can you please tell me where to find it? Thanks
Sorry, it is a local preference. Note the Local tab in the Preferences section under Administration. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26302 --- Comment #5 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Katrin Fischer from comment #3)
I believe you are supposed to add one yourself in the "local use" tab, but I am not sure where this patch is headed with that approach. Marcel, can you please explain? There seems to be no other linked bugs to take this further.
Depending on further feedback and consensus, it will be rather easy to promote this to an official preference. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26302 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109184|0 |1 is obsolete| | --- Comment #6 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 119108 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119108&action=edit Bug 26302: OPAC XSLT Results: List variable number of itemcallnumbers We define a local preference resultsMaxItems and add it to the xml passed to the results XSLT (in C4::XSLT). Instead of showing one item, we add this number of items for the available for loan and reference segments. Test plan: Play with the value of local pref resultsMaxItems. Check if it matches with displayed callnumbers. Try home and holdingbranch for results location. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26302 --- Comment #7 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 119109 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119109&action=edit Bug 26302: Add syspref resultsMaxItemsUnavailable This is the number of call numbers displayed for unavailable categories in the results XSLT. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26302 --- Comment #8 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 119110 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119110&action=edit Bug 26302: Use resultsMaxItemsUnavailable in stylesheet We start here with Checked out until On hold. Not sure if we should do exactly the same for the remaining not for loan categories. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26302 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |Allows customizing the release notes| |number of call numbers | |listed on the OPAC search | |results by changing the | |prefs: | |resultsMaxItems | |resultsMaxItemsUnavailable | |The latter now applies to | |the categories Checked out, | |Damaged, ..., On hold. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26302 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com, | |nick@bywatersolutions.com --- Comment #9 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- @Nick: Would this address your concerns about hiding call numbers for certain unavailable categories? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26302 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #119110|0 |1 is obsolete| | --- Comment #10 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Comment on attachment 119110 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119110 Bug 26302: Use resultsMaxItemsUnavailable in stylesheet Resubmitting.. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26302 --- Comment #11 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 119111 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119111&action=edit Bug 26302: Use resultsMaxItemsUnavailable in stylesheet We start here with Checked out until On hold. Not sure if we should do exactly the same for the remaining not for loan categories. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26302 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #119108|0 |1 is obsolete| | --- Comment #12 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 122386 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122386&action=edit Bug 26302: OPAC XSLT Results: List variable number of itemcallnumbers We define a local preference resultsMaxItems and add it to the xml passed to the results XSLT (in C4::XSLT). Instead of showing one item, we add this number of items for the available for loan and reference segments. Test plan: Play with the value of local pref resultsMaxItems. Check if it matches with displayed callnumbers. Try home and holdingbranch for results location. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26302 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #119109|0 |1 is obsolete| | --- Comment #13 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 122387 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122387&action=edit Bug 26302: Add syspref resultsMaxItemsUnavailable This is the number of call numbers displayed for unavailable categories in the results XSLT. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26302 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #119111|0 |1 is obsolete| | --- Comment #14 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 122388 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122388&action=edit Bug 26302: Use resultsMaxItemsUnavailable in stylesheet We start here with Checked out until On hold. Not sure if we should do exactly the same for the remaining not for loan categories. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26302 --- Comment #15 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 122389 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122389&action=edit Bug 26302: Add dbrev for two new prefs Formalizing the local prefs introduced in the former patches: resultsMaxItems resultsMaxItemsUnavailable Test plan: Check Preferences/OPAC/Appearance. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26302 --- Comment #16 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 122391 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122391&action=edit Bug 26302: Apply resultsMaxItemsUnavailable to the NFLs too Test plan: Add some not for loan categories, add some items for them. Check search results. Verify that results match expectation. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Tested the combination of pref values for results 2/1 with NFL categories TEST, MOVING: Availability: Items available for loan: Centerville (3) [Call number: PERL A 2, PERL A 3, ...] Items available for reference: Centerville Staff Collection (1) [Call number: PERL A 10]. Not available: TEST (2) [ PERL A 11, .. ]. MOVING (1) [ PERL A 13 ]. Withdrawn (2) [ PERL A 5, .. ]. Damaged (3) [ PERL A 7, .. ]. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26302 --- Comment #17 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Marcel de Rooy from comment #11)
We start here with Checked out until On hold. Not sure if we should do exactly the same for the remaining not for loan categories.
Note that the last patch now fills that gap. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26302 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26302 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122386|0 |1 is obsolete| | --- Comment #18 from David Nind <david@davidnind.com> --- Created attachment 122462 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122462&action=edit Bug 26302: OPAC XSLT Results: List variable number of itemcallnumbers We define a local preference resultsMaxItems and add it to the xml passed to the results XSLT (in C4::XSLT). Instead of showing one item, we add this number of items for the available for loan and reference segments. Test plan: Play with the value of local pref resultsMaxItems. Check if it matches with displayed callnumbers. Try home and holdingbranch for results location. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26302 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122387|0 |1 is obsolete| | --- Comment #19 from David Nind <david@davidnind.com> --- Created attachment 122463 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122463&action=edit Bug 26302: Add syspref resultsMaxItemsUnavailable This is the number of call numbers displayed for unavailable categories in the results XSLT. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26302 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122388|0 |1 is obsolete| | --- Comment #20 from David Nind <david@davidnind.com> --- Created attachment 122464 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122464&action=edit Bug 26302: Use resultsMaxItemsUnavailable in stylesheet We start here with Checked out until On hold. Not sure if we should do exactly the same for the remaining not for loan categories. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26302 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122389|0 |1 is obsolete| | --- Comment #21 from David Nind <david@davidnind.com> --- Created attachment 122465 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122465&action=edit Bug 26302: Add dbrev for two new prefs Formalizing the local prefs introduced in the former patches: resultsMaxItems resultsMaxItemsUnavailable Test plan: Check Preferences/OPAC/Appearance. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26302 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122391|0 |1 is obsolete| | --- Comment #22 from David Nind <david@davidnind.com> --- Created attachment 122466 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122466&action=edit Bug 26302: Apply resultsMaxItemsUnavailable to the NFLs too Test plan: Add some not for loan categories, add some items for them. Check search results. Verify that results match expectation. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Tested the combination of pref values for results 2/1 with NFL categories TEST, MOVING: Availability: Items available for loan: Centerville (3) [Call number: PERL A 2, PERL A 3, ...] Items available for reference: Centerville Staff Collection (1) [Call number: PERL A 10]. Not available: TEST (2) [ PERL A 11, .. ]. MOVING (1) [ PERL A 13 ]. Withdrawn (2) [ PERL A 5, .. ]. Damaged (3) [ PERL A 7, .. ]. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26302 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #23 from David Nind <david@davidnind.com> --- Testing notes (using koha-testing-docker): Revised test plan: 1. Setup records and items to test: . Have records with multiple items and call numbers (one with 20 items and one with 50) that will appear in the OPAC results using the same keyword (use 'Add multiple copies of this item' option at the bottom of the add item form to bulk add multiple items). . Make sure (using batch item editing) that there are a mix of libraries, not for loan categories, call numbers, and damaged status' . As a bonus, add some additional not for loan categories (Administration > Basic parameters > Authorized values), such as 'Not for Loan' and 'Staff Collection' . Check out some items to patrons 2. Confirm the current behavour when searching in the OPAC (see the example at the end): . The first call number per branch is displayed under availablility in the results (for items available for loan and items available for reference) . Where there are multiple call numbers for an item, "..." is used to indicate more call numbers . For items not available, such as damaged: no call numbers are displayed. 3. Apply the patch 4. Update the database (updatedatabase when using koha-testing-docker) 5. Run flush_memcached and restart_all (when using koha-testing-docker) 6. Without changing the default values for the new system preferences, check that the current behavour still works (as per step 2). Note: the default setting is to display 2 call numbers for items available (only 1 was displayed before) and 1 call number for items not available (no call numbers were displayed before). 7. Experiment with different values for the new system preferences (for example 10 for resultsMaxItems and 0 for resultsMaxItemsUnavailable): . resultsMaxItems - Maximum number of available items displayed in search results . resultsMaxItemsUnavailable - Maximum number of unavailable items displayed in search results 8. Confirm that the correct number of call numbers are displayed. 9. Sign off! Example ------- Before patch applied: ~~~~~~~~~~~~~~~~~~~~~ Availability: Items available for loan: Centerville (16) Call number: PERL A1, .., Fairview (1) Call number: PERL A1, Franklin (7) Call number: PERL B2, .., Midway (9) Call number: 560.897 ZAK, .., Springfield (6) Call number: 965.009 PLO, ... Items available for reference: Fairview Not For Loan (1) Call number: PERL A1, Franklin Not For Loan (1) Call number: PERL B2, Midway Not For Loan (2) Call number: 560.897 ZAK, .., Centerville Not For Loan (1) Call number: PERL B2, Springfield Not For Loan (3) Call number: 965.009 PLO, ... Not available: Damaged (7). Patch applied: ~~~~~~~~~~~~~~ Availability: Items available for loan: Centerville (16) Call number: PERL A1, PERL A1, .., Fairview (1) Call number: PERL A1, PERL A1, Franklin (7) Call number: PERL A1, PERL A1, .., Midway (9) Call number: PERL A1, PERL A1, .., Springfield (6) Call number: PERL A1, PERL A1, ... Items available for reference: Fairview Not For Loan (1) Call number: PERL A1, PERL B2, Franklin Not For Loan (1) Call number: PERL A1, PERL B2, Midway Not For Loan (2) Call number: PERL A1, PERL B2, Centerville Not For Loan (1) Call number: PERL A1, PERL B2, Springfield Not For Loan (3) Call number: PERL A1, PERL B2, ... Not available: Damaged (7) [ PERL A1, .. ]. Note differences: - Default number of call numbers peated for items available for loan (before patch was applied they didn't), - Not available items didn't originally dispaly Call numbers for Damaged Different values ~~~~~~~~~~~~~~~~ Results with: - resultsMaxItems: 10 - resultsMaxItemsUnavailable: 0 Availability: Items available for loan: Centerville (16) Call number: PERL A1, PERL A1, PERL B2, PERL B2, PERL B2, PERL B2, PERL B2, PERL B2, PERL B2, 560.897 ZAK, .., Fairview (1) Call number: PERL A1, PERL A1, PERL B2, PERL B2, PERL B2, PERL B2, PERL B2, PERL B2, PERL B2, 560.897 ZAK, Franklin (7) Call number: PERL A1, PERL A1, PERL B2, PERL B2, PERL B2, PERL B2, PERL B2, PERL B2, PERL B2, 560.897 ZAK, Midway (9) Call number: PERL A1, PERL A1, PERL B2, PERL B2, PERL B2, PERL B2, PERL B2, PERL B2, PERL B2, 560.897 ZAK, Springfield (6) Call number: PERL A1, PERL A1, PERL B2, PERL B2, PERL B2, PERL B2, PERL B2, PERL B2, PERL B2, 560.897 ZAK. Items available for reference: Fairview Not For Loan (1) Call number: PERL A1, PERL B2, 560.897 ZAK, 560.897 ZAK, PERL B2, 965.009 PLO, 965.009 PLO, 965.009 PLO, Franklin Not For Loan (1) Call number: PERL A1, PERL B2, 560.897 ZAK, 560.897 ZAK, PERL B2, 965.009 PLO, 965.009 PLO, 965.009 PLO, Midway Not For Loan (2) Call number: PERL A1, PERL B2, 560.897 ZAK, 560.897 ZAK, PERL B2, 965.009 PLO, 965.009 PLO, 965.009 PLO, Centerville Not For Loan (1) Call number: PERL A1, PERL B2, 560.897 ZAK, 560.897 ZAK, PERL B2, 965.009 PLO, 965.009 PLO, 965.009 PLO, Springfield Not For Loan (3) Call number: PERL A1, PERL B2, 560.897 ZAK, 560.897 ZAK, PERL B2, 965.009 PLO, 965.009 PLO, 965.009 PLO. Not available: Damaged (7). Results with: - resultsMaxItems: 1 - resultsMaxItemsUnavailable: 0 Availability: Items available for loan: Centerville (16) Call number: PERL A1, .., Fairview (1) Call number: PERL A1, Franklin (7) Call number: PERL A1, .., Midway (9) Call number: PERL A1, .., Springfield (6) Call number: PERL A1, ... Items available for reference: Fairview Not For Loan (1) Call number: PERL A1, Franklin Not For Loan (1) Call number: PERL A1, Midway Not For Loan (2) Call number: PERL A1, .., Centerville Not For Loan (1) Call number: PERL A1, Springfield Not For Loan (3) Call number: PERL A1, ... Not available: Damaged (7). Results with: - resultsMaxItems: 0 - resultsMaxItemsUnavailable: 0 Availability: Items available for loan: Centerville (16) Call number: PERL A1, .., Franklin (7) Call number: PERL A1, .., Midway (9) Call number: PERL A1, .., Springfield (6) Call number: PERL A1, ... Items available for reference: Fairview Not For Loan (1) Call number: PERL A1, Franklin Not For Loan (1) Call number: PERL A1, Midway Not For Loan (2) Call number: PERL A1, .., Centerville Not For Loan (1) Call number: PERL A1, Springfield Not For Loan (3) Call number: PERL A1, ... Not available: Checked out (1). Damaged (7). Note: no change from setting to 1 and 0 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26302 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|Allows customizing the |This enhancement allows release notes|number of call numbers |customizing the number of |listed on the OPAC search |call numbers displayed for |results by changing the |OPAC search results for |prefs: |items available and not |resultsMaxItems |available by changing two |resultsMaxItemsUnavailable |new system preferences: |The latter now applies to |- |the categories Checked out, |resultsMaxItems: maximum |Damaged, ..., On hold. |number of available items | |displayed in search results | |(default = 2) | |- | |resultsMaxItemsUnavailable | |- maximum number of | |unavailable items displayed | |in search results (such as | |when checked out and | |damaged) (default = 1) | | | |This is useful when records | |have a large number of | |items, for example larger | |libraries with many | |branches, union catalogues, | |and university libraries | |with course text books. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26302 --- Comment #24 from David Nind <david@davidnind.com> --- A couple of things I noted: 1. Should the call number be repeated if it is the same? That is, should only distinct call numbers be displayed for items available by library branch or not available categories? 2. Should using 0 for resultsMaxItems suppress the display of call numbers? That is the behavour when resultsMaxItemsUnavailable is 0. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26302 --- Comment #25 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to David Nind from comment #24)
A couple of things I noted:
1. Should the call number be repeated if it is the same? That is, should only distinct call numbers be displayed for items available by library branch or not available categories?
2. Should using 0 for resultsMaxItems suppress the display of call numbers? That is the behavour when resultsMaxItemsUnavailable is 0.
Thx for testing, David! Great comments. Will be looking further shortly. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26302 --- Comment #26 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- David, This is the culprit: $sp ||= 1 if $syspref eq 'resultsMaxItems'; # needs default A zero becomes a 1 here. We should probably test for defined here with //. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26302 --- Comment #27 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 122487 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122487&action=edit Bug 26302: (follow-up) Handle zero callnumbers-case As David observed while testing, we should differentiate between the pref value 1 and 0 (or undef). This patch does no longer convert the value to 1 as default. And it removes an empty [ Call number: ] suffix. Test plan: Set resultsMaxItems or ..Unavailable to zero and check search results. Verify that you see something like: Availability: Items available for loan: Centerville (3) . Items available for reference: Centerville Staff Collection (1) . Not available: TEST (2). MOVING (1). Withdrawn (2). Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26302 --- Comment #28 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to David Nind from comment #24)
1. Should the call number be repeated if it is the same? That is, should only distinct call numbers be displayed for items available by library branch or not available categories?
This is far from trivially adding a distinct keyword. We are relying here on the output of the xslt key function. Making this change would require a bit more than we are doing here now to control the number displayed.
2. Should using 0 for resultsMaxItems suppress the display of call numbers? That is the behavour when resultsMaxItemsUnavailable is 0.
The follow-up now resolves this. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26302 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #29 from Nick Clemens <nick@bywatersolutions.com> --- I am seeing the same callnumbers for every branch, to recreate: 1 - sudo koha-mysql kohadev 2 - UPDATE items SET itemcallnumber=barcode; 3 - Add 5 items for a single branch (IPT) with IPT1-5 as barcodes and "IPT" as item callnumber 4 - Display in opac: Availability: Items available for loan: Midway (1) Call number: 39999000013351, 39999000013375, 39999000013399, Centerville (3) Call number: 39999000013351, 39999000013375, 39999000013399, Fairview (1) Call number: 39999000013351, 39999000013375, 39999000013399, Institut Protestant de Théologie (5) Call number: 39999000013351, 39999000013375, 39999000013399, ... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26302 --- Comment #30 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Nick Clemens from comment #29)
I am seeing the same callnumbers for every branch, to recreate: 1 - sudo koha-mysql kohadev 2 - UPDATE items SET itemcallnumber=barcode; 3 - Add 5 items for a single branch (IPT) with IPT1-5 as barcodes and "IPT" as item callnumber 4 - Display in opac: Availability: Items available for loan: Midway (1) Call number: 39999000013351, 39999000013375, 39999000013399, Centerville (3) Call number: 39999000013351, 39999000013375, 39999000013399, Fairview (1) Call number: 39999000013351, 39999000013375, 39999000013399, Institut Protestant de Théologie (5) Call number: 39999000013351, 39999000013375, 39999000013399, ...
Thx for testing, Nick. Will have another look -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26302 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26302 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122462|0 |1 is obsolete| | Attachment #122463|0 |1 is obsolete| | Attachment #122464|0 |1 is obsolete| | Attachment #122465|0 |1 is obsolete| | Attachment #122466|0 |1 is obsolete| | Attachment #122487|0 |1 is obsolete| | --- Comment #31 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 123499 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123499&action=edit Bug 26302: Add dbrev for two new prefs Adding two prefs: resultsMaxItems resultsMaxItemsUnavailable Test plan: Check Preferences/OPAC/Appearance. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26302 --- Comment #32 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 123500 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123500&action=edit Bug 26302: Add resultbranch and other status in C4/XSLT Groundwork for changes in the OPAC results xslt. NOTE: Adds both new prefs too. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26302 --- Comment #33 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 123501 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123501&action=edit Bug 26302: Changes for substatus, resultbranch in XSLT.t Test plan: Run t/db_dependent/XSLT.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26302 --- Comment #34 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 123502 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123502&action=edit Bug 26302: Refactor Availability block in OPAC results xslt Decided finally to do a larger refactor here. Hopefully we improved consistency and removed some redundancy. And the two new prefs provide additional functionality. Most significant changes: [1] Clearer distinction of the Availability line in three parts: Available, Reference and Unavailable. For Unavailable we loop thru branches now too. [2] Calling template to list item data (including location or ccode). Made the separate Location line obsolete. [3] The tests around OPACItemLibrary are removed since we now look at resultbranch from XSLT.pm. [4] Removed code replication for various 'other' statuses like Checked out. [5] Obsoleted three xslt key indexes, singleBranchMode. [6] Apply the two prefs to control number of listed items. Test plan: You may play with: OPACResultsLibrary (home/holding), OPACItemLocation (library, callno, location, ccode), resultsMaxItems[Unavailable] (numbers), Reference_NFL_Statuses (list of notforloan codes in reference part). [1] Create a biblio with various items on a few branches. Fill call number, location and ccode too. Set home branch and holdingbranch differently. [2] Toggle the preferences, and verify display within OAPC search results. Example with prefs (home, callnumber, 2, 2): Availability: Items available for loan: Centerville (2)Call number: perl A 4, PERL D 1. Items available for reference: Fairfield: Not For Loan (1)Call number: PERL A 5. Not available: Centerville: Checked out (1)Call number: PERL A 3. Centerville: Ordered (1)Call number: PERL B 1. Centerville: Staff Collection (2)Call number: PERL A 2, PERL E 1. Centerville: Withdrawn (1)Call number: PERL B 2. Fairfield: Withdrawn (1)Call number: PERL C 1. Same data with prefs (holding, callnumber, 2, 2): Availability: Items available for loan: Centerville (1)Call number: PERL D 1. Liberty (1)Call number: perl A 4. Items available for reference: Centerville: Not For Loan (1)Call number: PERL A 5. Not available: Centerville: Checked out (1)Call number: PERL A 3. Centerville: Staff Collection (1)Call number: PERL A 2. Centerville: Withdrawn (1)Call number: PERL B 2. Fairfield: Ordered (1)Call number: PERL B 1. Fairfield: Withdrawn (1)Call number: PERL C 1. Liberty: Staff Collection (1)Call number: PERL E 1. Same data with prefs (holding, library, n/a, n/a): Availability: Items available for loan: Centerville (1). Liberty (1). Items available for reference: Centerville: Not For Loan (1). Not available: Centerville: Checked out (1). Centerville: Staff Collection (1). Centerville: Withdrawn (1). Fairfield: Ordered (1). Fairfield: Withdrawn (1). Liberty: Staff Collection (1). Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26302 --- Comment #35 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- .../en/xslt/MARC21slim2OPACResults.xsl | 383 +++++++----------- 1 file changed, 144 insertions(+), 239 deletions(-) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26302 --- Comment #36 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- David, would you mind to test this change again? Hopefully, Nick could pick it up after that :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26302 --- Comment #37 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Marcel de Rooy from comment #28)
(In reply to David Nind from comment #24)
1. Should the call number be repeated if it is the same? That is, should only distinct call numbers be displayed for items available by library branch or not available categories?
This is far from trivially adding a distinct keyword. We are relying here on the output of the xslt key function. Making this change would require a bit more than we are doing here now to control the number displayed.
Looking back, I must have misinterpreted this comment. ;) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26302 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26302 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123499|0 |1 is obsolete| | Attachment #123500|0 |1 is obsolete| | Attachment #123501|0 |1 is obsolete| | Attachment #123502|0 |1 is obsolete| | --- Comment #38 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 123526 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123526&action=edit Bug 26302: Add dbrev for two new prefs Adding two prefs: resultsMaxItems resultsMaxItemsUnavailable Test plan: Check Preferences/OPAC/Appearance. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26302 --- Comment #39 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 123527 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123527&action=edit Bug 26302: Add resultbranch and other status in C4/XSLT Groundwork for changes in the OPAC results xslt. NOTE: Adds both new prefs too. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26302 --- Comment #40 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 123528 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123528&action=edit Bug 26302: Changes for substatus, resultbranch in XSLT.t Test plan: Run t/db_dependent/XSLT.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26302 --- Comment #41 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 123529 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123529&action=edit Bug 26302: Refactor Availability block in OPAC results xslt Decided finally to do a larger refactor here. Hopefully we improved consistency and removed some redundancy. And the two new prefs provide additional functionality. Most significant changes: [1] Clearer distinction of the Availability line in three parts: Available, Reference and Unavailable. For Unavailable we loop thru branches now too. [2] Calling template to list item data (including location or ccode). Made the separate Location line obsolete. [3] The tests around OPACItemLibrary are removed since we now look at resultbranch from XSLT.pm. [4] Removed code replication for various 'other' statuses like Checked out. [5] Obsoleted three xslt key indexes, singleBranchMode. [6] Apply the two prefs to control number of listed items. Test plan: You may play with: OPACResultsLibrary (home/holding), OPACItemLocation (library, callno, location, ccode), resultsMaxItems[Unavailable] (numbers), Reference_NFL_Statuses (list of notforloan codes in reference part). [1] Create a biblio with various items on a few branches. Fill call number, location and ccode too. Set home branch and holdingbranch differently. [2] Toggle the preferences, and verify display within OAPC search results. Example with prefs (home, callnumber, 2, 2): Availability: Items available for loan: Centerville (2)Call number: perl A 4, PERL D 1. Items available for reference: Fairfield: Not For Loan (1)Call number: PERL A 5. Not available: Centerville: Checked out (1)Call number: PERL A 3. Centerville: Ordered (1)Call number: PERL B 1. Centerville: Staff Collection (2)Call number: PERL A 2, PERL E 1. Centerville: Withdrawn (1)Call number: PERL B 2. Fairfield: Withdrawn (1)Call number: PERL C 1. Same data with prefs (holding, callnumber, 2, 2): Availability: Items available for loan: Centerville (1)Call number: PERL D 1. Liberty (1)Call number: perl A 4. Items available for reference: Centerville: Not For Loan (1)Call number: PERL A 5. Not available: Centerville: Checked out (1)Call number: PERL A 3. Centerville: Staff Collection (1)Call number: PERL A 2. Centerville: Withdrawn (1)Call number: PERL B 2. Fairfield: Ordered (1)Call number: PERL B 1. Fairfield: Withdrawn (1)Call number: PERL C 1. Liberty: Staff Collection (1)Call number: PERL E 1. Same data with prefs (holding, library, n/a, n/a): Availability: Items available for loan: Centerville (1). Liberty (1). Items available for reference: Centerville: Not For Loan (1). Not available: Centerville: Checked out (1). Centerville: Staff Collection (1). Centerville: Withdrawn (1). Fairfield: Ordered (1). Fairfield: Withdrawn (1). Liberty: Staff Collection (1). Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26302 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123526|0 |1 is obsolete| | --- Comment #42 from David Nind <david@davidnind.com> --- Created attachment 123531 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123531&action=edit Bug 26302: Add dbrev for two new prefs Adding two prefs: resultsMaxItems resultsMaxItemsUnavailable Test plan: Check Preferences/OPAC/Appearance. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26302 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123527|0 |1 is obsolete| | --- Comment #43 from David Nind <david@davidnind.com> --- Created attachment 123532 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123532&action=edit Bug 26302: Add resultbranch and other status in C4/XSLT Groundwork for changes in the OPAC results xslt. NOTE: Adds both new prefs too. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26302 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123528|0 |1 is obsolete| | --- Comment #44 from David Nind <david@davidnind.com> --- Created attachment 123533 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123533&action=edit Bug 26302: Changes for substatus, resultbranch in XSLT.t Test plan: Run t/db_dependent/XSLT.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26302 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123529|0 |1 is obsolete| | --- Comment #45 from David Nind <david@davidnind.com> --- Created attachment 123534 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123534&action=edit Bug 26302: Refactor Availability block in OPAC results xslt Decided finally to do a larger refactor here. Hopefully we improved consistency and removed some redundancy. And the two new prefs provide additional functionality. Most significant changes: [1] Clearer distinction of the Availability line in three parts: Available, Reference and Unavailable. For Unavailable we loop thru branches now too. [2] Calling template to list item data (including location or ccode). Made the separate Location line obsolete. [3] The tests around OPACItemLibrary are removed since we now look at resultbranch from XSLT.pm. [4] Removed code replication for various 'other' statuses like Checked out. [5] Obsoleted three xslt key indexes, singleBranchMode. [6] Apply the two prefs to control number of listed items. Test plan: You may play with: OPACResultsLibrary (home/holding), OPACItemLocation (library, callno, location, ccode), resultsMaxItems[Unavailable] (numbers), Reference_NFL_Statuses (list of notforloan codes in reference part). [1] Create a biblio with various items on a few branches. Fill call number, location and ccode too. Set home branch and holdingbranch differently. [2] Toggle the preferences, and verify display within OAPC search results. Example with prefs (home, callnumber, 2, 2): Availability: Items available for loan: Centerville (2)Call number: perl A 4, PERL D 1. Items available for reference: Fairfield: Not For Loan (1)Call number: PERL A 5. Not available: Centerville: Checked out (1)Call number: PERL A 3. Centerville: Ordered (1)Call number: PERL B 1. Centerville: Staff Collection (2)Call number: PERL A 2, PERL E 1. Centerville: Withdrawn (1)Call number: PERL B 2. Fairfield: Withdrawn (1)Call number: PERL C 1. Same data with prefs (holding, callnumber, 2, 2): Availability: Items available for loan: Centerville (1)Call number: PERL D 1. Liberty (1)Call number: perl A 4. Items available for reference: Centerville: Not For Loan (1)Call number: PERL A 5. Not available: Centerville: Checked out (1)Call number: PERL A 3. Centerville: Staff Collection (1)Call number: PERL A 2. Centerville: Withdrawn (1)Call number: PERL B 2. Fairfield: Ordered (1)Call number: PERL B 1. Fairfield: Withdrawn (1)Call number: PERL C 1. Liberty: Staff Collection (1)Call number: PERL E 1. Same data with prefs (holding, library, n/a, n/a): Availability: Items available for loan: Centerville (1). Liberty (1). Items available for reference: Centerville: Not For Loan (1). Not available: Centerville: Checked out (1). Centerville: Staff Collection (1). Centerville: Withdrawn (1). Fairfield: Ordered (1). Fairfield: Withdrawn (1). Liberty: Staff Collection (1). Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26302 --- Comment #46 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> ---
Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: David Nind <david@davidnind.com>
Great. Thx Owen and David ! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26302 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #47 from Nick Clemens <nick@bywatersolutions.com> --- Overall this looks good, a few things: 1 - We should default the prefs to 1,0 to more closely mimic the behavior before 2 - Items with blank callnumbers now show: [Call number: ], before they only showed the count 3 - Not blocker: it would be nice to have a '-1' option for resultsMaxItemsUnavailable to preserve previous grouping - in large consortia I know they have not wanted to display individual NFL items Before: Availability: Items available for loan: Fairview (2) , Midway (1) , Union (1) Call number: J Qam. Items available for reference: Riverside Not For Loan (2) Call number: J Qam, .., Pleasant Valley Staff Collection (1) Call number: YA 615 Qam, Fairfield Not For Loan (1) Call number: FIC Qam. Not available: Ordered (3). Checked out (1). After: Availability: Items available for loan: Fairview (2)Call number: , . Midway (1)Call number: . Union (1)Call number: J Qam. Items available for reference: Fairfield: Not For Loan (1)Call number: FIC Qam. Pleasant Valley: Staff Collection (1)Call number: YA 615 Qam. Riverside: Not For Loan (2)Call number: J Qam, YA 667 Qam. Not available: Fairview: Checked out (1)Call number: . Franklin: Ordered (1)Call number: YA Qam. Midway: Ordered (1)Call number: J 301 Qam. Springfield: Ordered (1)Call number: FIC 354 Qam. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26302 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26302 --- Comment #48 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 123640 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123640&action=edit Bug 26302: (QA follow-up) Reset preference values Mimic current behavior. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26302 --- Comment #49 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 123641 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123641&action=edit Bug 26302: (QA follow-up) Prevent empty call numbers This does not make the code easier, but here we go: Suppose resultsMaxItems == 2. If we would normally list two call numbers like: Liberty (2) [Call number: PERL F 1, PERL F 2]. If one call number would be empty, we now list: Liberty (2) [Call number: PERL F 1, ...]. And when both are empty, we only show a number: Liberty (2). Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26302 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This enhancement allows |This enhancement allows release notes|customizing the number of |customizing the number of |call numbers displayed for |call numbers displayed for |OPAC search results for |OPAC search results for |items available and not |items available and not |available by changing two |available by changing two |new system preferences: |new system preferences: |- |- |resultsMaxItems: maximum |resultsMaxItems: maximum |number of available items |number of available items |displayed in search results |displayed in search results |(default = 2) |(default = 1) |- |- |resultsMaxItemsUnavailable |resultsMaxItemsUnavailable |- maximum number of |- maximum number of |unavailable items displayed |unavailable items displayed |in search results (such as |in search results (such as |when checked out and |when checked out and |damaged) (default = 1) |damaged) (default = 0) | | |This is useful when records |This is useful when records |have a large number of |have a large number of |items, for example larger |items, for example larger |libraries with many |libraries with many |branches, union catalogues, |branches, union catalogues, |and university libraries |and university libraries |with course text books. |with course text books. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26302 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28831 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28831 [Bug 28831] Results XSLT: Allow unavailable item grouping on status only for large consortia -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26302 --- Comment #50 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Nick Clemens from comment #47) Thx
1 - We should default the prefs to 1,0 to more closely mimic the behavior before
Fixed in patch/follow-up 5
2 - Items with blank callnumbers now show: [Call number: ], before they only showed the count
Fixed in patch/follow-up 6
3 - Not blocker: it would be nice to have a '-1' option for resultsMaxItemsUnavailable to preserve previous grouping - in large consortia I know they have not wanted to display individual NFL items
Yeah can imagine. Willing to add it on a new report. Not here anymore. Bug 28831 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26302 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123641|0 |1 is obsolete| | --- Comment #51 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 123643 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123643&action=edit Bug 26302: (QA follow-up) Prevent empty call numbers This does not make the code easier, but here we go: Suppose resultsMaxItems == 2. If we would normally list two call numbers like: Liberty (2) [Call number: PERL F 1, PERL F 2]. If one call number would be empty, we now list: Liberty (2) [Call number: PERL F 1, ...]. And when both are empty, we only show a number: Liberty (2). Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26302 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26302 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123531|0 |1 is obsolete| | Attachment #123532|0 |1 is obsolete| | Attachment #123533|0 |1 is obsolete| | Attachment #123534|0 |1 is obsolete| | Attachment #123640|0 |1 is obsolete| | Attachment #123643|0 |1 is obsolete| | --- Comment #52 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 123644 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123644&action=edit Bug 26302: Add dbrev for two new prefs Adding two prefs: resultsMaxItems resultsMaxItemsUnavailable Test plan: Check Preferences/OPAC/Appearance. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26302 --- Comment #53 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 123645 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123645&action=edit Bug 26302: Add resultbranch and other status in C4/XSLT Groundwork for changes in the OPAC results xslt. NOTE: Adds both new prefs too. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26302 --- Comment #54 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 123646 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123646&action=edit Bug 26302: Changes for substatus, resultbranch in XSLT.t Test plan: Run t/db_dependent/XSLT.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26302 --- Comment #55 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 123647 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123647&action=edit Bug 26302: Refactor Availability block in OPAC results xslt Decided finally to do a larger refactor here. Hopefully we improved consistency and removed some redundancy. And the two new prefs provide additional functionality. Most significant changes: [1] Clearer distinction of the Availability line in three parts: Available, Reference and Unavailable. For Unavailable we loop thru branches now too. [2] Calling template to list item data (including location or ccode). Made the separate Location line obsolete. [3] The tests around OPACItemLibrary are removed since we now look at resultbranch from XSLT.pm. [4] Removed code replication for various 'other' statuses like Checked out. [5] Obsoleted three xslt key indexes, singleBranchMode. [6] Apply the two prefs to control number of listed items. Test plan: You may play with: OPACResultsLibrary (home/holding), OPACItemLocation (library, callno, location, ccode), resultsMaxItems[Unavailable] (numbers), Reference_NFL_Statuses (list of notforloan codes in reference part). [1] Create a biblio with various items on a few branches. Fill call number, location and ccode too. Set home branch and holdingbranch differently. [2] Toggle the preferences, and verify display within OAPC search results. Example with prefs (home, callnumber, 2, 2): Availability: Items available for loan: Centerville (2)Call number: perl A 4, PERL D 1. Items available for reference: Fairfield: Not For Loan (1)Call number: PERL A 5. Not available: Centerville: Checked out (1)Call number: PERL A 3. Centerville: Ordered (1)Call number: PERL B 1. Centerville: Staff Collection (2)Call number: PERL A 2, PERL E 1. Centerville: Withdrawn (1)Call number: PERL B 2. Fairfield: Withdrawn (1)Call number: PERL C 1. Same data with prefs (holding, callnumber, 2, 2): Availability: Items available for loan: Centerville (1)Call number: PERL D 1. Liberty (1)Call number: perl A 4. Items available for reference: Centerville: Not For Loan (1)Call number: PERL A 5. Not available: Centerville: Checked out (1)Call number: PERL A 3. Centerville: Staff Collection (1)Call number: PERL A 2. Centerville: Withdrawn (1)Call number: PERL B 2. Fairfield: Ordered (1)Call number: PERL B 1. Fairfield: Withdrawn (1)Call number: PERL C 1. Liberty: Staff Collection (1)Call number: PERL E 1. Same data with prefs (holding, library, n/a, n/a): Availability: Items available for loan: Centerville (1). Liberty (1). Items available for reference: Centerville: Not For Loan (1). Not available: Centerville: Checked out (1). Centerville: Staff Collection (1). Centerville: Withdrawn (1). Fairfield: Ordered (1). Fairfield: Withdrawn (1). Liberty: Staff Collection (1). Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26302 --- Comment #56 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 123648 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123648&action=edit Bug 26302: (QA follow-up) Reset preference values Mimic current behavior. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26302 --- Comment #57 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 123649 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123649&action=edit Bug 26302: (QA follow-up) Prevent empty call numbers This does not make the code easier, but here we go: Suppose resultsMaxItems == 2. If we would normally list two call numbers like: Liberty (2) [Call number: PERL F 1, PERL F 2]. If one call number would be empty, we now list: Liberty (2) [Call number: PERL F 1, ...]. And when both are empty, we only show a number: Liberty (2). Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26302 --- Comment #58 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 124243 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124243&action=edit Bug 26302: Make syspref's names start with uppercase -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26302 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This enhancement allows |This enhancement allows release notes|customizing the number of |customizing the number of |call numbers displayed for |call numbers displayed for |OPAC search results for |OPAC search results for |items available and not |items available and not |available by changing two |available by changing two |new system preferences: |new system preferences: |- |- |resultsMaxItems: maximum |ResultsMaxItems: maximum |number of available items |number of available items |displayed in search results |displayed in search results |(default = 1) |(default = 1) |- |- |resultsMaxItemsUnavailable |ResultsMaxItemsUnavailable |- maximum number of |- maximum number of |unavailable items displayed |unavailable items displayed |in search results (such as |in search results (such as |when checked out and |when checked out and |damaged) (default = 0) |damaged) (default = 0) | | |This is useful when records |This is useful when records |have a large number of |have a large number of |items, for example larger |items, for example larger |libraries with many |libraries with many |branches, union catalogues, |branches, union catalogues, |and university libraries |and university libraries |with course text books. |with course text books. CC| |jonathan.druart+koha@gmail. | |com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26302 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #59 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- 1. Do we really need status=>other to be passed? 2. Shouldn't the pref's names contain "OPAC"? 3. One test is failing # Failed test 'All records have at least one item available' # at t/db_dependent/Search.t line 500. # got: 'false' # expected: 'true' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26302 --- Comment #60 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Jonathan Druart from comment #59)
3. One test is failing
# Failed test 'All records have at least one item available' # at t/db_dependent/Search.t line 500. # got: 'false' # expected: 'true'
I cannot replicate this after a reset_all.. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26302 --- Comment #61 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #59)
1. Do we really need status=>other to be passed?
Yes, this is part of the change. An attempt to not pass it, may probably result in more obfuscated xslt code.
2. Shouldn't the pref's names contain "OPAC"?
Good point. They strictly relate to OPAC now. Will add a follow-up for it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26302 --- Comment #62 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #60)
(In reply to Jonathan Druart from comment #59)
3. One test is failing
# Failed test 'All records have at least one item available' # at t/db_dependent/Search.t line 500. # got: 'false' # expected: 'true'
I cannot replicate this after a reset_all..
Passes with me too. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26302 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This enhancement allows |This enhancement allows release notes|customizing the number of |customizing the number of |call numbers displayed for |call numbers displayed for |OPAC search results for |OPAC search results for |items available and not |items available and not |available by changing two |available by changing two |new system preferences: |new system preferences: |- |- |ResultsMaxItems: maximum |OPACResultsMaxItems: |number of available items |maximum number of available |displayed in search results |items displayed in search |(default = 1) |results (default = 1) |- |- |ResultsMaxItemsUnavailable |OPACResultsMaxItemsUnavaila |- maximum number of |ble - maximum number of |unavailable items displayed |unavailable items displayed |in search results (such as |in search results (such as |when checked out and |when checked out and |damaged) (default = 0) |damaged) (default = 0) | | |This is useful when records |This is useful when records |have a large number of |have a large number of |items, for example larger |items, for example larger |libraries with many |libraries with many |branches, union catalogues, |branches, union catalogues, |and university libraries |and university libraries |with course text books. |with course text books. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26302 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124243|0 |1 is obsolete| | --- Comment #63 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 124244 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124244&action=edit Bug 26302: Make syspref's names start with uppercase Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26302 --- Comment #64 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 124245 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124245&action=edit Bug 26302: (QA follow-up) Prefix prefs with OPAC git grep -l "ResultsMaxItems" | xargs sed -i -e "/ResultsMaxItems/ s/ResultsMaxItems/OPACResultsMaxItems/g" And line: koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACResults.xsl: <xsl:variable name="OPACResultsMaxItems" select="number(marc:sysprefs/marc:syspref[@name='resultsMaxItems']+0)"/> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26302 --- Comment #65 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- - <xsl:variable name="resultsMaxItems" select="number(marc:sysprefs/marc:syspref[@name='resultsMaxItems']+0)"/> - <xsl:variable name="resultsMaxItemsUnavailable" select="number(marc:sysprefs/marc:syspref[@name='resultsMaxItemsUnavailable']+0)"/> + <xsl:variable name="ResultsMaxItems" select="number(marc:sysprefs/marc:syspref[@name='resultsMaxItems']+0)"/> + <xsl:variable name="ResultsMaxItemsUnavailable" select="number(marc:sysprefs/marc:syspref[@name='ResultsMaxItemsUnavailable']+0)"/> Why did you miss the second occurrence on the first change and not on the second ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26302 --- Comment #66 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Marcel de Rooy from comment #65)
- <xsl:variable name="resultsMaxItems" select="number(marc:sysprefs/marc:syspref[@name='resultsMaxItems']+0)"/> - <xsl:variable name="resultsMaxItemsUnavailable" select="number(marc:sysprefs/marc: syspref[@name='resultsMaxItemsUnavailable']+0)"/> + <xsl:variable name="ResultsMaxItems" select="number(marc:sysprefs/marc:syspref[@name='resultsMaxItems']+0)"/> + <xsl:variable name="ResultsMaxItemsUnavailable" select="number(marc:sysprefs/marc: syspref[@name='ResultsMaxItemsUnavailable']+0)"/>
Why did you miss the second occurrence on the first change and not on the second ?
Oops, forgot 'g' in my sed command. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26302 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26302 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26302 --- Comment #67 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26302 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Resolution|--- |FIXED Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26302 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Manual -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26302 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #68 from Fridolin Somers <fridolin.somers@biblibre.com> --- Buuuuuuuut, we also need this change in UNIMARC XSLT files right ? And what about custom files ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26302 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=24630 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26302 --- Comment #69 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Fridolin Somers from comment #68)
Buuuuuuuut, we also need this change in UNIMARC XSLT files right ? And what about custom files ?
They have been following different paths for long time already. Custom files obviously are not in scope here. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org