[Bug 35245] New: Incorrect select2 with in authorities cataloging
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35245 Bug ID: 35245 Summary: Incorrect select2 with in authorities cataloging Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: pedro.amorim@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org CC: katrin.fischer@bsz-bw.de, lucy.vaux-harvey@ptfs-europe.com, m.de.rooy@rijksmuseum.nl, martin.renvoize@ptfs-europe.com, oleonard@myacpl.org Depends on: 28611 To reproduce, k-t-d: 1) Edit a authority Marc framework, e.g. 'CHRON_TERM', visit: /cgi-bin/koha/admin/auth_tag_structure.pl?authtypecode=CHRON_TERM 2) Pick any field to turn into a AV field, e.g. 371, and edit its subfields: /cgi-bin/koha/admin/auth_subfields_structure.pl?tagfield=371&authtypecode=CHRON_TERM 3) Pick a subfield e.g. 'd' and click edit, visit: /cgi-bin/koha/admin/auth_subfields_structure.pl?op=add_form&tagfield=371&tagsubfield=d&authtypecode=CHRON_TERM#subdfield 4) Pick a Authorized value list e.g. DEPARTMENT, click Submit 5) Create a new authority of the same type 'CHRON_TERM', visit: /cgi-bin/koha/authorities/authorities.pl?authtypecode=CHRON_TERM 6) Click on Tab '3' and click on field 371 ADDRESS to expand it 7) Notice field 'd' select2 width is very narrow Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28611 [Bug 28611] Incorrect Select2 width -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35245 --- Comment #1 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 158319 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158319&action=edit Bug 35245: Set default width for select2 in authorities Test plan: 1) Edit a authority Marc framework, e.g. 'CHRON_TERM', visit: /cgi-bin/koha/admin/auth_tag_structure.pl?authtypecode=CHRON_TERM 2) Pick any field to turn into a AV field, e.g. 371, and edit its subfields: /cgi-bin/koha/admin/auth_subfields_structure.pl?tagfield=371&authtypecode=CHRON_TERM 3) Pick a subfield e.g. 'd' and click edit, visit: /cgi-bin/koha/admin/auth_subfields_structure.pl?op=add_form&tagfield=371&tagsubfield=d&authtypecode=CHRON_TERM#subdfield 4) Pick a Authorized value list e.g. DEPARTMENT, click Submit 5) Create a new authority of the same type 'CHRON_TERM', visit: /cgi-bin/koha/authorities/authorities.pl?authtypecode=CHRON_TERM 6) Click on Tab '3' and click on field 371 ADDRESS to expand it 7) Notice field 'd' select2 width is very narrow 8) Apply patch. Repeat. Notice its not narrow anymore -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35245 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35245 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35245 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158319|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 158320 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158320&action=edit Bug 35245: Set default width for select2 in authorities Test plan: 1) Edit a authority Marc framework, e.g. 'CHRON_TERM', visit: /cgi-bin/koha/admin/auth_tag_structure.pl?authtypecode=CHRON_TERM 2) Pick any field to turn into a AV field, e.g. 371, and edit its subfields: /cgi-bin/koha/admin/auth_subfields_structure.pl?tagfield=371&authtypecode=CHRON_TERM 3) Pick a subfield e.g. 'd' and click edit, visit: /cgi-bin/koha/admin/auth_subfields_structure.pl?op=add_form&tagfield=371&tagsubfield=d&authtypecode=CHRON_TERM#subdfield 4) Pick a Authorized value list e.g. DEPARTMENT, click Submit 5) Create a new authority of the same type 'CHRON_TERM', visit: /cgi-bin/koha/authorities/authorities.pl?authtypecode=CHRON_TERM 6) Click on Tab '3' and click on field 371 ADDRESS to expand it 7) Notice field 'd' select2 width is very narrow 8) Apply patch. Repeat. Notice its not narrow anymore Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35245 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |trivial -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35245 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |pedro.amorim@ptfs-europe.co |ity.org |m --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pleas don't forget to assign the bug to yourself :) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35245 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35245 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Incorrect select2 with in |Incorrect select2 width |authorities cataloging |when cataloging authorities -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35245 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35245 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158320|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 158459 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158459&action=edit Bug 35245: Set default width for select2 in authorities Test plan: 1) Edit a authority Marc framework, e.g. 'CHRON_TERM', visit: /cgi-bin/koha/admin/auth_tag_structure.pl?authtypecode=CHRON_TERM 2) Pick any field to turn into a AV field, e.g. 371, and edit its subfields: /cgi-bin/koha/admin/auth_subfields_structure.pl?tagfield=371&authtypecode=CHRON_TERM 3) Pick a subfield e.g. 'd' and click edit, visit: /cgi-bin/koha/admin/auth_subfields_structure.pl?op=add_form&tagfield=371&tagsubfield=d&authtypecode=CHRON_TERM#subdfield 4) Pick a Authorized value list e.g. DEPARTMENT, click Submit 5) Create a new authority of the same type 'CHRON_TERM', visit: /cgi-bin/koha/authorities/authorities.pl?authtypecode=CHRON_TERM 6) Click on Tab '3' and click on field 371 ADDRESS to expand it 7) Notice field 'd' select2 width is very narrow 8) Apply patch. Repeat. Notice its not narrow anymore Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35245 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This is barely usable without this patch, so I have changed it from enh to trivial. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35245 --- Comment #6 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Awesome. Thank you, Katrin. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35245 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35245 --- Comment #7 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35245 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to master |Pushed to stable Version(s)|23.11.00 |23.11.00,23.05.06 released in| | --- Comment #8 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.05.x for 23.05.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35245 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.11.00,23.05.06 |23.11.00,23.05.06,22.11.12 released in| | Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35245 --- Comment #9 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Nice work everyone! Pushed to 22.11.x for next release -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org