[Bug 35280] New: OPAC patron entry form: Patron attributes "clear" link broken
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35280 Bug ID: 35280 Summary: OPAC patron entry form: Patron attributes "clear" link broken Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org If you have a patron attribute which is editable in the OPAC (and not tied to an authorized value) there is a "Clear" link by each attribute's <textarea>. It is supposed to clear any content from the text area but it doesn't work. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35280 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35280 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 158609 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158609&action=edit Bug 35280: Fix patron attributes "clear" link in OPAC patron entry form This patch makes a minor correction to the JavaScript controlling the behavior of the "clear" link which appears on the patron entry form next to patron attribute <select>s or <textarea>s which are editable in the OPAC. To test, apply the patch and create patron attributes which have both "Display in OPAC" and "Editable in OPAC" checked. - Create one which is tied to an authorized value, and one which isn't. - Log in to the OPAC and click the "Personal details" tab. - In the entry form, find the patron attribute fields under the Additional information" heading.. - Select a value in the dropdown, and enter text in the textarea. - Confirm that clicking the corresponding "Clear" link for each works as expected. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35280 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35280 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158609|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 158618 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158618&action=edit Bug 35280: Fix patron attributes "clear" link in OPAC patron entry form This patch makes a minor correction to the JavaScript controlling the behavior of the "clear" link which appears on the patron entry form next to patron attribute <select>s or <textarea>s which are editable in the OPAC. To test, apply the patch and create patron attributes which have both "Display in OPAC" and "Editable in OPAC" checked. - Create one which is tied to an authorized value, and one which isn't. - Log in to the OPAC and click the "Personal details" tab. - In the entry form, find the patron attribute fields under the Additional information" heading.. - Select a value in the dropdown, and enter text in the textarea. - Confirm that clicking the corresponding "Clear" link for each works as expected. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35280 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35280 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35280 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158618|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 158623 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158623&action=edit Bug 35280: Fix patron attributes "clear" link in OPAC patron entry form This patch makes a minor correction to the JavaScript controlling the behavior of the "clear" link which appears on the patron entry form next to patron attribute <select>s or <textarea>s which are editable in the OPAC. To test, apply the patch and create patron attributes which have both "Display in OPAC" and "Editable in OPAC" checked. - Create one which is tied to an authorized value, and one which isn't. - Log in to the OPAC and click the "Personal details" tab. - In the entry form, find the patron attribute fields under the Additional information" heading.. - Select a value in the dropdown, and enter text in the textarea. - Confirm that clicking the corresponding "Clear" link for each works as expected. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35280 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35280 --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35280 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.11.00 |23.11.00,23.05.06 released in| | CC| |fridolin.somers@biblibre.co | |m Status|Pushed to master |Pushed to stable --- Comment #5 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.05.x for 23.05.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35280 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.11.00,23.05.06 |23.11.00,23.05.06,22.11.12 released in| | Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35280 --- Comment #6 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Nice work everyone! Pushed to 22.11.x for next release -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org