[Bug 7507] New: Audience Subtype limit on Advanced Search does not have all Audiences
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7507 Bug #: 7507 Summary: Audience Subtype limit on Advanced Search does not have all Audiences Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Platform: All OS/Version: All Status: NEW Severity: normal Priority: P5 - low Component: Searching AssignedTo: gmcharlt@gmail.com ReportedBy: nengard@gmail.com QAContact: koha.sekjal@gmail.com If you look at the audience subtype limit on the advanced search it has only a few choices, but if you edit the audience in the 008 there are many many options. The advanced search should have the same values as the 008 so that you can limit on everything that you might have entered. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7507 --- Comment #1 from Nicole C. Engard <nengard@gmail.com> --- Created attachment 10727 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10727&action=edit opac types Can we grab some code from the staff client which has more subtypes than the OPAC? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7507 --- Comment #2 from Nicole C. Engard <nengard@gmail.com> --- Created attachment 10728 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10728&action=edit staff types -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7507 --- Comment #3 from Nicole C. Engard <nengard@gmail.com> --- Also the types in the OPAC aren't searching right ... Clicking on Juvenile on the OPAC is actually audience 'c' Preadolescent audience. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7507 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy@bywatersolutions.com --- Comment #4 from Joy Nelson <joy@bywatersolutions.com> --- Further note: These subtype limits do not even match what the staff side or what is in the marc record (tag 008 position 22). In the OPAC: The subtype limit of Easy is audience 'a' which is Preschool audience on the staff side. The OPAC limit of Juvenile is actually 'c' Preadolescent on the staffside. (NOTE: there is a juvenile audience 'j' which leads to significant confusion by staff who believe this is the same search) Subtype limit of 'd' Young Adult on Opac is 'Adolescent' on staffside. Only the Adult designation is an accurate match to the search on the staffside. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7507 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|gmcharlt@gmail.com |dcook@prosentient.com.au --- Comment #5 from David Cook <dcook@prosentient.com.au> --- Created attachment 14907 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14907&action=edit Bug 7507 - Audience Subtype limit on OPAC Advanced Search does not have all Audiences Very simple template change. Just copied the code from the staff client so that the OPAC advanced search drop-down menu shows the correct options for the audience subtype limit. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7507 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14907|0 |1 is obsolete| | --- Comment #6 from Nicole C. Engard <nengard@gmail.com> --- Created attachment 15053 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15053&action=edit [SIGNED-OFF] Bug 7507 - Audience Subtype limit on OPAC Advanced Search does not have all Audiences The OPAC audience subtype limit did not have all the audiences defined by the MARC record (and available in the staff client advanced search). It also incorrectly labelled some of the audiences that it did include. This patch copies the (correct) audiences from the staff client template to the OPAC template. Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> Test plan: * Search before applying by audience * Apply patch * Search by a newly appeared audience * Search by an audience that was there before All tests pass! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7507 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7507 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |jonathan.druart@biblibre.co | |m Patch complexity|--- |Trivial patch QA Contact|koha.sekjal@gmail.com |jonathan.druart@biblibre.co | |m --- Comment #7 from Jonathan Druart <jonathan.druart@biblibre.com> --- QA comment: It seems consistent to have the same values at the OPAC and at the intranet. This patch just adds missing entries in the advanced search form. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7507 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15053|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 15108 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15108&action=edit Bug 7507 - Audience Subtype limit on OPAC Advanced Search does not have all Audiences The OPAC audience subtype limit did not have all the audiences defined by the MARC record (and available in the staff client advanced search). It also incorrectly labelled some of the audiences that it did include. This patch copies the (correct) audiences from the staff client template to the OPAC template. Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> Test plan: * Search before applying by audience * Apply patch * Search by a newly appeared audience * Search by an audience that was there before All tests pass! Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Replace tab with 4 spaces. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7507 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #9 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7507 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris@bigballofwax.co.nz --- Comment #10 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.10.x and 3.8.x will be in 3.10.3 and 3.8.10 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org