http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9493 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=8942 -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9493 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14862|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 14890 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14890&action=edit [SIGNED-OFF] Bug 9493: confirmations for user holds in opac are not translatable In opac-user.tt, javascript for user holds confirmations (cancel, suspend, resume) are not translatable. This is because text is in onclick attribute, withtout javascript method for translatable strings : _(). This patch moves those strings as variables into script tag and sets them translatable. Test plan : - set a hold for a user - Go to OPAC user page "my summary" - click on "Cancel" => you get a confirmation message - click on "Suspend all holds" => you get a confirmation message - click on "Resume all suspended holds" => you get a confirmation message Test this is 'en' and another language. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9493 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14890|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 15142 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15142&action=edit Bug 9493: confirmations for user holds in opac are not translatable In opac-user.tt, javascript for user holds confirmations (cancel, suspend, resume) are not translatable. This is because text is in onclick attribute, withtout javascript method for translatable strings : _(). This patch moves those strings as variables into script tag and sets them translatable. Test plan : - set a hold for a user - Go to OPAC user page "my summary" - click on "Cancel" => you get a confirmation message - click on "Suspend all holds" => you get a confirmation message - click on "Resume all suspended holds" => you get a confirmation message Test this is 'en' and another language. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9493 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris@bigballofwax.co.nz --- Comment #6 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.10.x and 3.8.x will be in 3.10.3 and 3.8.10 -- You are receiving this mail because: You are watching all bug changes.