[Bug 31601] New: Materials specified note should include an ID on both the check in and checkout pages
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31601 Bug ID: 31601 Summary: Materials specified note should include an ID on both the check in and checkout pages Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: lucas@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com If you add a materials specified, 952$3, a note will appear on both the check-in and checkout pages. The checkout page already included the ID '#materials' but the check-in does not. They should both have an ID so they can be targeted directly with CSS or jQuery. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31601 Andrew Fuerste-Henry <andrewfh@dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrewfh@dubcolib.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31601 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31601 --- Comment #1 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 140847 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140847&action=edit Bug 31601: Add ID to materials specified check-in page TO test: 1. Apply patch 2. Find an item and add a materials specified note ( 952$3 ) to it. 3. Add this CSS to the IntranetUserCSS system preference: background: red; } 4. Now check-in the item in. The background of the materials specified note should now be red! 5. Hooray, sign off! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31601 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31601 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31601 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140847|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 140848 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140848&action=edit Bug 31601: Add ID to materials specified check-in page TO test: 1. Apply patch 2. Find an item and add a materials specified note ( 952$3 ) to it. 3. Add this CSS to the IntranetUserCSS system preference: background: red; } 4. Now check-in the item in. The background of the materials specified note should now be red! 5. Hooray, sign off! Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31601 Jessie Zairo <jzairo@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jzairo@bywatersolutions.com --- Comment #3 from Jessie Zairo <jzairo@bywatersolutions.com> --- The checkin note was not red. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31601 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #4 from Lucas Gass <lucas@bywatersolutions.com> --- (In reply to Jessie Zairo from comment #3)
The checkin note was not red.
Works for me, can you please reapply the patch and try again? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31601 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140848|0 |1 is obsolete| | --- Comment #5 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 140852 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140852&action=edit Bug 31601: Add ID to materials specified check-in page TO test: 1. Apply patch 2. Find an item and add a materials specified note ( 952$3 ) to it. 3. Add this CSS to the IntranetUserCSS system preference: background: red; } 4. Now check-in the item in. The background of the materials specified note should now be red! 5. Hooray, sign off! Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Lisette Scheer <lisettePalouse+Koha@gmail.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31601 Lisette Scheer <lisettepalouse+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |lisettepalouse+koha@gmail.c | |om --- Comment #6 from Lisette Scheer <lisettepalouse+koha@gmail.com> --- Worked as expected for me. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31601 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31601 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140852|0 |1 is obsolete| | --- Comment #7 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 141115 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141115&action=edit Bug 31601: Add ID to materials specified check-in page TO test: 1. Apply patch 2. Find an item and add a materials specified note ( 952$3 ) to it. 3. Add this CSS to the IntranetUserCSS system preference: background: red; } 4. Now check-in the item in. The background of the materials specified note should now be red! 5. Hooray, sign off! Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Lisette Scheer <lisettePalouse+Koha@gmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31601 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | CC| |m.de.rooy@rijksmuseum.nl Assignee|koha-bugs@lists.koha-commun |lucas@bywatersolutions.com |ity.org | --- Comment #8 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Penalty points for not filling assignee -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31601 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31601 --- Comment #9 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31601 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org