[Bug 28512] New: spinelabel-print.tt should include the logged in branchcode
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28512 Bug ID: 28512 Summary: spinelabel-print.tt should include the logged in branchcode Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Label/patron card printing Assignee: cnighswonger@foundations.edu Reporter: lucas@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org spinelabel-print.tt does not include the normal header include therefore there is no information about the current logged in branch. It would be nice to be able to write CSS for labels specific to a given branch. It would be easy to add the logged in branch code as a class on the HTML body. This would allow for branch specific CSS for labels. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28512 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28512 --- Comment #1 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 121607 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121607&action=edit Bug 28512: add logged in branch as class to spinelabel-print.tt body To test: -Apply patch and generate a quick spine label. -Inscept the page and notice that the body should contain a new class which corresponds with that the of the logged in branch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28512 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|cnighswonger@foundations.ed |lucas@bywatersolutions.com |u | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28512 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28512 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #121607|0 |1 is obsolete| | --- Comment #2 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 133514 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133514&action=edit Bug 28512: add logged in branch as class to spinelabel-print.tt body To test: -Apply patch and generate a quick spine label. -Inscept the page and notice that the body should contain a new class which corresponds with that the of the logged in branch. Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28512 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28512 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28512 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #133514|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 133762 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133762&action=edit Bug 28512: add logged in branch as class to spinelabel-print.tt body To test: -Apply patch and generate a quick spine label. -Inscept the page and notice that the body should contain a new class which corresponds with that the of the logged in branch. Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28512 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|spinelabel-print.tt should |Quick spine label creator: |include the logged in |Add CSS class with logged |branchcode |in library's branchcode -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28512 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA CC| |fridolin.somers@biblibre.co | |m --- Comment #4 from Fridolin Somers <fridolin.somers@biblibre.com> --- Actually adding current logged in branch is only in OPAC and with a prefix 'branch-'. It would be risky to do without this prefix. It can trigger an unwanted CSS rule. For consistency, this should be added to all staff interface body tag. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28512 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Would you be ok with it being in another element instead of the body tag? Adding to all staff pages is quite a huge task and I think a quick fix here would be nice for libraries. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28512 --- Comment #6 from Fridolin Somers <fridolin.somers@biblibre.com> --- (In reply to Katrin Fischer from comment #5)
Would you be ok with it being in another element instead of the body tag?
Good idea yep -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28512 --- Comment #7 from Lucas Gass <lucas@bywatersolutions.com> --- #spinelabel(In reply to Katrin Fischer from comment #5)
Would you be ok with it being in another element instead of the body tag?
Adding to all staff pages is quite a huge task and I think a quick fix here would be nice for libraries.
<div id="spinelabel"> Maybe on this element? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28512 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28512 --- Comment #8 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 139801 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139801&action=edit Bug 28512: Add branchcode as class to spinelabel element To test: -Apply patch and generate a quick spine label. -Inscept the page and notice that the #spinelabel element should contain a new class which corresponds with that the of the logged in branch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28512 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #133762|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28512 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139801|0 |1 is obsolete| | --- Comment #9 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 140503 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140503&action=edit Bug 28512: Add branchcode as class to spinelabel element To test: -Apply patch and generate a quick spine label. -Inscept the page and notice that the #spinelabel element should contain a new class which corresponds with that the of the logged in branch. Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28512 Andrew Fuerste-Henry <andrewfh@dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |andrewfh@dubcolib.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28512 --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I have a last doubt on this one: we don't show that it's the logged-in library here. One could think it was homebranch/holdingbranch - but not sure though how we could make it more clear. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28512 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28512 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140503|0 |1 is obsolete| | --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 141009 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141009&action=edit Bug 28512: Add branchcode as class to spinelabel element To test: -Apply patch and generate a quick spine label. -Inscept the page and notice that the #spinelabel element should contain a new class which corresponds with that the of the logged in branch. Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28512 Andrew Fuerste-Henry <andrewfh@dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31633 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31633 [Bug 31633] Allow selection of branch to be applied in quick spine label CSS class -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28512 --- Comment #12 from Andrew Fuerste-Henry <andrewfh@dubcolib.org> --- (In reply to Katrin Fischer from comment #10)
I have a last doubt on this one: we don't show that it's the logged-in library here. One could think it was homebranch/holdingbranch - but not sure though how we could make it more clear.
Just filed bug 31633 as a follow-up to add a method to select which branch gets applied. Probably a syspref? It's not hard to imagine different workflows in which a library would prefer the label format be defined based on any of these three branch choices. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28512 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28512 --- Comment #13 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28512 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org