https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29173 --- Comment #1 from marion.durand@biblibre.com --- (be sur to have at least one Z39-50 or SRU serveur set for authority or the fisrt buton won't be displayed) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29173 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Severity|enhancement |normal --- Comment #2 from Fridolin Somers <fridolin.somers@biblibre.com> --- Indeed, this is a bug (not enhancement) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29173 --- Comment #3 from Thibaud Guillot <thibaud.guillot@biblibre.com> --- Created attachment 128378 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128378&action=edit Fixed pre-filling of the search form from the "Replace record with ZR39.50/SRU" (Authority page detail) Now this action has the same pre-filling behaviour as the "Edit" -> "Edit Record" -> "Replace Record via Z39.50/SRU Search" action. Author Personal - Author Meeting/Conf. - Uniform Title and Subject are filled in if the subfield contains data (like the "Edit->Replace" action). Unimarc and Marc21 specificities are supported. Test Plan : 1) You must have a Z39.50/SRU server for authorities 2) Go to an authority detail page (Author - Uniform title - Subject) 3) First go to "Edit"-> "Edit record" -> "Replace record via..." 4) See that form is prefilled with form data 5) Go back and now click on "Replace Record.." directly 6) See that form is also prefilled with data now -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29173 Thibaud Guillot <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29173 --- Comment #4 from David Nind <david@davidnind.com> --- Created attachment 128410 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128410&action=edit Bug 29173: Fixed pre-filling of the search form from the "Replace record with ZR39.50/SRU" (Authority page detail) Now this action has the same pre-filling behaviour as the "Edit" -> "Edit Record" -> "Replace Record via Z39.50/SRU Search" action. Author Personal - Author Meeting/Conf. - Uniform Title and Subject are filled in if the subfield contains data (like the "Edit->Replace" action). Unimarc and Marc21 specificities are supported. Test Plan : 1) You must have a Z39.50/SRU server for authorities 2) Go to an authority detail page (Author - Uniform title - Subject) 3) First go to "Edit"-> "Edit record" -> "Replace record via..." 4) See that form is prefilled with form data 5) Go back and now click on "Replace Record.." directly 6) See that form is also prefilled with data now https://bugs.koha-community.org/show_bug.cgi?id=29173 Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29173 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes the behaviour of release notes| |the replace an authority | |record via Z39.50/SRU | |buttons when editing an | |authority record. Both ways | |of doing this (Edit > Edit | |record > Replace record via | |Z39.50/SRU search and Edit | |> Replace record via | |Z39.50/SRU search) now | |pre-fill the search form | |with available data. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29173 --- Comment #7 from David Nind <david@davidnind.com> ---

Okay, thanks for commit title, I'm new on this so I can made some mistakes :)

8-) The QA Team are very helpful in helping out new contributors! Here are the guidelines for commits: https://wiki.koha-community.org/wiki/Commit_messages -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29173 --- Comment #9 from marion.durand@biblibre.com --- (In reply to Katrin Fischer from comment #8)

Hi Marion,

I believe this will work nicely for MARC21, but not work for UNIMARC as the fields are quite different.

Why in MARC21 100 is a person's name, in UNIMARC it seems to be used quite differently:

https://www.ifla.org/g/unimarc-rg/unimarc-authorities-3rd-edition-with- updates/ 100 – General Processing Data (update 2018)

So I think we need at least a check on the marcflavor, but it would be even nicer if we could pick out the right fields for UNIMARC as well.

Also I wonder if we could avoid querying the record twice, but someone else might be better suited to comment on that:

my $record = GetAuthority($authid); my $authobj = Koha::Authorities->find($authid);

Hi Katrin, Thank you for looking at this bug. I must point out that I did nothing on this bug (exept filing it). Thibaud is the one who wrote the patch :) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29173 --- Comment #11 from Thibaud Guillot <thibaud.guillot@biblibre.com> --- Created attachment 128728 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128728&action=edit Bug 29173: Fixed pre-filling of the search form from the "Replace record with ZR39.50/SRU" (Authority page detail) Now this action has the same pre-filling behaviour as the "Edit" -> "Edit Record" -> "Replace Record via Z39.50/SRU Search" action. Author Personal - Author Meeting/Conf. - Uniform Title and Subject are filled in if the subfield contains data (like the "Edit->Replace" action). Unimarc and Marc21 specificities are supported. Test Plan : 1) You must have a Z39.50/SRU server for authorities 2) Go to an authority detail page (Author - Uniform title - Subject) 3) First go to "Edit"-> "Edit record" -> "Replace record via..." 4) See that form is prefilled with form data 5) Go back and now click on "Replace Record.." directly 6) See that form is also prefilled with data now -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29173 Thibaud Guillot <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128410|0 |1 is obsolete| | --- Comment #12 from Thibaud Guillot <thibaud.guillot@biblibre.com> --- Created attachment 128730 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128730&action=edit Bug 29173: Fixed pre-filling of the search form from the "Replace record with ZR39.50/SRU" (Authority page detail) Now this action has the same pre-filling behaviour as the "Edit" -> "Edit Record" -> "Replace Record via Z39.50/SRU Search" action. Author Personal - Author Meeting/Conf. - Uniform Title and Subject are filled in if the subfield contains data (like the "Edit->Replace" action). Unimarc and Marc21 specificities are supported. Test Plan : 1) You must have a Z39.50/SRU server for authorities 2) Go to an authority detail page (Author - Uniform title - Subject) 3) First go to "Edit"-> "Edit record" -> "Replace record via..." 4) See that form is prefilled with form data 5) Go back and now click on "Replace Record.." directly 6) See that form is also prefilled with data now https://bugs.koha-community.org/show_bug.cgi?id=29173 Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29173 Thibaud Guillot <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #14 from Thibaud Guillot <thibaud.guillot@biblibre.com> --- Thanks to Katrin for the review, I have modified the patch to add the marcflavour preference in the conditions. Regarding these two lines: "my $record = GetAuthority($authid);" This is to get the contents of the fields in the "authfields" array "my $authobj = Koha::Authorities->find($authid);" This is to retrieve the authority as an object and extract the authority type. If there is a simpler method I'm interested of course. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29173 Thibaud Guillot <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128410|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29173 Thibaud Guillot <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128731|0 |1 is obsolete| | --- Comment #16 from Thibaud Guillot <thibaud.guillot@biblibre.com> --- Created attachment 128756 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128756&action=edit Bug 29173: (follow-up) add marcflavour preference in conditions -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29173 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128410|0 |1 is obsolete| | --- Comment #17 from David Nind <david@davidnind.com> --- Created attachment 130192 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130192&action=edit Bug 29173: Fixed pre-filling of the search form from the "Replace record with ZR39.50/SRU" (Authority page detail) Now this action has the same pre-filling behaviour as the "Edit" -> "Edit Record" -> "Replace Record via Z39.50/SRU Search" action. Author Personal - Author Meeting/Conf. - Uniform Title and Subject are filled in if the subfield contains data (like the "Edit->Replace" action). Unimarc and Marc21 specificities are supported. Test Plan : 1) You must have a Z39.50/SRU server for authorities 2) Go to an authority detail page (Author - Uniform title - Subject) 3) First go to "Edit"-> "Edit record" -> "Replace record via..." 4) See that form is prefilled with form data 5) Go back and now click on "Replace Record.." directly 6) See that form is also prefilled with data now https://bugs.koha-community.org/show_bug.cgi?id=29173 Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29173 --- Comment #19 from David Nind <david@davidnind.com> --- Testing notes (using koha-testing-docker): - Tested using both a MARC21 and UNIMARC installation. - For a UNIMARC installation there is only one way to replace (both before and after the patch is applied): . Select Edit > Edit record . Click on the 'Replace record via Z39.50/SRU search' button => There is no option in the dropdown list to change like a MARC21 installation (Edit > Replace record via Z39.50/SRU search) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29173 --- Comment #21 from Thibaud Guillot <thibaud.guillot@biblibre.com> --- Created attachment 130422 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130422&action=edit Bug 29173 : (follow-up) replace method to get the record from the authority -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29173 --- Comment #23 from Thibaud Guillot <thibaud.guillot@biblibre.com> --- (In reply to David Nind from comment #19)

Testing notes (using koha-testing-docker):

- Tested using both a MARC21 and UNIMARC installation.

- For a UNIMARC installation there is only one way to replace (both before and after the patch is applied): . Select Edit > Edit record . Click on the 'Replace record via Z39.50/SRU search' button => There is no option in the dropdown list to change like a MARC21 installation (Edit > Replace record via Z39.50/SRU search)

Oh ok, I see what you mean, but maybe this dropdown list is about another issue or enhancement and not directly on this BZ. Its my opinion but I can make a mistake, I'm just a newbie on Koha :) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29173 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #25 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Could not compile /kohadevbox/koha/cataloguing/z3950_auth_search.pl: Global symbol "$authobj" requires explicit package name (did you forget to declare "my $authobj"?) at /kohadevbox/koha/cataloguing/z3950_auth_search.pl line 39. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29173 Thibaud Guillot <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130192|0 |1 is obsolete| | Attachment #130193|0 |1 is obsolete| | Attachment #130422|0 |1 is obsolete| | --- Comment #27 from Thibaud Guillot <thibaud.guillot@biblibre.com> --- Created attachment 132443 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132443&action=edit Bug 29173: Fixed pre-filling of the search form from the "Replace record with ZR39.50/SRU" (Authority page detail) Now this action has the same pre-filling behaviour as the "Edit" -> "Edit Record" -> "Replace Record via Z39.50/SRU Search" action. Author Personal - Author Meeting/Conf. - Uniform Title and Subject are filled in if the subfield contains data (like the "Edit->Replace" action). Unimarc and Marc21 specificities are supported. Test Plan : 1) You must have a Z39.50/SRU server for authorities 2) Go to an authority detail page (Author - Uniform title - Subject) 3) First go to "Edit"-> "Edit record" -> "Replace record via..." 4) See that form is prefilled with form data 5) Go back and now click on "Replace Record.." directly 6) See that form is also prefilled with data now -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29173 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29173 Thibaud Guillot <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29173 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #30 from David Nind <david@davidnind.com> --- I'm getting this error after applying the patch: The method Koha::Authority->record is not covered by tests! Trace begun at /kohadevbox/koha/Koha/Object.pm line 875 Koha::Object::AUTOLOAD('Koha::Authority=HASH(0x55aa079a8cf0)') called at /kohadevbox/koha/cataloguing/z3950_auth_search.pl line 37 eval {...} at /kohadevbox/koha/cataloguing/z3950_auth_search.pl line 2 CGI::Compile::ROOT::kohadevbox_koha_cataloguing_z3950_auth_search_2epl::__ANON__('CGI::Compile=HASH(0x55aa07855ba0)', '', '/kohadevbox/koha/cataloguing/z3950_auth_search.pl', '/kohadevbox/koha/cataloguing', 'ARRAY(0x55aa07853d88)') called at /usr/share/perl5/CGI/Compile.pm line 151 CGI::Compile::ROOT::kohadevbox_koha_cataloguing_z3950_auth_search_2epl::z3950_auth_search_2epl at /usr/share/perl5/CGI/Emulate/PSGI.pm line 30 CGI::Emulate::PSGI::__ANON__('HASH(0x55aa07ea9998)') called at /usr/share/perl5/Plack/App/WrapCGI.pm line 95 Plack::App::WrapCGI::call('Plack::App::WrapCGI=HASH(0x55aa07884ad0)', 'HASH(0x55aa07ea9998)') called at /usr/share/perl5/Plack/Component.pm line 50 Plack::Component::__ANON__('HASH(0x55aa07ea9998)') called at /usr/share/perl5/Plack/App/CGIBin.pm line 50 Plack::App::CGIBin::serve_path('Plack::App::CGIBin=HASH(0x55a9fcf2d7b8)', 'HASH(0x55aa07ea9998)', '/kohadevbox/koha/cataloguing/z3950_auth_search.pl') called at /usr/share/perl5/Plack/App/File.pm line 34 Plack::App::File::call('Plack::App::CGIBin=HASH(0x55a9fcf2d7b8)', 'HASH(0x55aa07ea9998)') called at /usr/share/perl5/Plack/Component.pm line 50 Plack::Component::__ANON__('HASH(0x55aa07ea9998)') called at /usr/share/perl5/Plack/Middleware/LogWarn.pm line 22 Plack::Middleware::LogWarn::call('Plack::Middleware::LogWarn=HASH(0x55aa0666c2e0)', 'HASH(0x55aa07ea9998)') called at /usr/share/perl5/Plack/Component.pm line 50 Plack::Component::__ANON__('HASH(0x55aa07ea9998)') called at /usr/share/perl5/Plack/Middleware/Log4perl.pm line 30 Plack::Middleware::Log4perl::call('Plack::Middleware::Log4perl=HASH(0x55aa0666c670)', 'HASH(0x55aa07ea9998)') called at /usr/share/perl5/Plack/Component.pm line 50 Plack::Component::__ANON__('HASH(0x55aa07ea9998)') called at /usr/share/perl5/Plack/Middleware/HTTPExceptions.pm line 20 Plack::Middleware::HTTPExceptions::try {...} at /usr/share/perl5/Try/Tiny.pm line 100 ....... -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29173 Thibaud Guillot <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136411|0 |1 is obsolete| | --- Comment #31 from Thibaud Guillot <thibaud.guillot@biblibre.com> --- Created attachment 136440 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136440&action=edit Bug 29173: Fixed pre-filling of the search form from the "Replace record with ZR39.50/SRU" (Authority page detail) Now this action has the same pre-filling behaviour as the "Edit" -> "Edit Record" -> "Replace Record via Z39.50/SRU Search" action. Author Personal - Author Meeting/Conf. - Uniform Title and Subject are filled in if the subfield contains data (like the "Edit->Replace" action). Unimarc and Marc21 specificities are supported. Test Plan : 1) You must have a Z39.50/SRU server for authorities 2) Go to an authority detail page (Author - Uniform title - Subject) 3) First go to "Edit"-> "Edit record" -> "Replace record via..." 4) See that form is prefilled with form data 5) Go back and now click on "Replace Record.." directly 6) See that form is also prefilled with data now -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29173 --- Comment #33 from David Nind <david@davidnind.com> --- (In reply to Thibaud Guillot from comment #32)

Maybe I miss the rebase, can you test it now and tell me if you have the same issue ?

I still have the same issue. Testing using koha-testing-docker, current master, flush_memcached, restart_all, and cleared browser cache. For what it's worth: I was getting a similar error with some recalls related bugs, such as bug 30971. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29173 Thibaud Guillot <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29173 --- Comment #36 from Thibaud Guillot <thibaud.guillot@biblibre.com> --- I change the logical this time, in a "easier" way ? With a direct mapping with data's fields and sufields.. I hope this work now for you :) I also changed my test plan cause now I had the same behavior when I click on "Edit" then "Replace with.." than directly choose 'Replace with.." I'm waiting your feedbacks, thanks -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29173 Thibaud Guillot <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29173 --- Comment #39 from Thibaud Guillot <thibaud.guillot@biblibre.com> --- (In reply to David Nind from comment #37)

Hi

I'm getting this error when trying to apply the patch:

root@kohadevbox:koha(bz29173)$ git bz apply 29173

Bug 29173 - Button "replace authority record via Z39/50/SRU" doesn't pre-fill

144867 - Bug 29173: Fixed pre-filling of the search form from the "Replace record with ZR39.50/SRU" (Authority page detail)

Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 29173: Fixed pre-filling of the search form from the "Replace record with ZR39.50/SRU" (Authority page detail) error: sha1 information is lacking or useless (cataloguing/z3950_auth_search.pl). error: could not build fake ancestor Patch failed at 0001 Bug 29173: Fixed pre-filling of the search form from the "Replace record with ZR39.50/SRU" (Authority page detail)

David

Hi David, Thanks for your feedback :) and best wishes for 2023 by the way ;) I squash my last commit and I test it in kohadevbox, it seems ok to me, can you re-test it ? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29173 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29173 --- Comment #42 from David Nind <david@davidnind.com> --- It would be good if both pop up windows were the same size for the search. At the moment the pop up window is slightly narrower for Edit > Edit record > Replace record via Z39.40/SRU search. This causes the labels to be above the input fields, rather than nicely aligned to the left. I tried to work out where the window size is set, but had no luck... Maybe this should be on a separate bug. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29173 --- Comment #44 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 146381 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146381&action=edit Bug 29173: (QA follow-up) Match pop-over sizes As suggested by David Nind, this patch updates the call to z3950 search on the authority edit page to match the sizing of the one from the details page. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29173 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |32906 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32906 [Bug 32906] Make 'Replace record via Z3950/SRU' buttons in authorities work consistently -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29173 --- Comment #46 from Thibaud Guillot <thibaud.guillot@biblibre.com> --- (In reply to Martin Renvoize from comment #45)

This all works well and the QA script is happy.

I would have loved to see some consistency in the implementation between the two buttons however.. At first I thought this approach made the most logical sense, at the controller level, but as I worked through the code to understand how it works on the edit page I concluded that I think that's the cleaner approach pre-populating the search fields using the data already on display in the page rather than having to query for it again in the search controller.

Anyway.. I don't think that should hold this up.. but it might be nice to clean up as a follow-up bug.

Passing QA, thanks Thibaud, and welcome!

Thanks to you Martin :) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29173 --- Comment #47 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29173 --- Comment #48 from Jacob O'Mara <jacob.omara@ptfs-europe.com> --- Nice work, thanks everyone! Pushed to 22.11.x for the next release. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29173 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00,22.11.03,22.05.10 |23.05.00,22.11.03,22.05.10, released in| |21.11.18 CC| |arthur.suzuki@biblibre.com Status|Pushed to oldstable |Pushed to oldoldstable --- Comment #50 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- applied to 21.11.x for 21.11.18 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29173 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33445 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33445 [Bug 33445] Regression - Replacing authority via Z39.50 will not search for anything but the value from the existing authority -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29173 --- Comment #53 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Jonathan Druart from comment #52)

Please have a look at bug 33445 that is suggesting to revert these patches!

ping Thibaud? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29173 --- Comment #55 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Thibaud Guillot from comment #54)

(In reply to Jonathan Druart from comment #53)

...

(In reply to Jonathan Druart from comment #52)

...

Please have a look at bug 33445 that is suggesting to revert these patches!

ping Thibaud?

Hello Jonathan,

Sorry for the delay, I saw and read the bug 33445 apparently other patches have been proposed to replace the revert. But I understand the problematic behavior of this one.. Do you think there is a need for me to do something?

If you agree with the changes there it's all good. I hadn't noticed Nick submitted a new version of the patches! -- You are receiving this mail because: You are watching all bug changes.