https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33076 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |katrin.fischer@bsz-bw.de |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33076 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 147474 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147474&action=edit Bug 33076: Add context to "Quotes" A quote as a part of quoted text and a quote as part of the acquisition process need to be translated differently at least in German. This patch adds context to the terms, so we can do that. To test: * Go to Tools > Quote editor * Verify the heading of the page reads "Quotes" * Enable EDIFACT system preference * Go to Administration > EDI accounts * Add a new account save * Verify the table heading reads "Quotes" * Apply patch - nothing should change Verify the translation process: * Run: gulp po:update --lang de-DE * Verify the "Quotes" appear now separated by different context in misc/translator/po/de-DE-messages.po -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33076 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33076 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147505|0 |1 is obsolete| | --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 148234 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148234&action=edit Bug 33076: Add context to "Quotes" A quote as a part of quoted text and a quote as part of the acquisition process need to be translated differently at least in German. This patch adds context to the terms, so we can do that. To test: * Go to Tools > Quote editor * Verify the heading of the page reads "Quotes" * Enable EDIFACT system preference * Go to Administration > EDI accounts * Add a new account save * Verify the table heading reads "Quotes" * Apply patch - nothing should change Verify the translation process: * Run: gulp po:update --lang de-DE * Verify the "Quotes" appear now separated by different context in misc/translator/po/de-DE-messages.po Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33076 --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I think this is OK.. I wasn't 100% sure about the EDI template change.. QUOTES is a type of edi message in this context.. but it may well be translated too...? Anyway.. I reckon we can PQA. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33076 --- Comment #5 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Martin, Do you mean that EDI's "Quotes" should have it's own context vs other "price submissions"? Or that the context "price submissions" is not correct at all? Caroline -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33076 --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- (In reply to Katrin Fischer from comment #6)

We could also make it "EDIFACT message QUOTE" maybe?

That makes sense, I think. I wasn't entirely sure, really.. it's a technical term as a posed to a accounting one in this case so hopefully it'll help the translators understand. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33076 --- Comment #8 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33076 --- Comment #9 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33076 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Tomas, could you push this small follow-up? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33076 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |matt.blenkinsop@ptfs-europe | |.com --- Comment #13 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Follow-up pushed to 22.11.x, keywords removed -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33076 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Status|Pushed to stable |Pushed to oldstable Version(s)|23.05.00,22.11.04 |23.05.00,22.11.04,22.05.12 released in| | --- Comment #14 from Lucas Gass <lucas@bywatersolutions.com> --- Backported to 22.05.x for upcoming 22.05.12 -- You are receiving this mail because: You are watching all bug changes.