[Bug 30044] New: Z39.50/SRU search button broken by update to 19.11.25
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30044 Bug ID: 30044 Summary: Z39.50/SRU search button broken by update to 19.11.25 Change sponsored?: --- Product: Koha Version: 19.11 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: alexander.borkowski@kau.se QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl After updating to 19.11.25 the Z39.50 search button in the catalogue search results page (koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt) does no longer work. I think that this is because versions 20.05 and up contain the changes made in bug #23885, while 19.11 does not and the backport to 19.11 for #26102 does not take this into account and removes too much code from koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt. Steps to reproduce: 1. Click on "Search the catalogue" 2. Enter a search term that will give no results 3. Click on the button labeled "Submit" 4. On the page without results that comes up, click on the button labeled "Z39.50/SRU search" 5. Note that nothing happens -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30044 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark@catalyst.n | |et.nz Severity|normal |major --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Adding Wainui as RMaint of 19.11 - I think it might be easiest to revert the change if possible? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30044 --- Comment #2 from wainuiwitikapark@catalyst.net.nz --- (In reply to Katrin Fischer from comment #1)
Adding Wainui as RMaint of 19.11 - I think it might be easiest to revert the change if possible?
So should I revert 26102 on 19.11.x? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30044 --- Comment #3 from wainuiwitikapark@catalyst.net.nz --- Reverted all commits of bug 26102 on 19.11.x -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30044 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I am sorry, I got confused with the bug linked in the description and didn't realize that was the security bug :( We probably need a 19.11 version in that case that doesn't break things? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30044 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com --- Comment #5 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- I would not have reverted the changes. How do we process now? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30044 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |jonathan.druart+koha@gmail. |ity.org |com Depends on| |26102 Status|NEW |ASSIGNED Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26102 [Bug 26102] Javascript injection in intranet search -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30044 --- Comment #6 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- I have attached a version of the patches for 19.11.x on bug 26102. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30044 --- Comment #7 from wainuiwitikapark@catalyst.net.nz --- Apologies for that. I will apply the new 19.11 patches of bug 26102. Please let me know if there is anything else I need to do to fix it up. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30044 --- Comment #8 from wainuiwitikapark@catalyst.net.nz --- Applied 19.11 patches from bug 26102 to 19.11.x branch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30044 Alexander Borkowski <alexander.borkowski@kau.se> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution|--- |FIXED --- Comment #9 from Alexander Borkowski <alexander.borkowski@kau.se> --- Thank you! The button is working again for us (on 19.11.27). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30044 Bug 30044 depends on bug 26102, which changed state. Bug 26102 Summary: Javascript injection in intranet search https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26102 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldoldoldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org