[Bug 30512] New: Staff interface search results template error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30512 Bug ID: 30512 Summary: Staff interface search results template error Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: testopia@bugs.koha-community.org Depends on: 29609 Bug 29609 made a change to results.tt which result in broken markup: <a href="[% PROCESS biblio_a_href biblionumber => SEARCH_RESULT.biblionumber %]" class => 'p1'> biblio_a_href doesn't accept a "class" property. The problem will only appear if you have IntranetCoce, AmazonCoverImages, or LocalCoverImages enabled. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29609 [Bug 29609] Links to guess the biblio default view need to be centralized -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30512 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30512 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 133210 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133210&action=edit Screenshot showing the problem -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30512 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30512 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 133211 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133211&action=edit Bug 30512: Staff interface search results template error This patch removes some markup from the search results template which was causing markup to be output on the screen. Rather than correct the markup so that the "p1" class is correctly added to the relevant links I'm removing it. The "p1" class isn't used anywhere. The patch also corrects two incorrect template filters on one of the page's links. To test, apply the patch and enable the following system preferences: - AmazonCoverImages - IntranetCoce (if available) - LocalCoverImages - Perform a catalog search in the staff interface which will return results with cover images from each of the enabled services. - The covers should show correctly in the search results with no markup being output on screen. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30512 Bug 30512 depends on bug 29609, which changed state. Bug 29609 Summary: Links to guess the biblio default view need to be centralized https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29609 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30512 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30512 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #133211|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 133571 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133571&action=edit Bug 30512: Staff interface search results template error This patch removes some markup from the search results template which was causing markup to be output on the screen. Rather than correct the markup so that the "p1" class is correctly added to the relevant links I'm removing it. The "p1" class isn't used anywhere. The patch also corrects two incorrect template filters on one of the page's links. To test, apply the patch and enable the following system preferences: - AmazonCoverImages - IntranetCoce (if available) - LocalCoverImages - Perform a catalog search in the staff interface which will return results with cover images from each of the enabled services. - The covers should show correctly in the search results with no markup being output on screen. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30512 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |jonathan.druart+koha@gmail. | |com --- Comment #4 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Oops, thanks Owen! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30512 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30512 --- Comment #5 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30512 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com --- Comment #6 from Kyle M Hall <kyle@bywatersolutions.com> --- Not applying to 21.11.x, please rebase if you think this should be backported! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30512 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org