https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39270 --- Comment #2 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- I think in place_booking.js there is a double count going on and we need to check if the checkout is already booked or not. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39270 --- Comment #3 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 179023 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179023&action=edit Bug 39270: Check to make sure checkouts are not already booked To test: 1. Find an item that is bookable, I turned on Bookable at the item type level for BK. I am using biblionumber=28 in k-t-d with 3 items 2. Book item with barcode ( 39999000001297 ). I did March 7 - April 1 3. Book item with barcode ( 39999000001259 ). I did March 7 - April 1 4. Now checkout 39999000001297 to the patron is was booked to. When asked about early collection say yes. 5. Now item with barcode ( 39999000001273 ) is not checked out or booked. It should be bookable 6. Try to book it, it is not available till April 2, though it should be available right now. 7. APPLY PATCH 8. Try the bookings again. 9. You should correctly not be able to book 39999000001297 or 39999000001259. 10. You should be able to book 39999000001273. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39270 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Assignee|koha-bugs@lists.koha-commun |lucas@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39270 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179023|0 |1 is obsolete| | --- Comment #5 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 179416 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179416&action=edit Bug 39270: Check to make sure checkouts are not already booked To test: 1. Find an item that is bookable, I turned on Bookable at the item type level for BK. I am using biblionumber=28 in k-t-d with 3 items 2. Book item with barcode ( 39999000001297 ). I did March 7 - April 1 3. Book item with barcode ( 39999000001259 ). I did March 7 - April 1 4. Now checkout 39999000001297 to the patron is was booked to. When asked about early collection say yes. 5. Now item with barcode ( 39999000001273 ) is not checked out or booked. It should be bookable 6. Try to book it, it is not available till April 2, though it should be available right now. 7. APPLY PATCH 8. Try the bookings again. 9. You should correctly not be able to book 39999000001297 or 39999000001259. 10. You should be able to book 39999000001273. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39270 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #6 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Going strait for a QA here.. the code is clear and sensible and fixes a clear bug now you've highlighted it. Thanks Lucas. Passing QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39270 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |25.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39270 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_24_11_candidate -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39270 --- Comment #8 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Nice work everyone! Pushed to 24.11.x for 24.11.03 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39270 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting CC| |wainuiwitikapark@catalyst.n | |et.nz --- Comment #9 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11.x as it wasn't backported to 24.05.x -- You are receiving this mail because: You are watching all bug changes.