[Bug 38986] New: Restore "Any" option to purchase suggestion filter by fund
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38986 Bug ID: 38986 Summary: Restore "Any" option to purchase suggestion filter by fund Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: andrew@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org Depends on: 37246 The suggestions management page includes a filter by fund. On the left side of the page, click Acquisition Information to reveal a Fund dropdown. Prior to Bug 37246, this dropdown included and defaulted to the option of "Any." Bug 37246 wrapped that "ANY" option in "[% IF op == 'save' %]." I don't see why that change was made or what it accomplishes. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37246 [Bug 37246] Suggestions filter by fund displays inactive budgets -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38986 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38986 --- Comment #1 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 177282 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177282&action=edit Bug 38986: Restore ANY filter on suggestions.ttype To test: 1 - have two suggestions, one with a fund assigned and one without 2 - go to /cgi-bin/koha/suggestion/suggestion.pl, use Fund filter, confirm it does not offer an Any option 3 - apply patch, reload page 4 - use Fund filter, confirm it shows Any as an option and both Any and None work properly -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38986 Biblibre Sandboxes <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177282|0 |1 is obsolete| | --- Comment #2 from Biblibre Sandboxes <sandboxes@biblibre.com> --- Created attachment 177285 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177285&action=edit Bug 38986: Restore ANY filter on suggestions.ttype To test: 1 - have two suggestions, one with a fund assigned and one without 2 - go to /cgi-bin/koha/suggestion/suggestion.pl, use Fund filter, confirm it does not offer an Any option 3 - apply patch, reload page 4 - use Fund filter, confirm it shows Any as an option and both Any and None work properly Signed-off-by: Sam Sowanick <sam.sowanick@corvallisoregon.gov> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38986 SamSowanick <sam.sowanick@corvallisoregon.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sam.sowanick@corvallisorego | |n.gov Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38986 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Assignee|koha-bugs@lists.koha-commun |andrew@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38986 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |regression -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38986 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38986 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177285|0 |1 is obsolete| | --- Comment #3 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 177473 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177473&action=edit Bug 38986: Restore Any in fund dropdown on suggestions homepage This patch restores Any as a budget filter option on the suggestions homepage, but does not allow one to select Any when saving a suggestion To test: 1 - have two suggestions, one with a fund assigned and one without 2 - go to /cgi-bin/koha/suggestion/suggestion.pl, use Fund filter, confirm it does not offer an Any option 3 - apply patch, reload page 4 - use Fund filter, confirm it shows Any as an option and both Any and None work properly 5 - confirm you cannot select Any when creating a new suggestion -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38986 --- Comment #4 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Figured out what that op=save was for! We should allow Any as a filter, but not as an option when saving a suggestion. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38986 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177473|0 |1 is obsolete| | --- Comment #5 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 177474 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177474&action=edit Bug 38986: Restore Any in fund dropdown on suggestions homepage This patch restores Any as a budget filter option on the suggestions homepage, but does not allow one to select Any when saving a suggestion To test: 1 - have two suggestions, one with a fund assigned and one without 2 - go to /cgi-bin/koha/suggestion/suggestion.pl, use Fund filter, confirm it does not offer an Any option 3 - apply patch, reload page 4 - use Fund filter, confirm it shows Any as an option and both Any and None work properly 5 - confirm you cannot select Any when creating a new suggestion -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38986 Biblibre Sandboxes <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177474|0 |1 is obsolete| | --- Comment #6 from Biblibre Sandboxes <sandboxes@biblibre.com> --- Created attachment 177494 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177494&action=edit Bug 38986: Restore Any in fund dropdown on suggestions homepage This patch restores Any as a budget filter option on the suggestions homepage, but does not allow one to select Any when saving a suggestion To test: 1 - have two suggestions, one with a fund assigned and one without 2 - go to /cgi-bin/koha/suggestion/suggestion.pl, use Fund filter, confirm it does not offer an Any option 3 - apply patch, reload page 4 - use Fund filter, confirm it shows Any as an option and both Any and None work properly 5 - confirm you cannot select Any when creating a new suggestion Signed-off-by: Sam Sowanick <sam.sowanick@corvallisoregon.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38986 SamSowanick <sam.sowanick@corvallisoregon.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38986 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |m.de.rooy@rijksmuseum.nl --- Comment #7 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Still a bit confused here. I would not expect the same set of values for the filter dropdown and the actual fund field. I think that the filter should always list Any. No selection on fund. And that the fund field should not Any but should have None. Now we are using the same block and that does not work imo.. Please clarify. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38986 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38986 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think none would be "no fund set" while "any" means it can be empty or set to any fund - that would make sense to me as a default. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38986 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38986 --- Comment #9 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 178101 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178101&action=edit Bug 38986: Restore Any option to suggestions homepage filter "Any" should show all suggestions, any fund value and null fund values. One should not be able to create a suggeestion set to "Any" "None" should show only suggestions with no fund value selected. A new suggestion should default to "None" To Test: 1: have two suggestions, one with a fund selected and one without 2: go to suggestions homepage, confirm the filter does not have an "Any" option 3: apply patch, reload page 4: confirm the fund filter on suggestion homepage now has both Any and None and they behave as described above 5: confirm the fund filter defaults to Any as you change the branch filter 6: create a new suggestion, confirm its fund defaults to None and cannot be set to Any -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38986 --- Comment #10 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- (In reply to Marcel de Rooy from comment #7)
Still a bit confused here. I would not expect the same set of values for the filter dropdown and the actual fund field. I think that the filter should always list Any. No selection on fund. And that the fund field should not Any but should have None. Now we are using the same block and that does not work imo..
Please clarify.
Agreed, using the same form for creation and filtering made this weird! I realized I'd made "None" disappear from the filter. New patch corrects that and clarifies expectations in the test plan. Thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38986 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38986 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177494|0 |1 is obsolete| | --- Comment #11 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 178139 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178139&action=edit Bug 38986: Restore Any in fund dropdown on suggestions homepage This patch restores Any as a budget filter option on the suggestions homepage, but does not allow one to select Any when saving a suggestion To test: 1 - have two suggestions, one with a fund assigned and one without 2 - go to /cgi-bin/koha/suggestion/suggestion.pl, use Fund filter, confirm it does not offer an Any option 3 - apply patch, reload page 4 - use Fund filter, confirm it shows Any as an option and both Any and None work properly 5 - confirm you cannot select Any when creating a new suggestion Signed-off-by: Sam Sowanick <sam.sowanick@corvallisoregon.gov> Bug 38986: Restore Any option to suggestions homepage filter "Any" should show all suggestions, any fund value and null fund values. One should not be able to create a suggeestion set to "Any" "None" should show only suggestions with no fund value selected. A new suggestion should default to "None" To Test: 1: have two suggestions, one with a fund selected and one without 2: go to suggestions homepage, confirm the filter does not have an "Any" option 3: apply patch, reload page 4: confirm the fund filter on suggestion homepage now has both Any and None and they behave as described above 5: confirm the fund filter defaults to Any as you change the branch filter 6: create a new suggestion, confirm its fund defaults to None and cannot be set to Any Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38986 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178101|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38986 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #12 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Since this is marked trivial and tested before, I will continue passing QA now. Have squashed both patches in the process. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38986 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38986 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |25.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38986 --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38986 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |me@paulderscheid.xyz, | |wainuiwitikapark@catalyst.n | |et.nz --- Comment #14 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Rmaints, please backport this to 24.11 and 24.05 as it creates confusion for users. Thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38986 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_24_11_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38986 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|25.05.00 |25.05.00,24.11.03 released in| | Status|Pushed to main |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38986 --- Comment #15 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Nice work everyone! Pushed to 24.11.x for 24.11.03 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38986 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_24_11_candidate | CC| |paul.derscheid@lmscloud.de -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38986 Marion Durand <marion.durand@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |minna.kivinen@hamk.fi --- Comment #16 from Marion Durand <marion.durand@biblibre.com> --- *** Bug 39105 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38986 --- Comment #17 from Marion Durand <marion.durand@biblibre.com> --- *** Bug 39105 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38986 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting --- Comment #18 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Depends on bug not in 22.11.x Not backporting to 22.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org