https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34149 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Syndetics cover images |Syndetics cover images |don't load in staff |don't load in staff |interface detail page in |interface detail page if |other images services are |other images services are |enabled |enabled -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34149 --- Comment #2 from Lucas Gass <lucas@bywatersolutions.com> --- The #syndetics-bookcoverimg is prematurely removed. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34149 --- Comment #3 from Lucas Gass <lucas@bywatersolutions.com> --- This is because when Amazon is used there is a check for 1px by 1px images inside of detail.tt. Then, without a visible syndetics image the entire container is removed. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34149 --- Comment #4 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 154349 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154349&action=edit Bug 34149: Let Syndetics images show when Amazon returns 1px images 1. Turn on Syndetics 2. Set AmazonCoverImages to show 3. Go to a record detail page that has a Syndetics image but no Amazon image. In KTD I am using bib 181. 4. The image never loads. 5. Apply patch 6. Try again, the image should load. 7. Try records that have both Amazon and Syndetics images making sure it loads correctly in the lightbox. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34149 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard@myacpl.org -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34149 Biblibre Sandboxes <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154349|0 |1 is obsolete| | --- Comment #6 from Biblibre Sandboxes <sandboxes@biblibre.com> --- Created attachment 155551 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155551&action=edit Bug 34149: Let Syndetics images show when Amazon returns 1px images 1. Turn on Syndetics 2. Set AmazonCoverImages to show 3. Go to a record detail page that has a Syndetics image but no Amazon image. In KTD I am using bib 181. 4. The image never loads. 5. Apply patch 6. Try again, the image should load. 7. Try records that have both Amazon and Syndetics images making sure it loads correctly in the lightbox. Signed-off-by: Stina Hallin <stina.hallin@ub.lu.se> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34149 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155551|0 |1 is obsolete| | --- Comment #7 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 155768 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155768&action=edit Bug 34149: Let Syndetics images show when Amazon returns 1px images 1. Turn on Syndetics (SyndeticsEnabled, SyndeticsCoverImages, SyndeticsClientCode) 2. Set AmazonCoverImages and OPACAmazonCoverImages to show 3. Go to a record detail page that has a Syndetics image but no Amazon image. In KTD I am using bib 181. It might work and require to find another record. 4. The image never loads. 5. Do the same test on the OPAC, same result 6. Apply patch 7. Try again, the image should load. 8. Try records that have both Amazon and Syndetics images making sure it loads correctly in the lightbox. 9. Same last steps for OPAC Signed-off-by: Stina Hallin <stina.hallin@ub.lu.se> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34149 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net Status|Signed Off |Failed QA --- Comment #9 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Exact same code on OPAC so same bug and attached follow-up to also fix OPAC. Follow-up needs someone else to test it. But before that, looking at the code, the same issue is very very likely to be there with anything else, right? custom-coverimg, googlejacket-coverimg, openlibrary-coverimg, coce-coverimg, bakertaylor-coverimg, "cover-image local-coverimg". And custom-coverimg also has a path to "div.remove();" so it should trigger the same issue than amazon-bookcoverimg. Oh no >_< Either the same fix is applied to all of them. `if ( $('#amazon-bookcoverimg').length === 0 )` need to be changed to account for custom-coverimg case. Maybe it's tricky because custom-coverimg isn't the 1st one when amazon is enabled. Also maybe careful when both are in their invalid cases. Nooooot sure, I'm way too confused now 😵‍💫😵‍💫😵‍💫 Either there is a more clever way than putting div.show() on all cases and instead just prevent amazon-bookcoverimg handling to mess with the others. Inspecting the page: why is the problem even happening? The div removed is only the one for amazon-bookcoverimg. Why does that messes the others? Ah ok, it's because the 1st one is shown and if at the end of the processing none is visible then the whole enclosing div is removed. That's the root of the whole mess. Idea: After the div.remove(); in the 1x1 pixel case, make the next element in $(img) visible. Wait, custom-coverimg needs to same (right?) but it needs to check if themselves are visible. Otherwise if amazon has a valid image it would cause the 3rd image to be visible at the same time. And check it before doing div.remove()! Ok it's still wacky 😵‍💫 Alternative idea: set the 1st one visible by default **after the processing** of all of them, so we don't care about all the mess they do. After `// Loop over each container in the template which contains covers` separation_of_concerns++ The issue is mixing getting data and filtering out the invalid ones and mixing display logic (1st img tab visible on page load) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34149 Michelle Spinney <mspinney@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mspinney@clamsnet.org -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34149 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |victor@tuxayo.net |y.org | --- Comment #12 from Victor Grousset/tuxayo <victor@tuxayo.net> ---

All very good ideas! But I would say outside of the scope of this bugfix.

Amazon isn't the only one that can trigger this issue (custom-coverimg also). And syndetics wasn't the only one that gets broken when the issue happens. (all the others should have the same issue when the div is removed) So it didn't seem out of the scope since the same problem a few lines after and the same consequences in a few places after. So a fix of only syndetics only in the amazon case was the reason to FQA. But yes the fix is much simpler for only the intersection of one cause (amazon) of the two and fixing on broken place (syndetics) of the few. ---

Also, I was never able to recreate this problem on the OPAC, is the OPAC follow-up necessary?

Weird, looking at it I even updated the test plan to reproduce and check the fix on the OPAC. Damn it, the test record I had was a transient failing case. «It might work and require to find another record.» On master I just got it working for both the OPAC and staff interface >_< Found another case! :D biblionumber=3 ISBN: 0520078438 Introduction to Attic Greek / Donald J. Mastronarde Can reproduce on OPAC and staff. And the current patches here fix it. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34149 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34149 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off QA Contact|victor@tuxayo.net |testopia@bugs.koha-communit | |y.org --- Comment #15 from Victor Grousset/tuxayo <victor@tuxayo.net> --- (In reply to Lucas Gass from comment #14)

I don't see a reason why this is FQA, so I am reseting to 'Needs signoff' in an effort to get this moving again. If there is a valid reason why this was set to FQA please explain. :)

I'm not sure I have chances to better phrase the issue on a 3rd attempt. Without having even partial responses about how the finding in the two first attempts/comments are not actually issues. So let's wait for another pair of QA eyes. I've highlighted my two comments so they can straight see what might be the issues. I'm obsoleting my follow-up for the OPAC. So this can go back to signed off and not need someone else's testing, without even being sure that the approach in good enough. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34149 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pm@interleaf.ie --- Comment #16 from Lucas Gass <lucas@bywatersolutions.com> --- *** Bug 33959 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34149 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #18 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Moving back to FQA in view of previous discussion. -- You are receiving this mail because: You are watching all bug changes.