[Bug 31575] New: Missing warning for holds where AllowHoldPolicyOverride can be used to force a hold to be placed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31575 Bug ID: 31575 Summary: Missing warning for holds where AllowHoldPolicyOverride can be used to force a hold to be placed Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: kyle@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com If some holds are overridable, and AllowHoldPolicyOverride is enabled, Koha used to "flag" each holdable item to let librarians know the hold could not normally be placed. In 22.05 up to current master as of this writing, no warning is displayed. Test Plan: 1) Set one circ rule to allow 0 holds 2) For Library A, set "Hold pickup library match" to "item's hold group" 3) Enable AllowHoldPolicyOverride 4) Set ReservesControlBranch to "item's home branch" 5) Create a record with an item for Library A, one for Library B, and one for Library C This should create a scenario where A's item cannot be held, and B and C's items must be overridden 6) Note you get the "Cannot place hold" but can place those holds anyway without a "warning" sign -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31575 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |kyle@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31575 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31575 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 140710 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140710&action=edit Bug 31575 - Missing warning for holds where AllowHoldPolicyOverride can be used to force a hold to be placed If some holds are overridable, and AllowHoldPolicyOverride is enabled, Koha used to "flag" each holdable item to let librarians know the hold could not normally be placed. In 22.05 up to current master as of this writing, no warning is displayed. Test Plan: 1) Set one circ rule to allow 0 holds 2) For Library A, set "Hold pickup library match" to "item's hold group" 3) Enable AllowHoldPolicyOverride 4) Set ReservesControlBranch to "item's home branch" 5) Create a record with an item for Library A, one for Library B, and one for Library C This should create a scenario where A's item cannot be held, and B and C's items must be overridden 6) Note you get the "Cannot place hold" but can place those holds anyway without a "warning" sign 7) Apply this patch 8) Restart all the things! 9) Reload the page, you should now see the warning icons! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31575 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31575 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31576 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31575 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31575 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140710|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 140737 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140737&action=edit Bug 31575 - Missing warning for holds where AllowHoldPolicyOverride can be used to force a hold to be placed If some holds are overridable, and AllowHoldPolicyOverride is enabled, Koha used to "flag" each holdable item to let librarians know the hold could not normally be placed. In 22.05 up to current master as of this writing, no warning is displayed. Test Plan: 1) Set one circ rule to allow 0 holds 2) For Library A, set "Hold pickup library match" to "item's hold group" 3) Enable AllowHoldPolicyOverride 4) Set ReservesControlBranch to "item's home branch" 5) Create a record with an item for Library A, one for Library B, and one for Library C This should create a scenario where A's item cannot be held, and B and C's items must be overridden 6) Note you get the "Cannot place hold" but can place those holds anyway without a "warning" sign 7) Apply this patch 8) Restart all the things! 9) Reload the page, you should now see the warning icons! Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31575 --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 141489 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141489&action=edit Bug 31575: Missing warning for holds where AllowHoldPolicyOverride can be used to force a hold to be placed If some holds are overridable, and AllowHoldPolicyOverride is enabled, Koha used to "flag" each holdable item to let librarians know the hold could not normally be placed. In 22.05 up to current master as of this writing, no warning is displayed. Test Plan: 1) Set one circ rule to allow 0 holds 2) For Library A, set "Hold pickup library match" to "item's hold group" 3) Enable AllowHoldPolicyOverride 4) Set ReservesControlBranch to "item's home branch" 5) Create a record with an item for Library A, one for Library B, and one for Library C This should create a scenario where A's item cannot be held, and B and C's items must be overridden 6) Note you get the "Cannot place hold" but can place those holds anyway without a "warning" sign 7) Apply this patch 8) Restart all the things! 9) Reload the page, you should now see the warning icons! Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31575 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Attachment #140737|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31575 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Working as expected now.. another one where perhaps moving things up a level would mean we had unit tests to prevent such a regression.. but nothing to prevent a QA pass here. Passed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31575 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31575 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31575 --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31575 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Version(s)|22.11.00 |22.11.00, 22.05.08 released in| | Status|Pushed to master |Pushed to stable --- Comment #6 from Lucas Gass <lucas@bywatersolutions.com> --- Backported to 22.05.x for upcoming 22.05.08 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31575 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable CC| |arthur.suzuki@biblibre.com Version(s)|22.11.00, 22.05.08 |22.11.00, 22.05.08, released in| |21.11.15 --- Comment #7 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- applied to 21.11 for 21.11.15 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31575 wainuiwitikapark@catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark@catalyst.n | |et.nz --- Comment #8 from wainuiwitikapark@catalyst.net.nz --- Not backported to 21.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31575 Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rickard.lindfors@sh.se --- Comment #9 from Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> --- *** Bug 26841 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31575 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com --- Comment #10 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- I have been git bisect a selenium failure on 21.11.x STRACE: /usr/share/perl5/Try/Tiny.pm:123 in Selenium::Remote::Driver::catch {...} /usr/local/share/perl/5.32.1/Selenium/Remote/Driver.pm:361 in Try::Tiny::try (eval 1693):1 in Selenium::Remote::Driver::__ANON__ (eval 1695):2 in Selenium::Remote::Driver::__ANON__ /usr/local/share/perl/5.32.1/Selenium/Remote/Driver.pm:1335 in Selenium::Remote::Driver::_execute_command /usr/local/share/perl/5.32.1/Selenium/Remote/Driver.pm:1335 in (eval) t/db_dependent/selenium/basic_workflow.t:263 in Selenium::Remote::Driver::find_element Error while executing command: unexpected alert open: Dismissed user prompt dialog: And found this commit 7a88155fe13c3a4f71f1a8d09b170738e7d8cbb8 is the first bad commit It's crazy that the failure has been ignored for so long... -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org