[Bug 6414] New: actual price not recorded when ordering
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6414 Bug #: 6414 Summary: actual price not recorded when ordering Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Platform: All OS/Version: All Status: NEW Severity: major Priority: P5 Component: Acquisitions AssignedTo: henridamien@koha-fr.org ReportedBy: nengard@gmail.com QAContact: koha-bugs@lists.koha-community.org When you enter an actual price at the time of placing an order (adding to a basket) it gets ignored by the db (http://screencast.com/t/7Py5tFyjl6c4). It's not until you receive that that field is populated in the database (http://screencast.com/t/XEtPeYIq). Given that one of two things needs to happen. 1. Remove actual price from the order form and only have it on receive 2. Leave actual price on the order form and populate the database with the values entered in the form. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6414 --- Comment #1 from Maxime Pelletier <pelletiermaxime@gmail.com> 2011-10-12 14:16:26 UTC --- Created attachment 5855 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5855 patch to fix the problem Originally attached to #6879. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6414 Maxime Pelletier <pelletiermaxime@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent CC| |pelletiermaxime@gmail.com Patch Status|--- |Signed Off Change sponsored?|--- |Sponsored -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6414 Maxime Pelletier <pelletiermaxime@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5855|0 |1 is patch| | Attachment #5855|application/octet-stream |text/plain mime type| | -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6414 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5855|0 |1 is obsolete| | --- Comment #2 from Paul Poulain <paul.poulain@biblibre.com> 2011-10-14 09:38:25 UTC --- Created attachment 5884 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5884 Use unitprice in neworder so that the value is saved in the database and so it will be the same field used as to receive shipments http://bugs.koha-community.org/show_bug.cgi?id=6414 Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> Signed off with a note: this doesn't fix everything mentioned in the bug. It also might clash with bug 4831 and should be tested with that patch. Signed-off-by: Paul Poulain <paul.poulain@biblibre.com> -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6414 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |paul.poulain@biblibre.com Patch Status|Signed Off |Passed QA --- Comment #3 from Paul Poulain <paul.poulain@biblibre.com> 2011-10-14 09:40:31 UTC --- QA comment : * very explanatory screencast from Nicole * small & clean code passed QA Side comment : the actual price is not set by the javascript like other prices are calculated when you fill the vendor price. Couldn't this field be set also ? (that would be another bug/patch, just wondering here while testing) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6414 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-10-14 09:44:04 UTC --- I don't think it should be filled. Actual price should only be filled in after the item was received and has an actual price. The valuse should always come from the database. So no calculation done there. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6414 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|master |rel_3_6 Patch Status|Passed QA |Patch Pushed --- Comment #5 from Paul Poulain <paul.poulain@biblibre.com> 2011-11-04 07:08:04 UTC --- Patch pushed, please test (my 1st push!!!) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6414 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|henridamien@koha-fr.org |pelletiermaxime@gmail.com -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6414 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution| |FIXED --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-11-29 07:19:24 UTC --- Checked that actual price shows up when modifying and receiving an order line. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org