[Bug 6963] New: When creating a new order, the item isn't added if its barcode already exists in the items table.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6963 Bug #: 6963 Summary: When creating a new order, the item isn't added if its barcode already exists in the items table. Classification: Unclassified Change sponsored?: --- Product: Koha Version: rel_3_6 Platform: All OS/Version: All Status: NEW Severity: normal Priority: P5 Component: Acquisitions AssignedTo: henridamien@koha-fr.org ReportedBy: fcapovilla@live.ca QAContact: koha-bugs@lists.koha-community.org Created attachment 5682 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5682 Corrects a problem when a new order is created with a duplicate barcode. The problem happens if the AcqCreateItem preference is set to "ordering". If we try to add a new order with a barcode that's already used in the items table, no error is returned, but an invalid itemnumber is saved in the aqorders_items table and the new item is never created. Patch attached that adds a duplicate barcode verification in neworderempty.pl and modifies _koha_add_item so it won't return an invalid ID when an item can't be added. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6963 Frédérick Capovilla <fcapovilla@live.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent Status|NEW |ASSIGNED Patch Status|--- |Needs Signoff Change sponsored?|--- |Sponsored AssignedTo|henridamien@koha-fr.org |fcapovilla@live.ca --- Comment #1 from Frédérick Capovilla <fcapovilla@live.ca> 2011-10-03 19:45:31 UTC --- Patch sponsored by the CCSR. ( http://www.ccsr.qc.ca/ ) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
Got a error message reporting the dublicate barcode
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6963 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Needs Signoff |Failed QA --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-10-08 20:19:27 UTC --- Hi Frédérick, this didn't work for me. I did: 1) Set AcqCreateItem on 'on order' 2) Made sure barcode was available in my ACQ framework 3) Created a new basket, first order, barcode 'barc' 4) created a second order in that basket, tried again with 'barc' 5) Changed the barcode to be something else and saved Problem: Order saved without error message, but no item was created -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6963 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-10-08 20:20:15 UTC --- Oh no... I looked at the wrong record. Checked again - all is well. Will sign-off. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6963 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5682|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-10-08 20:22:51 UTC --- Created attachment 5806 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5806 [SIGNED-OFF] Corrects a problem when a new order is created with a duplicate barcode. If the AcqCreateItem preference is set to "ordering" and the barcode for the new item is already in use, no error is returned, but an invalid itemnumber is saved in the aqorders_items table and the item is never created. This patch adds a duplicate barcode verification in neworderempty.pl _koha_add_item is also modified so it won't return an invalid ID when an item can't be added. http://bugs.koha-community.org/show_bug.cgi?id=6963 Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> 1) Set AcqCreateItem on 'on order' 2) Make sure barcode was available in my ACQ framework 3) Create a new basket, first order, barcode 'barc' 4) create a second order in that basket, tried again with 'barc' -> Alert message informs about the duplicate barcode 5) Change the barcode to be something else and saved New record with item should be correctly created -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6963 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Failed QA |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6963 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-10-08 21:51:17 UTC --- Ok, now I spotted a real problem, while doing some other tests. The check also detects empty barcodes. Test plan: 1) Create new basket 2) Create order with 2 items, leave both barcodes empty
The error message will show up. There is no way to save the items with empty barcodes.
-- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6963 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Signed Off |Failed QA -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6963 Frédérick Capovilla <fcapovilla@live.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5806|0 |1 is obsolete| | --- Comment #6 from Frédérick Capovilla <fcapovilla@live.ca> 2011-10-11 13:43:48 UTC --- Created attachment 5838 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5838 New version of the initial patch with empty barcodes ignored. Here is a new version of the patch. Empty barcodes should now be ignored. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6963 Frédérick Capovilla <fcapovilla@live.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Failed QA |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6963 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-10-13 05:59:04 UTC --- Hi Frédérick, I still see the problem. My test plan is: AcqCreateItem is set to 'on order' 1) Create new basket 2) Create new order (I did from suggestion) 3) Order 2 items, fill out itemtype, leave barcode blank On saving I get following alert: Form not submitted because of the following problem(s) ------------------------------------------------------------------- - The barcode is used more than once in the form. Every barcode must be unique -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6963 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Needs Signoff |Failed QA -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6963 --- Comment #8 from Frédérick Capovilla <fcapovilla@live.ca> 2011-10-13 17:38:46 UTC --- (In reply to comment #7)
Hi Frédérick,
I still see the problem. My test plan is:
AcqCreateItem is set to 'on order' 1) Create new basket 2) Create new order (I did from suggestion) 3) Order 2 items, fill out itemtype, leave barcode blank
On saving I get following alert:
Form not submitted because of the following problem(s) ------------------------------------------------------------------- - The barcode is used more than once in the form. Every barcode must be unique
I tried the same test plan after applying the newest patch on a branch based on 3.6 and I get no error when creating an order with two items with blank barcodes. Are you sure your barcodes were really blank? (no whitespaces) Did you apply the newest patch? The old one is obsolete. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6963 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-10-17 19:28:06 UTC --- Hi Frederick, I can't reproduce the problem with saving empty barcodes now. So this seems ok. But I found another problem with your patch - it looks like it's hardcoded to subfield 'p', while UNIMARC is using 995$f for barcodes. NORMARC uses the same mappings as MARC21. I think checking for the field mapped to items.barcode would be the best solution. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6963 --- Comment #10 from Frédérick Capovilla <fcapovilla@live.ca> 2011-10-17 20:09:23 UTC --- Created attachment 5944 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5944 Follow-up patch : use the subfield associated with items.barcode You're right, the barcode won't always be in subfield $p, so using the value of items.barcode is the right way to do it. Added a follow-up patch so the value of items.barcode is now used instead of 'p'. Thanks for the feedback. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6963 --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-10-17 20:47:57 UTC --- Created attachment 5945 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5945 [SIGNED-OFF] Follow-up patch : use the subfield associated with items.barcode Instead of using the 'p' subfield directly, use the subfield letter associated with the items.barcode column. http://bugs.koha-community.org/show_bug.cgi?id=6963 Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Test cases tested: - 1 item, barcode empty - 2 items, barcodes both empty - 1 item, existing barcode - 1 item, new barcode - 2 items, one barcode empty, one existing All test cases worked nicely and gave correct error messages. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6963 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5838|0 |1 is obsolete| | Attachment #5944|0 |1 is obsolete| | Attachment #5945|0 |1 is obsolete| | --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-10-17 20:48:37 UTC --- Created attachment 5946 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5946 [SIGNED-OFF] Bug 6963: Corrects a problem when a new order is created with a duplicate barcode. If the AcqCreateItem preference is set to "ordering" and the barcode for the new item is already in use, no error is returned, but an invalid itemnumber is saved in the aqorders_items table and the item is never created. This patch adds a duplicate barcode verification in neworderempty.pl _koha_add_item is also modified so it won't return an invalid ID when an item can't be added. http://bugs.koha-community.org/show_bug.cgi?id=6963 Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Test plan on second patch. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6963 --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-10-17 20:48:44 UTC --- Created attachment 5947 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5947 [SIGNED-OFF] Follow-up patch : use the subfield associated with items.barcode Instead of using the 'p' subfield directly, use the subfield letter associated with the items.barcode column. http://bugs.koha-community.org/show_bug.cgi?id=6963 Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Test cases tested: - 1 item, barcode empty - 2 items, barcodes both empty - 1 item, existing barcode - 1 item, new barcode - 2 items, one barcode empty, one existing All test cases worked nicely and gave correct error messages. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6963 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Failed QA |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
From a functionnal point of view, I can't see a case where you define the barcode when ordering the biblio (ie : you don't have it yet). When recieving it's more common. So more libraries will face the bug in the 'Recieving' case
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6963 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.poulain@biblibre.com --- Comment #14 from Paul Poulain <paul.poulain@biblibre.com> 2011-10-18 14:48:53 UTC --- QA comment: * this patch fixes the described problem. BUT : the same problem exist also if AcqCreateItem='Recieving' (ie = placing barcode when recieving). (No problem/bug for AcqCreateItem='Cataloguing') * Thanks katrin for the hardcoded 'p' = in UNIMARC, the barcode is in 995$f ! than in the 'Ordering' one. Would you agree to send a follow-up to have a fully working fix ? Proposing passed QA for the 2 first patches, bug please, don't close the bug until a 3rd patch has been submitted. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6963 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5947|0 |1 is obsolete| | --- Comment #15 from Paul Poulain <paul.poulain@biblibre.com> 2011-10-18 14:49:24 UTC --- Created attachment 5954 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5954 Follow-up patch : use the subfield associated with items.barcode Instead of using the 'p' subfield directly, use the subfield letter associated with the items.barcode column. http://bugs.koha-community.org/show_bug.cgi?id=6963 Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Test cases tested: - 1 item, barcode empty - 2 items, barcodes both empty - 1 item, existing barcode - 1 item, new barcode - 2 items, one barcode empty, one existing All test cases worked nicely and gave correct error messages. Signed-off-by: Paul Poulain <paul.poulain@biblibre.com> -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6963 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Signed Off |Passed QA -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6963 --- Comment #16 from Frédérick Capovilla <fcapovilla@live.ca> 2011-10-19 14:32:15 UTC ---
Would you agree to send a follow-up to have a fully working fix ?
Unfortunately, our client doesn't need this improved fix for now, so I can't devote time on a third patch. If anybody could work on an improved fix, it would be greatly appreciated. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6963 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Passed QA |Patch Pushed --- Comment #17 from Paul Poulain <paul.poulain@biblibre.com> 2011-11-04 09:24:44 UTC --- Patch pushed, please test -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6963 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution| |FIXED -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org