[Bug 9061] New: DataTables date sort does not work with date in uk format (dd/mm/yyyy)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9061 Priority: P5 - low Change sponsored?: --- Bug ID: 9061 Assignee: oleonard@myacpl.org Summary: DataTables date sort does not work with date in uk format (dd/mm/yyyy) Severity: normal Classification: Unclassified OS: All Reporter: oleonard@myacpl.org Hardware: All Status: NEW Version: master Component: Templates Product: Koha With the older tablesorter plugin you could specify the UK date format: $("#issuest").tablesorter({[% IF ( dateformat_metric ) %] dateFormat: 'uk',[% END %]... It doesn't look like DataTables has this option built in. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9061 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9061 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 13493 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13493&action=edit Bug 9061 - DataTables date sort does not work with date in uk format (dd/mm/yyyy) The DataTables plugin doesn't include native support for sorting date in uk/euro format (dd/mm/yyyy). This patch adds a plugin to be optionally included in cases where the Koha dateformat preference is set to "metric." The patron circulation history page is the only page affected by this patch. If it is found to be working well I will submit follow-ups to cover other instances where sorting by date occurs. To test, load the patron circulation history page (members/readingrec.pl) for a patron with a circulation history. Sorting by "date," "checked out on," "date due," and "Return date" should work correctly with under all three dateformat settings. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9061 Melia Meggs <melia@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13493|0 |1 is obsolete| | --- Comment #2 from Melia Meggs <melia@bywatersolutions.com> --- Created attachment 13494 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13494&action=edit [Signed off] Bug 9061 - DataTables date sort does not work with date in uk format (dd/mm/yyyy) The DataTables plugin doesn't include native support for sorting date in uk/euro format (dd/mm/yyyy). This patch adds a plugin to be optionally included in cases where the Koha dateformat preference is set to "metric." The patron circulation history page is the only page affected by this patch. If it is found to be working well I will submit follow-ups to cover other instances where sorting by date occurs. To test, load the patron circulation history page (members/readingrec.pl) for a patron with a circulation history. Sorting by "date," "checked out on," "date due," and "Return date" should work correctly with under all three dateformat settings. Signed-off-by: Melia Meggs <melia@test.bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9061 Melia Meggs <melia@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |melia@bywatersolutions.com --- Comment #3 from Melia Meggs <melia@bywatersolutions.com> --- To test, I set dateformat to dd/mm/yyyy. Before applying patch, the patron's circulation history showed in this date order: 12/03/2012 (March 12, 2012) 13/09/2012 (September 13, 2012) 14/06/2012 (June 14, 2012) After applying the patch, the patron's circulation history was correctly ordered by date. I also checked that "checked out on," "date due," and "return date" all sort in correct date order as well. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9061 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m --- Comment #4 from Jonathan Druart <jonathan.druart@biblibre.com> --- Hi Owen, Your patch works. But do you know a (quite) similar function already exist (dt_add_type_uk_date in js/datatables.js)? (see booksellers.tt and aqbugetperiods.tt for example). This function does not handle hours in date but maybe we could regroup both functions (file, function name, etc.)? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9061 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |RESOLVED Resolution|--- |INVALID -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9061 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #5 from David Cook <dcook@prosentient.com.au> --- Why has this been marked as resolved invalid? It seems to me like this is still something that is needed... -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9061 --- Comment #6 from David Cook <dcook@prosentient.com.au> --- (In reply to David Cook from comment #5)
Why has this been marked as resolved invalid?
It seems to me like this is still something that is needed...
Nevermind. Answered my own question: Bug 9108 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org