[Bug 7608] New: Manual history is always 'enabled'
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7608 Bug #: 7608 Summary: Manual history is always 'enabled' Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Platform: All OS/Version: All Status: NEW Severity: normal Priority: P5 - low Component: Serials AssignedTo: colin.campbell@ptfs-europe.com ReportedBy: katrin.fischer@bsz-bw.de QAContact: koha.sekjal@gmail.com To reproduce: - Enter a new subscription in serials, make sure the manual history checkbox is not touched and no data is entered in that section. - The serial summary page will show 'Manual history: Enabled' - Editing the subscription will always show the manual history fields expanded. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7608 --- Comment #1 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This was previously reported and supposedly fixed on bug 3908. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7608 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7608 --- Comment #2 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Created attachment 15210 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15210&action=edit Bug 7608: Manual history should not always be enabled When editing a subscription, the "manual history" block is visible even if the subscription was created with manual history off. To test: 1) Create a subscription and do not check the "Manual history" checkbox. 2) Save the subscription. 3) Edit the subscription. Note that the manual history section does not appear. 4) Enable manual history. Note the appearance of the manual history section. 5) Save the subscription. 6) Edit the subscription. Note that the manual history section appears. 7) Click "[cancel manual history]". Note the disappearance of the manual history section, and the unchecking of the "Manual history" checkbox. 8) Sign off on patch. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7608 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7608 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15210|0 |1 is obsolete| | --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 15260 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15260&action=edit [SIGNED-OFF] Bug 7608: Manual history should not always be enabled When editing a subscription, the "manual history" block is visible even if the subscription was created with manual history off. To test: 1) Create a subscription and do not check the "Manual history" checkbox. 2) Save the subscription. 3) Edit the subscription. Note that the manual history section does not appear. 4) Enable manual history. Note the appearance of the manual history section. 5) Save the subscription. 6) Edit the subscription. Note that the manual history section appears. 7) Click "[cancel manual history]". Note the disappearance of the manual history section, and the unchecking of the "Manual history" checkbox. 8) Sign off on patch. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7608 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|colin.campbell@ptfs-europe. |jcamins@cpbibliography.com |com | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7608 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |jonathan.druart@biblibre.co | |m QA Contact|koha.sekjal@gmail.com |jonathan.druart@biblibre.co | |m --- Comment #4 from Jonathan Druart <jonathan.druart@biblibre.com> --- QA comment: Works as advertised. Note that a complete rewrite of this part of code is waiting sign-off (Bug 7688). Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7608 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15260|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 15275 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15275&action=edit Bug 7608: Manual history should not always be enabled When editing a subscription, the "manual history" block is visible even if the subscription was created with manual history off. To test: 1) Create a subscription and do not check the "Manual history" checkbox. 2) Save the subscription. 3) Edit the subscription. Note that the manual history section does not appear. 4) Enable manual history. Note the appearance of the manual history section. 5) Save the subscription. 6) Edit the subscription. Note that the manual history section appears. 7) Click "[cancel manual history]". Note the disappearance of the manual history section, and the unchecking of the "Manual history" checkbox. 8) Sign off on patch. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7608 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #6 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7608 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris@bigballofwax.co.nz --- Comment #7 from Chris Cormack <chris@bigballofwax.co.nz> --- No string changes pushed to 3.10.x will be in 3.10.3 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7608 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org