[Bug 24693] New: GD is declared as an optional dependency but Koha dies without it
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24693 Bug ID: 24693 Summary: GD is declared as an optional dependency but Koha dies without it Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: julian.maurice@biblibre.com Reporter: julian.maurice@biblibre.com QA Contact: testopia@bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24693 --- Comment #1 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 99299 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99299&action=edit Bug 24693: Move GD from recommends to requires in cpanfile Without it, catalogue/detail.pl dies (and probably other scripts too) Test plan: 1. Uninstall GD, reload starman 2. Go to catalogue/detail.pl. Confirm that it dies 3. Reinstall GD, reload starman 4. Go to catalogue/detail.pl. Confirm that it work normally -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24693 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24693 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24693 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99299|0 |1 is obsolete| | --- Comment #2 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 99475 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99475&action=edit Bug 24693: Move GD from recommends to requires in cpanfile Without it, catalogue/detail.pl dies (and probably other scripts too) Test plan: 1. Uninstall GD, reload starman 2. Go to catalogue/detail.pl. Confirm that it dies 3. Reinstall GD, reload starman 4. Go to catalogue/detail.pl. Confirm that it work normally Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> catalogue/detail.pl dies without GD. Seems correct switch to require No errors -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24693 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- It does not die for me, it dies if I enable LocalCoverImages, then try to upload an image. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24693 --- Comment #4 from Julian Maurice <julian.maurice@biblibre.com> --- Maybe we should clarify what does *required* mean for us. Personally I believe that every Perl module that we directly `use` or `require` without checking its presence should be flagged as required. Even if the require is behind a syspref check or something like that. Put more simply, if Koha dies because of a missing Perl module, that module is a required dependency. Maybe later we can build something based on cpanfile's `feature` (https://metacpan.org/pod/distribution/Module-CPANfile/lib/cpanfile.pod#featu...) to warn when an optional feature is enabled and the required modules for this feature are missing. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24693 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- (In reply to Julian Maurice from comment #4)
Maybe we should clarify what does *required* mean for us.
Personally I believe that every Perl module that we directly `use` or `require` without checking its presence should be flagged as required. Even if the require is behind a syspref check or something like that. Put more simply, if Koha dies because of a missing Perl module, that module is a required dependency.
Maybe later we can build something based on cpanfile's `feature` (https://metacpan.org/pod/distribution/Module-CPANfile/lib/cpanfile. pod#feature) to warn when an optional feature is enabled and the required modules for this feature are missing.
The whole 'feature' stuff from the cpanfile move came up earlier that I was expecting.. but I suspected it would raise it's head at some point. I'm really not sure what way to fall on this one.. I don't like that changing a syspref can completely 'break', i.e lead to a die, koha.. but at the same time if a set of functionality is optional, the dependencies it requires really aught to be too. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24693 --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #3)
It does not die for me, it dies if I enable LocalCoverImages, then try to upload an image.
That was wrong, I removed libgd-perl, that removed koha-common. The alias restart_all got broken, as it did not correctly restart plack, etc. So yes, detail.pl crashes with GD. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24693 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24693 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #99475|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 99510 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99510&action=edit Bug 24693: Move GD from recommends to requires in cpanfile Without it, catalogue/detail.pl dies (and probably other scripts too) Test plan: 1. Uninstall GD, reload starman 2. Go to catalogue/detail.pl. Confirm that it dies 3. Reinstall GD, reload starman 4. Go to catalogue/detail.pl. Confirm that it work normally Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> catalogue/detail.pl dies without GD. Seems correct switch to require No errors Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24693 --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- We will make it (really) optional if there is a real need for that. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24693 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24693 --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24693 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy@bywatersolutions.com --- Comment #10 from Joy Nelson <joy@bywatersolutions.com> --- Does not apply to 19.11.x branch. Not backported -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org