[Bug 23395] New: batch operations on biblios/items should be able to pass a list of plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23395 Bug ID: 23395 Summary: batch operations on biblios/items should be able to pass a list of plugins Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: tomascohen@gmail.com QA Contact: testopia@bugs.koha-community.org Even with bug 21073 pushed, there's no need to fetch the list of plugins implementing the required hooks, on each record in the loop. We should really make the plugins list a parameter to ModBiblio. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23395 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |22709 Assignee|koha-bugs@lists.koha-commun |tomascohen@gmail.com |ity.org | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22709 [Bug 22709] Add hooks to notify plugins of biblio and item changes -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23395 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |fridolin.somers@biblibre.co | |m, josef.moravec@gmail.com, | |kyle@bywatersolutions.com, | |martin.renvoize@ptfs-europe | |.com, | |nick@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23395 --- Comment #1 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 91870 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91870&action=edit Bug 23395: Unit tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23395 --- Comment #2 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 91871 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91871&action=edit Bug 23395: Add a $plugins parameter to *Biblio and *Item methods This patch adds a $plugin parameter (the way those methods already expect parameters) that is expected to contain an arrayref of plugin object instances. The target scenario are batch operations, in which we really don't want to fetch the available plugins on each iteration. This patch doesn't make batch-related scripts use this new option. It will be done on a follow-up patch. To test: - Apply this patches - Run: $ kshell k$ prove t/db_dependent/Koha/Plugins/Biblio_and_Items_plugin_hooks.t => SUCCESS: All tests pass, new tests as well - Sign off :-D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23395 --- Comment #3 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 91872 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91872&action=edit Bug 23395: Add Test::NoWarrnings dependency -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23395 --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 91874 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91874&action=edit Bug 23395: Fetch the plugins only once in bulkmarcimport.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23395 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Architecture, internals, |Plugin architecture |and plumbing | CC| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23395 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Why did I leave this one ASSIGNED? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23395 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |david@davidnind.com --- Comment #6 from David Nind <david@davidnind.com> --- Patch no longer applies: Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 23395: Unit tests Using index info to reconstruct a base tree... M t/db_dependent/Koha/Plugins/Biblio_and_Items_plugin_hooks.t Falling back to patching base and 3-way merge... Auto-merging t/db_dependent/Koha/Plugins/Biblio_and_Items_plugin_hooks.t CONFLICT (content): Merge conflict in t/db_dependent/Koha/Plugins/Biblio_and_Items_plugin_hooks.t error: Failed to merge in the changes. Patch failed at 0001 Bug 23395: Unit tests -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org