http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12673 --- Comment #1 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 30301 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30301&action=edit Bug 12673: Remove CGI::scrolling_list from C4::Items.pm This patch removes only instance in this file To test: 1. Apply the patch 2. (Esay way) Put on staff URL /cgi-bin/koha/services/itemrecorddisplay.pl?biblionumber=N&itemnumber=M 3. Code replaced corresponds to pulldowns, verify information is correct (check with another item edit view) PrepareItemrecordDisplay() in Items.pm is filled with chunks of HTML code that must be put on TT file. For now scrolling_list is the only removed. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12673 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30301|0 |1 is obsolete| | --- Comment #2 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 30407 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30407&action=edit Bug 12673: Remove CGI::scrolling_list from C4::Items.pm This patch removes only instance in this file To test: 1. Apply the patch 2. (Esay way) Put on staff URL /cgi-bin/koha/services/itemrecorddisplay.pl?biblionumber=N&itemnumber=M 3. Code replaced corresponds to pulldowns, verify information is correct (check with another item edit view) PrepareItemrecordDisplay() in Items.pm is filled with chunks of HTML code that must be put on TT file. For now scrolling_list is the only removed. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12673 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30407|0 |1 is obsolete| | --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 30434 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30434&action=edit [SIGNED-OFF] Bug 12673: Remove CGI::scrolling_list from C4::Items.pm This patch removes only instance in this file To test: 1. Apply the patch 2. (Esay way) Put on staff URL /cgi-bin/koha/services/itemrecorddisplay.pl?biblionumber=N&itemnumber=M 3. Code replaced corresponds to pulldowns, verify information is correct (check with another item edit view) PrepareItemrecordDisplay() in Items.pm is filled with chunks of HTML code that must be put on TT file. For now scrolling_list is the only removed. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12673 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30434|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 30500 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30500&action=edit [PASSED QA] Bug 12673: Remove CGI::scrolling_list from C4::Items.pm This patch removes only instance in this file To test: 1. Apply the patch 2. (Esay way) Put on staff URL /cgi-bin/koha/services/itemrecorddisplay.pl?biblionumber=N&itemnumber=M 3. Code replaced corresponds to pulldowns, verify information is correct (check with another item edit view) PrepareItemrecordDisplay() in Items.pm is filled with chunks of HTML code that must be put on TT file. For now scrolling_list is the only removed. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Tested different item edit displays and the URL given above, no regressions found. Also passes all tests and QA script. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12673 --- Comment #6 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 30765 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30765&action=edit Bug 12673: Followup - fix display in serials-edit This patch fix the display of items information following changes on previous patch. To test: 1. Go to serials 2. Add a subscription 3. Receive an issue 4. Change status to Arrived Item information display correct labels, but no pulldowns, that's the bug 5. Apply the patch 6. Reload page, change to Arrived again, this time pulldowns must be right -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12673 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12673 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30765|0 |1 is obsolete| | --- Comment #7 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 30769 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30769&action=edit [SIGNED-OFF] Bug 12673: Followup - fix display in serials-edit This patch fix the display of items information following changes on previous patch. To test: 1. Go to serials 2. Add a subscription 3. Receive an issue 4. Change status to Arrived Item information display correct labels, but no pulldowns, that's the bug 5. Apply the patch 6. Reload page, change to Arrived again, this time pulldowns must be right Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12673 --- Comment #9 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 30777 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30777&action=edit Bug 12673: (followup) fix Supplemental issue too The same fix needs to be used for the 'Supplemental issue' part. To test, use the same test steps used for the previous followup, but choose "Arrived" in the 'Supplemental issue' row. Regards To+ Sponsored-by: Universidad Nacional de Cordoba -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12673 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12673 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m --- Comment #11 from Jonathan Druart <jonathan.druart@biblibre.com> --- This patch introduce a regression, I used git bisect, it pointed me: 4e278782f156a9d7452e6e9ddcefee9542b964fc is the first bad commit commit 4e278782f156a9d7452e6e9ddcefee9542b964fc Author: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Date: Tue Jul 29 15:00:56 2014 -0300 Bug 12673: Remove CGI::scrolling_list from C4::Items.pm This patch removes only instance in this file To reproduce, go on acqui/addorderiso2709.pl?import_batch_id=3&basketno=7&booksellerid=5 (change ids), tab 'Item information'. You will get: b - Propriétaire HASH(0xd220cb0) Required c - Dépositaire HASH(0xd44a3ec) Required e - Localisation HASH(0xd44ab30) Required The dropdown list are replaced by the hashref address. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12673 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13008 -- You are receiving this mail because: You are watching all bug changes.